Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic Filters Should Not Be Created in Element Picker When Cosmetic Filters Are Disabled #43

Closed
8 tasks done
Riajyuu opened this issue May 16, 2018 · 2 comments
Closed
8 tasks done
Labels
invalid not a uBlock issue unable to reproduce cannot reproduce the issue

Comments

@Riajyuu
Copy link

Riajyuu commented May 16, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

A.T.

A specific URL where the issue occurs

e.g., this page, https://github.com/uBlockOrigin/uBlock-issues/issues/new

Steps to Reproduce

  1. install UBO and disable cosmetic filters
  2. enter element picker mode
  3. create a rule

Expected behavior:

Cosmetic filters should not be created

Actual behavior:

Cosmetic filters are created

Your environment

  • uBlock Origin version: 1.16.6
  • Browser Name and version: Firefox 60 64-bit
  • Operating System and version: Windows 10 1803 latest
@gorhill
Copy link
Member

gorhill commented May 16, 2018

Unable to reproduce: I can't enter the element picker when cosmetic filters are disabled (gorhill/uBlock#3212).

@uBlock-user uBlock-user added the unable to reproduce cannot reproduce the issue label May 16, 2018
@uBlock-user
Copy link
Contributor

uBlock-user commented May 16, 2018

Due to an existing bug, the element picker wouldn't appear in the first place when cosmetic filtering is disabled.

@uBlock-user uBlock-user added the invalid not a uBlock issue label May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue unable to reproduce cannot reproduce the issue
Projects
None yet
Development

No branches or pull requests

3 participants