Fix phi-dependent JEC uncertainties [10_6_X backport] #28866

ahinzmann · 2020-02-04T22:56:55Z

Backport of #28864

PR description:

Fix issue #28860.
This has no impact on any CMS workflow, since JEC uncertainty have never had phi-dependence.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This may have an impact once we introduce corrections for 2018-HEM issue, thus backport down to 10_2 releases.

…ttingFor2018 FixLumisPerJobSplittingFor2018

…ions and a fix for pixel conditions for a single fill.

HCALDQM: HB TDC fix (10_6_X backport)

…igration-10-6-X [DQM][backport] Migrated subsystem availability per lumi plot to softFED

backport of LHEJetFilter

…018 eras

…_10_6_X_tau-pog_deepTauVetoPCA

…d Phase2 eras

If a cms.Sequence holds only tasks, the list of sequenceable elements is empty, and self.l[0] leads to an IndexError.

…018-gt-106X Data and MC global tags for 2018 UL [10_6_X]

…106X [10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing

APE tool: Trend plots, some minor fixes: Backport of cms-sw#27656

…_deepTauVetoPCA Disabled PCA inputs for deepTau v2 (10_6_X)

…_tau-pog_deepTauVetoPCA Temporarily revert "Disabled PCA inputs for deepTau v2 (10_6_X)"

Backport of changes from cms-sw#27988

…_1061 Fixing VID return value for HEEP Trk Iso: 10_6_X

This reverts commit 400dfeb.

…on_Backport_Fix Bugfix for PR28574

cmsbuild · 2020-02-04T22:57:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-02-04T23:04:56Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28866/13628

This PR adds an extra 36KB to repository
Found files with invalid states:
- PhysicsTools/PatAlgos/python/jetCollectionTools.py:
  - Added: 31272fb
  - Deleted: 71616fa
- DQM/MuonMonitor/interface/CosmicMuonRecoAnalyzer.h:
  - Added: 812b438
  - Deleted: 76597c0
- Configuration/Eras/python/Modifier_run2_tau_ul_2018_cff.py:
  - Added: dc037f1, 8904eea
  - Deleted: 400dfeb
- SimTracker/SiStripDigitizer/python/customizeSiStripAPVDynamicGainSimulation.py:
  - Added: 6c0d50a
  - Modified: 98e933e, 21f591a, 5843d3c, 3b56923
  - Deleted: 3c1be08
- Calibration/TkAlCaRecoProducers/python/SiPixelCalSingleMuonHLTFilter_cfi.py:
  - Added: e0df03b
  - Deleted: 9a57627
- DQM/MuonMonitor/src/CosmicMuonRecoAnalyzer.cc:
  - Added: 812b438
  - Deleted: 76597c0
- Configuration/Eras/python/Modifier_run2_tau_ul_2016_cff.py:
  - Added: dc037f1, 8904eea
  - Deleted: 400dfeb
- Configuration/AlCa/python/autoCond.py:
  - Modified: 3e876d3, 765cad3, 3d205fe, dd38d23, 89538fc, a7aed36, 3bbdc16, e466d38, f25b40a, 477ccd8, fbed2ac, 74382f7, 2436bbc, f0fae6e, 8a2f725, 7499880
  - Deleted: 2428563
  - Added: 3a62cbf
There are other open Pull requests which might conflict with changes you have proposed:
- File CommonTools/PileupAlgos/plugins/PuppiProducer.cc modified in PR(s): PUPPI in RECO #28659
- File CommonTools/PileupAlgos/plugins/PuppiProducer.h modified in PR(s): PUPPI in RECO #28659
- File CommonTools/PileupAlgos/python/Puppi_cff.py modified in PR(s): Add customizer for PUPPI tune v13 #28844
- File CondFormats/JetMETObjects/src/JetCorrectionUncertainty.cc modified in PR(s): Fix phi-dependent JEC uncertainties #28864
- File Configuration/PyReleaseValidation/python/relval_pileup.py modified in PR(s): New relvals workflows for JME customized nanoaod #28857
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): New relvals workflows for JME customized nanoaod #28857
- File DQM/GEM/plugins/GEMDQMStatusDigi.cc modified in PR(s): GEM DQM updates - full GE1/1 #28769
- File DQM/HcalTasks/plugins/DigiPhase1Task.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/HcalTasks/plugins/DigiTask.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/HcalTasks/plugins/RawTask.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/HcalTasks/plugins/RecHitTask.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/HcalTasks/plugins/TPTask.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/MuonMonitor/plugins/CosmicMuonRecoAnalyzer.cc modified in PR(s): EventSetup consumes migration for MuonServiceProxy #28840
- File DQM/TrackingMonitor/interface/TrackAnalyzer.h modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/TrackingMonitor/src/TrackingMonitor.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQM/TrackingMonitorClient/src/TrackingQualityChecker.cc modified in PR(s): DQM: Switch to edm::stream for DQMEDAnalyzer #28813, DQM: new DQMStore. #28622
- File DQMOffline/Configuration/python/DQMOffline_SecondStep_cff.py modified in PR(s): DQM: Remove DQMDcsInfo #28829, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQMOffline/Configuration/python/DQMOffline_cff.py modified in PR(s): DQM: Remove DQMDcsInfo #28829, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQMServices/Components/BuildFile.xml modified in PR(s): DQM: Remove ClientConfig package #28380
- File DQMServices/Components/plugins/DQMProvInfo.cc modified in PR(s): DQM: Remove DQMDcsInfo #28829
- File DataFormats/L1TrackTrigger/interface/TTTrack.h modified in PR(s): Update TTTrack for chi2 split #28793
- File DataFormats/L1TrackTrigger/interface/TTTrack_TrackWord.h modified in PR(s): Update TTTrack for chi2 split #28793
- File DataFormats/L1TrackTrigger/src/TTTrack_TrackWord.cc modified in PR(s): Update TTTrack for chi2 split #28793
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): New Tau ID data format #28417, PUPPI in RECO #28659
- File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): Updates for Custom JME NanoAODs: Fix JetID, update modifiers and able to run on data #28854, Add customizer for PUPPI tune v13 #28844
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): PUPPI in RECO #28659
- File PhysicsTools/PatAlgos/python/producersLayer1/tauProducer_cfi.py modified in PR(s): New Tau ID data format #28417
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): New Tau ID data format #28417, PUPPI in RECO #28659
- File PhysicsTools/PatAlgos/python/tools/jetCollectionTools.py modified in PR(s): Updates for Custom JME NanoAODs: Fix JetID, update modifiers and able to run on data #28854
- File PhysicsTools/PatAlgos/python/tools/tauTools.py modified in PR(s): New Tau ID data format #28417
- File RecoMuon/GlobalTrackingTools/plugins/GlobalTrackQualityProducer.cc modified in PR(s): EventSetup consumes migration for MuonServiceProxy #28840
- File RecoMuon/L3MuonProducer/src/L3MuonProducer.cc modified in PR(s): EventSetup consumes migration for MuonServiceProxy #28840
- File RecoTauTag/Configuration/python/HPSPFTaus_cff.py modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/Configuration/python/RecoTauTag_EventContent_cff.py modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/interface/DeepTauBase.h modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/plugins/DPFIsolation.cc modified in PR(s): Support for TensorFlow 2.1 #28711
- File RecoTauTag/RecoTau/plugins/DeepTauId.cc modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): New Tau ID data format #28417
- File RecoTauTag/RecoTau/src/DeepTauBase.cc modified in PR(s): Support for TensorFlow 2.1 #28711, New Tau ID data format #28417
- File Validation/RecoTrack/python/TrackingParticleSelectionsForEfficiency_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28866/13628/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28866/13628/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28866/13628/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28866/13628/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

andrius and others added 30 commits September 4, 2019 11:44

Fixed code checks

6eb89a4

Logging which version of FED is selected

2d2b52d

Merge pull request cms-sw#27911 from srimanob/106X_FixLumisPerJobSpli…

84f926f

…ttingFor2018 FixLumisPerJobSplittingFor2018

Updates to beamspot, tracker alignment, muon alignment, ECAL calibrat…

3e876d3

…ions and a fix for pixel conditions for a single fill.

Updated PPS conditions for consistency with 2018 UL

765cad3

Updated 2018 MC tracker alignment scenario and APEs

3d205fe

Backport of trend plotting tool

9688294

fixing returned value for heep trk isol

ca7c5c8

New era modifiers for tauID Run2 UL processing

dc037f1

New era modifiers for tauID Run2 UL processing in master cff

dbf0143

Merge pull request cms-sw#27881 from DryRun/CMSSW_10_6_2_hb-tdc

c8ca625

HCALDQM: HB TDC fix (10_6_X backport)

Merge pull request cms-sw#27924 from andrius-k/dqm-per-lumi-softFED-m…

c0f40e4

…igration-10-6-X [DQM][backport] Migrated subsystem availability per lumi plot to softFED

Merge pull request cms-sw#27812 from ohindrichs/lhejetfilter-10_6_x

1e43325

backport of LHEJetFilter

New era modifiers for tauID Run2 UL processing chained for 2016 and 2…

6081ba3

…018 eras

Merge remote-tracking branch 'official-cmssw/CMSSW_10_6_X' into CMSSW…

aad2192

…_10_6_X_tau-pog_deepTauVetoPCA

New era modifiers for tauID Run2 UL processing unchained from Run3 an…

633dfb4

…d Phase2 eras

backport of tau validation

08f1fea

Fix ExpandVisitor.result() to work also with an empty result

8a58caf

If a cms.Sequence holds only tasks, the list of sequenceable elements is empty, and self.l[0] leads to an IndexError.

backport jetid changes

acf4d1b

Merge pull request cms-sw#27934 from christopheralanwest/alca-final-2…

97345b7

…018-gt-106X Data and MC global tags for 2018 UL [10_6_X]

Merge pull request cms-sw#27916 from mmusich/fixPremixingForStuckTBM_…

3e9ea98

…106X [10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing

Merge pull request cms-sw#27936 from mteroerd/ape_trend_backport

ca3c6e4

APE tool: Trend plots, some minor fixes: Backport of cms-sw#27656

A fix for DQM HV per lumi plot

88a65dc

Merge pull request cms-sw#27882 from cms-tau-pog/CMSSW_10_6_X_tau-pog…

3353beb

…_deepTauVetoPCA Disabled PCA inputs for deepTau v2 (10_6_X)

Revert "Disabled PCA inputs for deepTau v2 (10_6_X)"

400dfeb

Merge pull request cms-sw#28032 from cms-sw/revert-27882-CMSSW_10_6_X…

3887146

…_tau-pog_deepTauVetoPCA Temporarily revert "Disabled PCA inputs for deepTau v2 (10_6_X)"

Update PackedCandidate.cc

33bf3a3

Backport of changes from cms-sw#27988

Merge pull request cms-sw#27945 from Sam-Harper/HEEPVIDTrkIsoValueFix…

86c60e2

…_1061 Fixing VID return value for HEEP Trk Iso: 10_6_X

Revert "Revert "Disabled PCA inputs for deepTau v2 (10_6_X)""

8904eea

This reverts commit 400dfeb.

Fix order of era modifiers

7dcc316

cmsbuild and others added 2 commits January 12, 2020 09:50

Merge pull request cms-sw#28731 from tvami/ALCARECOSiPixelCalSingleMu…

8f7331c

…on_Backport_Fix Bugfix for PR28574

fix jet phi JEC uncertainties

d614e99

cmsbuild added this to the CMSSW_11_1_X milestone Feb 4, 2020

cmsbuild added the backport label Feb 4, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 4, 2020

ahinzmann closed this Feb 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix phi-dependent JEC uncertainties [10_6_X backport] #28866

Fix phi-dependent JEC uncertainties [10_6_X backport] #28866

ahinzmann commented Feb 4, 2020 •

edited

Loading

cmsbuild commented Feb 4, 2020

cmsbuild commented Feb 4, 2020

Fix phi-dependent JEC uncertainties [10_6_X backport] #28866

Fix phi-dependent JEC uncertainties [10_6_X backport] #28866

Conversation

ahinzmann commented Feb 4, 2020 • edited Loading

PR description:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 4, 2020

cmsbuild commented Feb 4, 2020

ahinzmann commented Feb 4, 2020 •

edited

Loading