Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customizer for PUPPI tune v13 #28844

Merged
merged 9 commits into from
Feb 24, 2020
Merged

Add customizer for PUPPI tune v13 #28844

merged 9 commits into from
Feb 24, 2020

Conversation

ahinzmann
Copy link
Contributor

@ahinzmann ahinzmann commented Jan 31, 2020 •
edited
Loading

PR description:

This PR adds a customizer to run PUPPI tune v13 and recompute slimmedJetsPuppi and slimmedMETsPuppi.
The general goal is to switch to PUPPI tune v13 in the master now and for the UL-re-MiniAOD in Summer. Until then we would like to use this customizer to produce JetMET-specific-NanoAODs (custom_jme_cff) with PUPPI tune v13 for validation and calibration.

The PR also adds puppi weighted multiplicity observables to JetMET-specific-NanoAODs.

The most recent presentation of the performance of PUPPI v13 is here:
https://indico.cern.ch/event/876142/#5-update-on-puppi-tuning

PR validation:

It was checked that slimmedJetsPuppi and slimmedMETsPuppi are modified as expected and the corresponding JetMET-specific-NanoAOD entries change accordingly using workflow 10824.0 with this customizer:

cmsDriver.py step6 --conditions auto:phase1_2018_realistic -n 10 --era Run2_2018 --eventcontent NANOEDMAODSIM --filein file:step3_inMINIAODSIM.root -s NANO --datatier NANOAODSIM --geometry DB:Extended --customise_commands "from CommonTools.PileupAlgos.customizePuppiTune_cff import UpdatePuppiTuneV13; UpdatePuppiTuneV13(process); from PhysicsTools.NanoAOD.custom_jme_cff import PrepJMECustomNanoAOD; PrepJMECustomNanoAOD(process)" --fileout file:step6.root > step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

This should be backported to 10_6 for JetMET-specific-NanoAOD production.

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jan 31, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ahinzmann ahinzmann mentioned this pull request Jan 31, 2020
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28844/13593

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

CommonTools/PileupAlgos
PhysicsTools/NanoAOD

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @riga, @jdolen, @gkasieczka, @hatakeyamak, @gpetruc, @clelange this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Feb 1, 2020

@ahinzmann
a process modifier would be a preferred solution to the customize method proposed here.

@slava77
Copy link
Contributor

slava77 commented Feb 1, 2020

also, for the master I would expect that the new tune becomes a default

@slava77
Copy link
Contributor

slava77 commented Feb 1, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4456/console Started: 2020/02/01 01:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2020

+1
Tested at: f249c97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc635/4456/summary.html
CMSSW: CMSSW_11_1_X_2020-01-31-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc635/4456/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697068
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696721
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc635/4768/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694086
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693766
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

please test
(just to check whether the non openable input file is a transient)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4812/console Started: 2020/02/21 14:30

@cmsbuild
Copy link
Contributor

+1
Tested at: 6975b12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc635/4812/summary.html
CMSSW: CMSSW_11_1_X_2020-02-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc635/4812/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694086
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693766
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

+1

  • A customizer is added to run PUPPI tune v13 and recompute slimmedJetsPuppi and slimmedMETsPuppi
  • Once corresponding JEC corrections will be prepared, v13 will be enabled for Run3 and UL re-miniAOD (with a modifier, instead than a customizer)
  • As of now, the PR does not modify any workflow: jenkins tests pass and show no differences

@peruzzim
Copy link
Contributor

+xpog

Are puppiMultiplicity and neutralPuppiMultiplicity normalized to 1? Otherwise careful, 6-bit precision can be little for numbers with a wide range. I assume you checked it as requested.

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

@ahinzmann
could you reply to Marco's comment?

Are puppiMultiplicity and neutralPuppiMultiplicity normalized to 1? Otherwise careful, 6-bit precision can be little for numbers with a wide range. I assume you checked it as requested.

@silviodonato
Copy link
Contributor

+1
@ahinzmann I think you can ignore my comment above, since you are moving in the opposite way float --> int

@cmsbuild cmsbuild merged commit 02b300b into cms-sw:master Feb 24, 2020
@ahinzmann ahinzmann mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peruzzim peruzzim peruzzim left review comments

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
7 participants
@ahinzmann @cmsbuild @slava77 @perrotta @peruzzim @silviodonato @santocch