-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing #27916
[10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing #27916
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_6_X. It involves the following packages: SimTracker/SiPixelDigitizer @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #27912
PR description:
During the CMSSW_11_0_0_pre5 validation it was noticed that the per-FED channel Pixel bad components handling (a.k.a. "stuck-TBM" simulation) introduced in PR #25466, was not working in the premixing case (cf. valDB report ).
This PR fixes the premixing case.
PR validation:
PR validation has been carried out by @tsusa by comparing the pixel valid hit occupancy maps in the baseline CMSSW_11_0_X branch for premixing with and without this PR and compared with classical mixing (tested earlier to work correctly).
I report here one example for BPix Layer 1:
more information is contained in this presentation.
if this PR is a backport please specify the original PR:
backport of #27912
cc:
@tsusa @veszpv @tvami