-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistaken use of pt instead of phi in JetCorrectionUncertainty #28860
Comments
A new Issue was created by @jrueb Jonas Rbenach. @Dr15Jones, @smuzaffar, @silviodonato, @makortel, @davidlange6, @fabiocos can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign alca, reconstruction |
cmsbuild
added
alca-pending
pending-signatures
reconstruction-pending
and removed
pending-assignment
labels
Feb 4, 2020
Adding JetMET experts: @juska @lathomas @ahinzmann |
This was referenced Feb 4, 2020
+1
|
+1
|
This issue is fully signed and ready to be closed. |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed the following line
cmssw/CondFormats/JetMETObjects/src/JetCorrectionUncertainty.cc
Line 124 in 2a0f851
It looks like it's supposed to push back phi (
result.push_back(mJetPhi);
) but instead it actually pushes pt. The pushing of pt is done already in the lines above it. Isn't this a mistake?(Previously reported at cms-nanoAOD#495)
The text was updated successfully, but these errors were encountered: