Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistaken use of pt instead of phi in JetCorrectionUncertainty #28860

Closed
jrueb opened this issue Feb 4, 2020 · 7 comments
Closed

Mistaken use of pt instead of phi in JetCorrectionUncertainty #28860

jrueb opened this issue Feb 4, 2020 · 7 comments

Comments

@jrueb
Copy link
Contributor

jrueb commented Feb 4, 2020

I noticed the following line


It looks like it's supposed to push back phi (result.push_back(mJetPhi);) but instead it actually pushes pt. The pushing of pt is done already in the lines above it. Isn't this a mistake?
(Previously reported at cms-nanoAOD#495)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

A new Issue was created by @jrueb Jonas Rbenach.

@Dr15Jones, @smuzaffar, @silviodonato, @makortel, @davidlange6, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

assign alca, reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

New categories assigned: reconstruction,alca

@slava77,@christopheralanwest,@franzoni,@tlampen,@pohsun,@perrotta,@tocheng you have been requested to review this Pull request/Issue and eventually sign? Thanks

@christopheralanwest
Copy link
Contributor

Adding JetMET experts: @juska @lathomas @ahinzmann

@christopheralanwest
Copy link
Contributor

+1

  • Bug fix PRs are merged.

@perrotta
Copy link
Contributor

+1

  • Fix integrated in the master, in 10_6 and 10_2

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants