Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistaken use of pt instead of phi in JetCorrectionUncertainty #495

Closed
jrueb opened this issue Feb 4, 2020 · 1 comment
Closed

Mistaken use of pt instead of phi in JetCorrectionUncertainty #495

jrueb opened this issue Feb 4, 2020 · 1 comment

Comments

@jrueb
Copy link

jrueb commented Feb 4, 2020

I noticed the following line

cmssw/CondFormats/JetMETObjects/src/JetCorrectionUncertainty.cc

Line 124 in df7f0ee

result.push_back(mJetPt);

It looks like it's supposed to push back phi (result.push_back(mJetPhi);) but instead it actually pushes pt. The pushing of pt is done already in the lines above it. Isn't this a mistake?
@peruzzim
Copy link

peruzzim commented Feb 4, 2020

please report this in cms-sw/cmssw repository for JME to follow up, it's not a nanoAOD-specific issue

@lathomas @ahinzmann FYI

@peruzzim peruzzim closed this as completed Feb 4, 2020
@jrueb jrueb mentioned this issue Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peruzzim @jrueb