PUPPI in RECO #28659

rappoccio · 2019-12-19T21:09:18Z

PR description:

Adding PUPPI weight to PFCandidate.
Adding AK4Puppi and AK8PFPuppi to RECO by default.
Removing AK8CHS.
Removing CMSTopTagger.

This will add two floats (standard and no-lep puppi) to PFCandidate. It becomes the "final" particleFlow module after linking. There are therefore now two "particleFlowTmp" objects (Tmp and Tmp2).

This is the first in an expected long sequence of follow-on PRs that will make use of PUPPI in RECO, simplifying many downstream workflows.

PR validation:

runTheMatrix.py -l limited

The expected PUPPI weights are present in the PFCandidates and are used (for now) only for ak4PFPuppi and ak8PFPuppi.

if this PR is a backport please specify the original PR:

No backports are planned.

cmsbuild · 2019-12-19T21:09:53Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-19T21:16:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28659/13224

This PR adds an extra 160KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/JetMET/src/JetAnalyzer.cc modified in PR(s): DQM: Remove dqmEndRun in DQMEDAnalyzer #28552, DQM: new DQMStore. #28622
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): New Tau ID data format #28417
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): New Tau ID data format #28417
- File RecoJets/Configuration/python/RecoJets_EventContent_cff.py modified in PR(s): Remove track jets from AOD #28657

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28659/13224/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28659/13224/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-12-19T21:37:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-19T21:44:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28659/13225

This PR adds an extra 260KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/JetMET/src/JetAnalyzer.cc modified in PR(s): DQM: Remove dqmEndRun in DQMEDAnalyzer #28552, DQM: new DQMStore. #28622
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): New Tau ID data format #28417
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): New Tau ID data format #28417
- File RecoJets/Configuration/python/RecoJets_EventContent_cff.py modified in PR(s): Remove track jets from AOD #28657

cmsbuild · 2019-12-19T21:44:43Z

A new Pull Request was created by @rappoccio for master.

It involves the following packages:

CommonTools/PileupAlgos
DQM/Physics
DQMOffline/JetMET
DQMOffline/Trigger
DataFormats/ParticleFlowCandidate
DataFormats/PatCandidates
HLTriggerOffline/B2G
PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
RecoBTag/Combined
RecoBTag/FeatureTools
RecoBTag/ImpactParameter
RecoBTag/ONNXRuntime
RecoHI/Configuration
RecoJets/Configuration
RecoJets/JetProducers
RecoParticleFlow/Configuration
RecoParticleFlow/PFProducer

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fgolf, @fioriNTU, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @yslai, @hatakeyamak, @echapon, @jazzitup, @peruzzim, @seemasharmafnal, @mmarionncern, @calderona, @ahinzmann, @smoortga, @acaudron, @jhgoh, @lgray, @missirol, @HuguesBrun, @cericeci, @hqucms, @ferencek, @trocino, @yetkinyilmaz, @cbernet, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mtosi, @dgulhan, @clelange, @HeinerTholen, @jdolen, @mandrenguyen, @riga, @battibass, @MiheeJo, @Fedespring, @JyothsnaKomaragiri, @mverzett, @yenjie, @folguera, @kurtejung, @gpetruc, @mariadalfonso, @rociovilar, @pvmulder, @andrzejnovak, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2019-12-19T21:45:19Z

@cmsbuild please test

cmsbuild · 2019-12-19T21:45:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4068/console Started: 2019/12/19 22:47

cmsbuild · 2019-12-20T00:33:58Z

-1

Tested at: b014641

CMSSW: CMSSW_11_1_X_2019-12-19-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acfbc8/4068/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

cmsbuild · 2019-12-20T00:34:00Z

Comparison job queued.

cmsbuild · 2019-12-20T02:27:56Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acfbc8/4068/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5657 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2811802
DQMHistoTests: Total failures: 15587
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2795874
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -90.125 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): -3.633 KiB Physics/B2G
DQMHistoSizes: changed ( 1000.0,... ): 0.027 KiB Physics/Exotica
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2020-01-24T21:05:17Z

-code-checks

@rappoccio
please apply the patch, in case you missed the message.
Thanks.

silviodonato · 2020-01-30T09:50:31Z

This is a kind reminder about this PR @rappoccio

cmsbuild · 2020-01-30T15:39:00Z

The code-checks are being triggered in jenkins.

rappoccio · 2020-01-30T15:40:19Z

Sorry for the delay, it's the first week of classes as I mentioned.

Please hold off on checks, cmsdev20 is full and my checks have not completed. I have to clean out the area and restart because something broke due to the disk being full.

cmsbuild · 2020-01-30T15:44:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28659/13560

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): New Tau ID data format #28417
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): New Tau ID data format #28417

cmsbuild · 2020-01-30T15:44:49Z

Pull request #28659 was updated. @perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fgolf, @fioriNTU, @slava77, @santocch, @peruzzim can you please check and sign again.

slava77 · 2020-01-31T17:15:11Z

Please hold off on checks, cmsdev20 is full and my checks have not completed. I have to clean out the area and restart because something broke due to the disk being full.

@rappoccio
please clarify if the PR checks are now done on your side.
Thank you.

slava77 · 2020-02-01T11:19:30Z

@cmsbuild please test

cmsbuild · 2020-02-01T11:19:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4458/console Started: 2020/02/01 13:41

cmsbuild · 2020-02-01T14:42:06Z

+1
Tested at: fbe06c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acfbc8/4458/summary.html
CMSSW: CMSSW_11_1_X_2020-02-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-02-01T14:42:08Z

Comparison job queued.

cmsbuild · 2020-02-01T16:14:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acfbc8/4458/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 3064 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2695093
DQMHistoTests: Total failures: 5907
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2688840
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -90.125 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): -3.633 KiB Physics/B2G
DQMHistoSizes: changed ( 1000.0,... ): 0.027 KiB Physics/Exotica
Checked 147 log files, 16 edm output root files, 34 DQM output files

rappoccio · 2020-02-03T16:55:58Z

Sorry, missed this earlier (last week was completely hectic). My tests passed. I don't know if there are other cases that need to be addressed. There is still an open question about what to do with the EGM and MUO value maps. @bendavid and @hatakeyamak have weighed in, perhaps we can discuss on Wednesday at the JME meeting?

silviodonato · 2020-02-10T08:43:31Z

@rappoccio Do you news about this PR after the JME meeting?

rappoccio · 2020-02-10T08:59:20Z

Yes apparently we're killing this idea. The next circle of hell will come at a later time.

cmsbuild added this to the CMSSW_11_1_X milestone Dec 19, 2019

cmsbuild added analysis-pending code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Dec 19, 2019

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Dec 19, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 19, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2019

cmsbuild added tests-rejected and removed tests-started labels Dec 20, 2019

cmsbuild added the code-checks-rejected label Jan 24, 2020

Addressing most remaining issues from code review

fbe06c1

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2020

cmsbuild added tests-started and removed tests-pending labels Feb 1, 2020

cmsbuild added tests-approved and removed tests-started labels Feb 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Feb 1, 2020

cmsbuild mentioned this pull request Feb 4, 2020

Fix phi-dependent JEC uncertainties [10_6_X backport] #28866

Closed

rappoccio closed this Feb 10, 2020

ahinzmann mentioned this pull request Feb 12, 2020

PUPPI jets in RECO #28936

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PUPPI in RECO #28659

PUPPI in RECO #28659

rappoccio commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

slava77 commented Dec 19, 2019

cmsbuild commented Dec 19, 2019 •

edited

Loading

cmsbuild commented Dec 20, 2019

cmsbuild commented Dec 20, 2019

cmsbuild commented Dec 20, 2019

slava77 commented Jan 24, 2020

silviodonato commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

rappoccio commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

slava77 commented Jan 31, 2020

slava77 commented Feb 1, 2020

cmsbuild commented Feb 1, 2020 •

edited

Loading

cmsbuild commented Feb 1, 2020

cmsbuild commented Feb 1, 2020

cmsbuild commented Feb 1, 2020

rappoccio commented Feb 3, 2020

silviodonato commented Feb 10, 2020

rappoccio commented Feb 10, 2020

PUPPI in RECO #28659

PUPPI in RECO #28659

Conversation

rappoccio commented Dec 19, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

cmsbuild commented Dec 19, 2019

slava77 commented Dec 19, 2019

cmsbuild commented Dec 19, 2019 • edited Loading

cmsbuild commented Dec 20, 2019

cmsbuild commented Dec 20, 2019

cmsbuild commented Dec 20, 2019

slava77 commented Jan 24, 2020

silviodonato commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

rappoccio commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

cmsbuild commented Jan 30, 2020

slava77 commented Jan 31, 2020

slava77 commented Feb 1, 2020

cmsbuild commented Feb 1, 2020 • edited Loading

cmsbuild commented Feb 1, 2020

cmsbuild commented Feb 1, 2020

cmsbuild commented Feb 1, 2020

rappoccio commented Feb 3, 2020

silviodonato commented Feb 10, 2020

rappoccio commented Feb 10, 2020

cmsbuild commented Dec 19, 2019 •

edited

Loading

cmsbuild commented Feb 1, 2020 •

edited

Loading