-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APE tool: Trend plots, some minor fixes: Backport of #27656 #27936
Conversation
A new Pull Request was created by @mteroerd (Marius Teroerde) for CMSSW_10_6_X. It involves the following packages: Alignment/APEEstimation @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@mteroerd which is the purpose of this backport? For future reference? The usage of the package itself was done in master I expect |
@fabiocos I was told that the Alignment+Validation of UL2016 ReReco is done on 10_6_0, which is why it would be useful to have the updated code for that release. |
+1 |
Backport of #27656
PR description:
This PR is the summary of some changes that were made to the APE estimation tool during the UL2017 and UL2018 campaigns.
It includes:
PR Validation:
The validation happened while using the tool. Since no changes were made that could affect the APE results themselves, everything was transparent.
if this PR is a backport please specify the original PR:
Backport of #27656