Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Custom JME NanoAODs: Fix JetID, update modifiers and able to run on data #28854

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Updates for Custom JME NanoAODs: Fix JetID, update modifiers and able to run on data #28854

merged 3 commits into from
Feb 28, 2020

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR updates the Custom JME NanoAOD with the following items:

  1. Update era modifiers with run2_jme_2016 and run2_jme_2017.
  2. Setup the proper JetID versions according to PUPPI vs CHS for each year.
  3. Made necessary changes such that it can now run on data. Added wrapper functions
    to be used when specifying customise_commands when running on MC or data.

This PR needs to be backported to 10_6_X, once merged, for the ultra legacy campaigns.

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Feb 2, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

The code-checks are being triggered in jenkins.

@nurfikri89 nurfikri89 mentioned this pull request Feb 2, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28854/13604

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @HeinerTholen, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @acaudron, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @andrzejnovak, @pvmulder this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Feb 2, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4463/console Started: 2020/02/02 23:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

+1
Tested at: 19aa07e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c3fa7/4463/summary.html
CMSSW: CMSSW_11_1_X_2020-02-02-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c3fa7/4463/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697068
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696721
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@srimanob
Copy link
Contributor

srimanob commented Feb 3, 2020 •
edited
Loading

PR for new relvals workflows will come. This PR is needed to test with them.

@srimanob srimanob mentioned this pull request Feb 3, 2020
Merged
@cmsbuild cmsbuild mentioned this pull request Feb 3, 2020
Merged
@srimanob
Copy link
Contributor

srimanob commented Feb 3, 2020

@perrotta
You should test with #28857 (workflow 25202.01)
More to come for data, 17, 18 in the same PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #28857
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: b6b8b32
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb593a/4918/summary.html
CMSSW: CMSSW_11_1_X_2020-02-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb593a/4918/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bb593a/25202.01_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2679706
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2679386
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

@srimanob are the results of wf 25202.01 ok?

@silviodonato
Copy link
Contributor

reminder to myself to integrate #28857 after/together with this PR

@srimanob
Copy link
Contributor

@srimanob are the results of wf 25202.01 ok?

@nurfikri89 Could you please confirm the content of NanoAOD with the last test?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb593a/4918/runTheMatrix-results/25202.01_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME/

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@nurfikri89
Copy link
Contributor Author

@srimanob I can confirm that everything is fine.

@srimanob
Copy link
Contributor

Thanks @nurfikri89
I think we are good to go @silviodonato Thanks.

FYI: @ahinzmann

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f8b7175 into cms-sw:master Feb 28, 2020
@nurfikri89 nurfikri89 mentioned this pull request Feb 29, 2020
Merged
cmsbuild added a commit that referenced this pull request Mar 3, 2020
@cmsbuild
Merge pull request #29064 from nurfikri89/portFrom110XTo106X_nanojme_…
d26fff8 
…fixesAndupdateforData

Backport of #28854 (Updates for Custom JME NanoAODs: Fix JetID, update modifiers and able to run on data)
@nurfikri89 nurfikri89 deleted the from1110pre2_nanojme_fixesAndupdateforData branch January 25, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silviodonato silviodonato silviodonato left review comments

@peruzzim peruzzim peruzzim left review comments

@ahinzmann ahinzmann ahinzmann left review comments

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved requires-external tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
9 participants
@nurfikri89 @cmsbuild @perrotta @srimanob @silviodonato @peruzzim @camclean @santocch @ahinzmann