Bugfix for PR28574

[tvami]

PR description:

Fixing the issue reported in #28574 (comment)

PR validation:

Tested with runTheMatrix.py -l 7.22,7.21,7.4,7.3 -t 4 -j 8

if this PR is a backport please specify the original PR:

This is a fix for a backport, PR #28574.

@silviodonato @mmusich @tsusa

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @pgunnell, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4202/console Started: 2020/01/11 23:53

[cmsbuild]

+1
Tested at: 3b0c611
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1f87/4202/summary.html
CMSSW: CMSSW_10_6_X_2020-01-11-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1f87/4202/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211987
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[chayanit]

+1

[silviodonato]

please test workflow 136.726

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 136.726
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4203/console Started: 2020/01/12 08:28

[cmsbuild]

+1
Tested at: 3b0c611
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1f87/4203/summary.html
CMSSW: CMSSW_10_6_X_2020-01-11-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[silviodonato]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1f87/4203/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-6c1f87/136.726_RunMuonEG2016B+RunMuonEG2016B+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211989
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[boudoul]

Hello @tvami , I start to see a dataset called /StreamExpressCosmics/Commissioning2019-PromptCalibProdSiPixel-Express-v1/ALCAPROMPT in the current MWGR , this is what you introduced here , correct ? I guess this is already a good sign - Of course there is at this point no pixel in the run, but sounds like this config is ok . You may want to x-check.

Btw @tvami and @silviodonato , it is appreciated (and useful!) to have better PR titles than this one. Titles are heavily used to understand quickly what is in a given PR (at least the context : subdetector , etc..) , so just giving a number of a PR in the title is not explicit enough to understand the purpose of this bugfix . Just a suggestion for next time - Thank you.

[mmusich]

I start to see a dataset called /StreamExpressCosmics/Commissioning2019-PromptCalibProdSiPixel-Express-v1/ALCAPROMPT in the current MWGR , this is what you introduced here , correct ?

Hi @boudoul, no that's not correct. The sample you point out is the one created by the pixel bad components PCL, and being a PCL workflow runs at Express (in this case irrespective of the fact that pixel are in the run or not).
The new ALCARECO producers introduced here were not asked to be added to the Express configuration (that being pointless, after all there are no pixels in global run) hence we don't expect any new sample to appear in this MWGR...

[boudoul]

oh ok, thanks I was simply confused , sorry for the noise