Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing SiPixelCalSingleMuon ALCARECO #28574

Merged
merged 15 commits into from
Jan 10, 2020
Merged

Introducing SiPixelCalSingleMuon ALCARECO #28574

merged 15 commits into from
Jan 10, 2020

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Dec 6, 2019 •
edited
Loading

@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Dec 6, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2019 •
edited
Loading

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X.

It involves the following packages:

Calibration/TkAlCaRecoProducers
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@cmsbuild, @chayanit, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

@tvami Is a backport to 10_6_X really needed? Your presentation at the 2 Dec AlCaDB meeting did not mention that this new ALCARECO was desired for the UL.

@tvami
Copy link
Contributor Author

tvami commented Dec 11, 2019

Yes, please see JIRA ticket:
https://its.cern.ch/jira/projects/PDMVRERECO/issues/PDMVRERECO-26

tvami added a commit to tvami/cmssw that referenced this pull request Dec 12, 2019
@tvami
Merge pull request #2 from mmusich/addSiPixelCalCosmics_onTop_ofTamasPR
4e4cefe 
Add SiPixelCalCosmics on top of PR cms-sw#28574
@tvami tvami force-pushed the ALCARECOSiPixelCalSingleMuon_Backport branch from b6ce1ca to 7b48042 Compare December 17, 2019 15:11
@cmsbuild
Copy link
Contributor

Pull request #28574 was updated. @cmsbuild, @chayanit, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2020

Pull request #28574 was updated. @pgunnell, @chayanit, @zhenhu, @christopheralanwest, @tocheng, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please check and sign again.

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4189/console Started: 2020/01/10 10:04

@silviodonato
Copy link
Contributor

Have you run a validation of this PR? Could you point here some results?

@mmusich
Copy link
Contributor

mmusich commented Jan 10, 2020

@silviodonato what kind of results?
The necessary output files are produced and are filled with the appropriate collections as one can check directly by looking e.g. to the file produced in PR integration tests here or here.
For the cosmics case I have also reprocessed an entire run (available here ).

@cmsbuild
Copy link
Contributor

+1
Tested at: a3a46d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-befb3d/4189/summary.html
CMSSW: CMSSW_10_6_X_2020-01-09-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-befb3d/4189/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3211987
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.016 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 43bfddc into cms-sw:CMSSW_10_6_X Jan 10, 2020
@silviodonato
Copy link
Contributor

@tvami @mmusich This PR is crashing CMSSW_10_6 2020-01-10-2300
see https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_10_6/2020-01-10-2300?selectedArchs=slc7_amd64_gcc700&selectedFlavors=X&selectedStatus=failed

The following alcas could not be found ['ALCA,SiPixelCalSingleMuon'] available ['EcalESAlign', 'LumiPixels', 'PromptCalibProdSiStripGainsAAG', 'SiPixelCalZeroBias', 'PromptCalibProdEcalPedestals', 'TkAlMuonIsolatedPA', 'TkAlUpsilonMuMu', 'EcalCalEtaCalib', 'HcalCalIsolatedBunchSelector', 'HcalCalHBHEMuonFilter', 'MuAlGlobalCosmics', 'MuAlZMuMu', 'TkAlBeamHalo', 'HcalCalIsoTrk', 'PromptCalibProdLumiPCC', 'MuAlGlobalCosmicsInCollisions', 'DtCalibCosmics', 'TkAlCosmicsInCollisions', 'RawPCCProducer', 'MuAlOverlaps', 'TkAlMinBias', 'EcalTestPulsesRaw', 'MuAlBeamHaloOverlaps', 'Hotline', 'TkAlCosmics0T', 'EcalUncalWElectron', 'PromptCalibProdSiPixel', 'PromptCalibProd', 'SiPixelCalSingleMuon', 'SiStripCalMinBiasAAG', 'SiStripCalZeroBias', 'TkAlMuonIsolated', 'PromptCalibProdBeamSpotHP', 'PromptCalibProdSiStrip', 'TkAlCosmics0THLT', 'PromptCalibProdSiPixelAli', 'TkAlUpsilonMuMuPA', 'EcalCalWElectron', 'TkAlLAS', 'TkAlZMuMu', 'AlCaPCCZeroBiasFromRECO', 'EcalTrg', 'TkAlJpsiMuMu', 'RpcCalHLT', 'SiStripCalCosmics', 'AlCaPCCRandom', 'SiStripPCLHistos', 'HcalCalPedestal', 'SiStripCalSmallBiasScan', 'HcalCalIterativePhiSym', 'TkAlCosmics', 'AlCaPCCZeroBias', 'TkAlZMuMuPA', 'DtCalib', 'SiPixelCalCosmics', 'HcalCalDijets', 'PromptCalibProdSiStripGains', 'AlCaPCCRandomFromRECO', 'PromptCalibProdBeamSpotHPLowPU', 'EcalCalPi0Calib', 'HcalCalLowPUHBHEMuonFilter', 'LumiPixelsMinBias', 'HcalCalGammaJet', 'EcalCalZElectron', 'HcalCalIsolatedBunchFilter', 'TkAlCosmicsHLT', 'HcalCalIsoTrkFilter', 'HcalCalNoise', 'HcalCalHOCosmics', 'MuAlCalIsolatedMu', 'SiStripCalMinBias', 'MuAlBeamHalo', 'EcalUncalZElectron', 'HcalCalHO', 'HcalCalMinBias', 'HcalCalHEMuonFilter'] Traceback (most recent call last): File "/cvmfs/cms-ib.cern.ch/nweek-02610/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-01-10-2300/bin/slc7_amd64_gcc700/cmsDriver.py", line 56, in <module> run() File "/cvmfs/cms-ib.cern.ch/nweek-02610/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-01-10-2300/bin/slc7_amd64_gcc700/cmsDriver.py", line 28, in run configBuilder.prepare() File "/cvmfs/cms-ib.cern.ch/nweek-02610/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-01-10-2300/python/Configuration/Applications/ConfigBuilder.py", line 2121, in prepare self.addStandardSequences() File "/cvmfs/cms-ib.cern.ch/nweek-02610/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-01-10-2300/python/Configuration/Applications/ConfigBuilder.py", line 761, in addStandardSequences getattr(self,"prepare_"+stepName)(sequence = ','.join([stepSpec[1],'+'.join(stepSpec[0])])) File "/cvmfs/cms-ib.cern.ch/nweek-02610/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-01-10-2300/python/Configuration/Applications/ConfigBuilder.py", line 1301, in prepare_ALCA raise Exception("The following alcas could not be found "+str(alcaList)) Exception: The following alcas could not be found ['ALCA,SiPixelCalSingleMuon']

mmusich
mmusich reviewed Jan 11, 2020
View reviewed changes
Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviodonato, I identified the problem, but I won't be able to propose a PR until next Wednesday. I hope @tvami can quickly apply the trivial fix.

Configuration/PyReleaseValidation/python/relval_steps.py
steps['RECODR2_2016reHLT_skimJetHT']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:JetHTJetPlusHOFilter,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])
steps['RECODR2_2016reHLT_skimMET']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:HighMET+EXOMONOPOLE,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])
steps['RECODR2_2016reHLT_skimSinglePh']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:SinglePhotonJetPlusHOFilter+EXOMONOPOLE,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])
steps['RECODR2_2016reHLT_skimMuOnia']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:BPHSkim,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])

steps['RECODR2_2017reHLT_skimSingleMu']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@L1TMuon'},steps['RECODR2_2017reHLT']])
steps['RECODR2_2017reHLT_skimSingleMu']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@L1TMuon'},steps['RECODR2_2017reHLT']])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvami, you added by mistake a spurious ALCA here that is already there. This crashes the data workflows. Can you fix it?

mmusich
mmusich reviewed Jan 11, 2020
View reviewed changes
Configuration/PyReleaseValidation/python/relval_steps.py
@@ -2116,15 +2116,15 @@ def gen2018HiMix(fragment,howMuch):
steps['RECODR2_2017reHLTSiPixelCalZeroBias']=merge([{'--hltProcess':'reHLT','--conditions':'auto:run2_data_relval','-s':'RAW2DIGI,L1Reco,RECO,EI,PAT,ALCA:SiPixelCalZeroBias,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2017']])
steps['RECODR2_2018reHLTAlCaTkCosmics']=merge([{'--hltProcess':'reHLT','--conditions':'auto:run2_data_relval','-s':'RAW2DIGI,L1Reco,RECO,SKIM:EXONoBPTXSkim,EI,PAT,ALCA:TkAlCosmicsInCollisions,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2018']])

steps['RECODR2_2016reHLT_skimSingleMu']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:ZMu+MuTau,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@L1TMuon'},steps['RECODR2_2016reHLT']])
steps['RECODR2_2016reHLT_skimSingleMu']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:ZMu+MuTau,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@L1TMuon'},steps['RECODR2_2016reHLT']])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvami here too.

Configuration/PyReleaseValidation/python/relval_steps.py
steps['RECODR2_2016reHLT_skimDoubleEG']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:ZElectron,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])
steps['RECODR2_2016reHLT_skimMuonEG']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:TopMuEG,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])
steps['RECODR2_2016reHLT_skimMuonEG']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:TopMuEG,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2016reHLT']])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvami here too.

Configuration/PyReleaseValidation/python/relval_steps.py
@@ -2135,7 +2135,7 @@ def gen2018HiMix(fragment,howMuch):
steps['RECODR2_2017reHLT_skimCharmonium']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGJPsiSkim+BPHSkim,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM'},steps['RECODR2_2017reHLT']])

steps['RECODR2_2018reHLT']=merge([{'--hltProcess':'reHLT','--conditions':'auto:run2_data_relval'},steps['RECODR2_2018']])
steps['RECODR2_2018reHLT_skimSingleMu']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+SiStripCalSmallBiasScan+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@L1TMuon'},steps['RECODR2_2018reHLT']])
steps['RECODR2_2018reHLT_skimSingleMu']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+SiStripCalSmallBiasScan+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@L1TMuon'},steps['RECODR2_2018reHLT']])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvami here too.

Configuration/PyReleaseValidation/python/relval_steps.py
@@ -2180,7 +2180,7 @@ def gen2018HiMix(fragment,howMuch):
steps['RECODR2_2017reHLT_skimSinglePh_Prompt']=merge([{'--conditions':'auto:run2_data'},steps['RECODR2_2017reHLT_skimSinglePh']])
steps['RECODR2_2017reHLT_skimMuOnia_Prompt']=merge([{'--conditions':'auto:run2_data'},steps['RECODR2_2017reHLT_skimMuOnia']])
steps['RECODR2_2017reHLT_skimCharmonium_Prompt']=merge([{'--conditions':'auto:run2_data'},steps['RECODR2_2017reHLT_skimCharmonium']])
steps['RECODR2_2017reHLT_skimSingleMu_Prompt_Lumi']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@lumi+@L1TMuon'},steps['RECODR2_2017reHLT_skimSingleMu_Prompt']])
steps['RECODR2_2017reHLT_skimSingleMu_Prompt_Lumi']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@lumi+@L1TMuon'},steps['RECODR2_2017reHLT_skimSingleMu_Prompt']])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

Configuration/PyReleaseValidation/python/relval_steps.py
steps['RECODR2_2018reHLT_skimSingleMu_Prompt_Lumi']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@lumi+@L1TMuon'},steps['RECODR2_2018reHLT_skimSingleMu_Prompt']])
steps['RECODR2_2018reHLT_skimSingleMu_Offline_Lumi']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@lumi+@L1TMuon'},steps['RECODR2_2018reHLT_skimSingleMu_Offline']])
steps['RECODR2_2018reHLT_skimSingleMu_Prompt_Lumi']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@lumi+@L1TMuon'},steps['RECODR2_2018reHLT_skimSingleMu_Prompt']])
steps['RECODR2_2018reHLT_skimSingleMu_Offline_Lumi']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,SKIM:MuonPOGSkim+ZMu+MuTau,EI,PAT,ALCA:ALCA:SiPixelCalSingleMuon+SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@lumi+@L1TMuon'},steps['RECODR2_2018reHLT_skimSingleMu_Offline']])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

@tvami tvami mentioned this pull request Jan 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusich mmusich mmusich left review comments

Assignees
No one assigned
Labels
alca-pending backport-ok comparison-available operations-pending orp-approved pdmv-pending pending-signatures tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.
7 participants
@tvami @cmsbuild @christopheralanwest @mmusich @chayanit @tocheng @silviodonato