Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override hardcoded /var/lib/kubelet/kubeconfig location in call to RunCommandOnHost #43

Closed
SanyaKochhar opened this issue Apr 13, 2021 · 6 comments
Closed

Override hardcoded /var/lib/kubelet/kubeconfig location in call to RunCommandOnHost #43

SanyaKochhar opened this issue Apr 13, 2021 · 6 comments
Labels
enhancement 🏎 New feature or request feature-request ⛏☕️ Need investigation 🕵️ triage 💭 Need triage to replicate or identify right fix

Comments

@SanyaKochhar
Copy link
Contributor

SanyaKochhar commented Apr 13, 2021 •
edited
Loading

Context: evaluating using AKS-Periscope for Open Service Mesh on non-aks distros

When deploying aks-periscope on a kind cluster as described in the appendix.md, the following error is seen:
Collector: networkoutbound, export data failed: Can't open kubeconfig file: Fail to run command on host: exit status 1

This seems to be coming from

aks-periscope/pkg/utils/helper.go

Line 56 in da7f592

return "", fmt.Errorf("Fail to run command on host: %+v", err)

when called by

aks-periscope/pkg/utils/helper.go

Line 26 in da7f592

output, err := RunCommandOnHost("cat", "/var/lib/kubelet/kubeconfig")

On exec'ing into the container (and replicating on an AKS cluster), it seems that the difference is that kind clusters do not have this kubeconfig at this /var/lib/kubelet/kubeconfig location.

It would be useful if a flag could be added to be able to pass in this file path or pass in the api server fqdn to make it possible to use on non-aks distros
@Tatsinnit
Copy link
Member

Hiya and Thank you for logging this, I will add appropriate label. Yes indeed, we noticed and planning to do some work items inline for this repo. We will soon add this as well in a road map or engage back. thank you.

@Tatsinnit Tatsinnit added enhancement 🏎 New feature or request triage 💭 Need triage to replicate or identify right fix labels Apr 14, 2021
sophsoph321 pushed a commit to sophsoph321/aks-periscope that referenced this issue May 7, 2021
# This is a combination of 127 commits.
2854366 
# This is the 1st commit message:

Revert "introduce arcmode"

This reverts commit 5f4fed4.

# This is the commit message #2:

remove secrets

# This is the commit message Azure#3:

add print statement

# This is the commit message Azure#4:

update print statement

# This is the commit message Azure#5:

committed

# This is the commit message Azure#6:

committed

# This is the commit message Azure#7:

committed

# This is the commit message Azure#8:

committed

# This is the commit message Azure#9:

remove print statements

# This is the commit message Azure#10:

add helm collector

# This is the commit message Azure#11:

change helm command

# This is the commit message Azure#12:

add helm 3 installation

# This is the commit message Azure#13:

add curl command installation

# This is the commit message Azure#14:

change helm command

# This is the commit message Azure#15:

remove helm history

# This is the commit message Azure#16:

debug helm history

# This is the commit message Azure#17:

add repo command

# This is the commit message Azure#18:

change stable repo name

# This is the commit message Azure#19:

add write to file

# This is the commit message Azure#20:

add kured

# This is the commit message Azure#21:

change

# This is the commit message Azure#22:

changes

# This is the commit message Azure#23:

add default namespace

# This is the commit message Azure#24:

change

# This is the commit message Azure#25:

add integration test

# This is the commit message Azure#26:

changes

# This is the commit message Azure#27:

add helm test

# This is the commit message Azure#28:

change print statement to error

# This is the commit message Azure#29:

change

# This is the commit message Azure#30:

more changes

# This is the commit message Azure#31:

add go installation

# This is the commit message Azure#32:

fix unit test

# This is the commit message Azure#33:

iptables to Helm

# This is the commit message Azure#34:

add custom resource collector

# This is the commit message Azure#35:

add new exporter, diagnoser, collector

# This is the commit message Azure#36:

comment unused variables

# This is the commit message Azure#37:

debug exporter

# This is the commit message Azure#38:

filenames

# This is the commit message Azure#39:

test zip function

# This is the commit message Azure#40:

list files

# This is the commit message Azure#41:

fmt to log

# This is the commit message Azure#42:

delete lines

# This is the commit message Azure#43:

changed

# This is the commit message Azure#44:

get current directory

# This is the commit message Azure#45:

remove some print statements

# This is the commit message Azure#46:

test zip

# This is the commit message Azure#47:

changes

# This is the commit message Azure#48:

add windir check

# This is the commit message Azure#49:

minor fix

# This is the commit message Azure#50:

get hostname

# This is the commit message Azure#51:

add expose in dockerfile

# This is the commit message Azure#52:

add exec collector

# This is the commit message Azure#53:

mitigate exit code 126

# This is the commit message Azure#54:

change curl url from example.com to dp endpoint

# This is the commit message Azure#55:

changes

# This is the commit message Azure#56:

uncomment exec

# This is the commit message Azure#57:

add new diagnoser

# This is the commit message Azure#58:

debugging

# This is the commit message Azure#59:

debug

# This is the commit message Azure#60:

debugging

# This is the commit message Azure#61:

remove print statements

# This is the commit message Azure#62:

remove print

# This is the commit message Azure#63:

add back crd print statement

# This is the commit message Azure#64:

change

# This is the commit message Azure#65:

change

# This is the commit message Azure#66:

update dataPoint name

# This is the commit message Azure#67:

modify forloop

# This is the commit message Azure#68:

add filename to datapoint

# This is the commit message Azure#69:

add back log prints

# This is the commit message Azure#70:

test

# This is the commit message Azure#71:

add fields to diagnostic signal

# This is the commit message Azure#72:

add config content to diagnoser

# This is the commit message Azure#73:

change format from yaml to json

# This is the commit message Azure#74:

add parameters for kubeobject config map

# This is the commit message Azure#75:

Revert "introduce arcmode"

This reverts commit 5f4fed4.

# This is the commit message Azure#76:

fix helm collector style

# This is the commit message Azure#77:

revert changes that test arc customizations

# This is the commit message Azure#78:

fix merge conflicts

# This is the commit message Azure#79:

fix merge conflicts

# This is the commit message Azure#80:

Revert "Add v0.3 acr image for Private cluster fix. (Azure#22)"

This reverts commit 49dd302.

# This is the commit message Azure#81:

fix merge conflicts

# This is the commit message Azure#82:

fix merge conflicts

# This is the commit message Azure#83:

add print statement

# This is the commit message Azure#84:

update print statement

# This is the commit message Azure#85:

committed

# This is the commit message Azure#86:

committed

# This is the commit message Azure#87:

committed

# This is the commit message Azure#88:

committed

# This is the commit message Azure#89:

remove print statements

# This is the commit message Azure#90:

fix merge conflicts

# This is the commit message Azure#91:

fix merge conflicts

# This is the commit message Azure#92:

fix merge conflicts

# This is the commit message Azure#93:

add repo command

# This is the commit message Azure#94:

change stable repo name

# This is the commit message Azure#95:

add write to file

# This is the commit message Azure#96:

add kured

# This is the commit message Azure#97:

change

# This is the commit message Azure#98:

changes

# This is the commit message Azure#99:

add default namespace

# This is the commit message Azure#100:

change

# This is the commit message Azure#101:

add integration test

# This is the commit message Azure#102:

changes

# This is the commit message Azure#103:

add helm test

# This is the commit message Azure#104:

change print statement to error

# This is the commit message Azure#105:

change

# This is the commit message Azure#106:

more changes

# This is the commit message Azure#107:

add go installation

# This is the commit message Azure#108:

fix unit test

# This is the commit message Azure#109:

add custom resource collector

# This is the commit message Azure#110:

fix merge conflicts

# This is the commit message Azure#111:

comment unused variables

# This is the commit message Azure#112:

debug exporter

# This is the commit message Azure#113:

filenames

# This is the commit message Azure#114:

test zip function

# This is the commit message Azure#115:

list files

# This is the commit message Azure#116:

fmt to log

# This is the commit message Azure#117:

delete lines

# This is the commit message Azure#118:

changed

# This is the commit message Azure#119:

get current directory

# This is the commit message Azure#120:

remove some print statements

# This is the commit message Azure#121:

test zip

# This is the commit message Azure#122:

changes

# This is the commit message Azure#123:

add windir check

# This is the commit message Azure#124:

minor fix

# This is the commit message Azure#125:

get hostname

# This is the commit message Azure#126:

add expose in dockerfile

# This is the commit message Azure#127:

add exec collector
@draychev
Copy link

@Tatsinnit Do you have an estimate on when or if this will be completed? It would be great to patch this and open up Periscope for broader use cases.

@Tatsinnit
Copy link
Member

Tatsinnit commented May 13, 2021 •
edited
Loading

Thanks @draychev, cool, yeah this is not currently in the v1 road map, as currently this tool focused on AKS only scenario, I think in one of the internal email as well we discussed\agreed.

There is key-design decision to make here from tool point of view: Moving forward no-doubt it will be good but I was willing to better stock take and decide that if we want to support broader Non-AKS scenario by-design.

For clarity as this repo was missing Goal v non-Goal I am adding that doc today and there was one internally shared as well, which focused initial founders design for this repo.

💡 Update Founder has kindly approved and the goal v non-goal reside here: https://github.com/Azure/aks-periscope/blob/master/docs/goalsvsnongoals.md

@Tatsinnit
Copy link
Member

Tatsinnit commented Aug 8, 2021 •
edited
Loading

Hiya @draychev and @SanyaKochhar - A loop back for possible solution for this (will update once it is done), we have found much better solution for this and reason this kubeconfig was hardcoded was because it was using APIServer name was used as containerName so if we can easily supply that from the consuming tools which can access that information much easier.

further details reside here: (Please feel free to add thoughts etc.)

Thanks heaps 🙏

@SanyaKochhar
Copy link
Contributor Author

@Tatsinnit thanks for looping back on this. Took a look at the issues and the open PR and it seems like this is headed in the right direction

@Tatsinnit
Copy link
Member

🙏 Thanks all for discussion, this is fixed as part of this recent release. https://github.com/Azure/aks-periscope/releases/tag/v0.5 , closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🏎 New feature or request feature-request ⛏☕️ Need investigation 🕵️ triage 💭 Need triage to replicate or identify right fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tatsinnit @SanyaKochhar @draychev