Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SMI collector in Periscope #67

Closed
johnsonshi opened this issue Jun 13, 2021 · 1 comment · Fixed by #71
Closed

feat: add SMI collector in Periscope #67

johnsonshi opened this issue Jun 13, 2021 · 1 comment · Fixed by #71
Assignees
@johnsonshi @SanyaKochhar
Labels
enhancement 🏎 New feature or request

Comments

@johnsonshi
Copy link
Contributor

Feature request
Enhance periscope so that it collects SMI information from a cluster.

Additional context
This is blocked pending #48 being merged.
Once #48 is merged, I will open a PR that adds SMI collection capability to Periscope. This work has already been implemented in SanyaKochhar#30
@johnsonshi johnsonshi changed the title Add SMI collector support in Periscope feat: add SMI collector in Periscope Jun 13, 2021
@Tatsinnit
Copy link
Member

Tatsinnit commented Jun 14, 2021 •
edited
Loading

💡🙏 thank you for creating this, FYI regarding #48 : it’s been few days it has merge conflict along with final changes we recommended, if we can fix that we can prioritise the merge. Rest looks good. Thank you.

@johnsonshi johnsonshi mentioned this issue Jun 21, 2021
Closed
johnsonshi added a commit to SanyaKochhar/aks-periscope that referenced this issue Jun 22, 2021
@johnsonshi
feat: add SMI log collector
e2a50bd 
Add log collector for Service Mesh Interface
logs, CustomResourceDefinitions, and custom
resources.

Related to PR Azure#48.

Resolves issue Azure#67.

Signed-off-by: Johnson Shi <[email protected]>
@johnsonshi johnsonshi mentioned this issue Jun 22, 2021
Merged
johnsonshi added a commit to SanyaKochhar/aks-periscope that referenced this issue Jun 22, 2021
@johnsonshi
feat: add SMI log collector
1f68f5a 
Add log collector for Service Mesh Interface
logs, CustomResourceDefinitions, and custom
resources.

Related to PR Azure#48.

Resolves issue Azure#67.

Signed-off-by: Johnson Shi <[email protected]>
johnsonshi added a commit to SanyaKochhar/aks-periscope that referenced this issue Jun 22, 2021
@johnsonshi
feat: add SMI log collector
de49005 
Add log collector for Service Mesh Interface
logs, CustomResourceDefinitions, and custom
resources.

Related to PR Azure#48.

Resolves issue Azure#67.

Signed-off-by: Johnson Shi <[email protected]>
@Tatsinnit Tatsinnit linked a pull request Jun 24, 2021 that will close this issue
feat: add SMI log collector #71
Merged
johnsonshi added a commit to SanyaKochhar/aks-periscope that referenced this issue Jun 28, 2021
@johnsonshi
feat: add SMI log collector
8c5a5c4 
Add log collector for Service Mesh Interface
logs, CustomResourceDefinitions, and custom
resources.

Related to PR Azure#48.

Resolves issue Azure#67.

Signed-off-by: Johnson Shi <[email protected]>
johnsonshi added a commit to SanyaKochhar/aks-periscope that referenced this issue Jul 7, 2021
@johnsonshi
feat: add SMI log collector
45af0a3 
Add log collector for Service Mesh Interface
logs, CustomResourceDefinitions, and custom
resources.

Related to PR Azure#48.

Resolves issue Azure#67.

Signed-off-by: Johnson Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnsonshi johnsonshi

@SanyaKochhar SanyaKochhar

Labels
enhancement 🏎 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add SMI log collector SanyaKochhar/aks-periscope
3 participants
@Tatsinnit @johnsonshi @SanyaKochhar