Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-test for network-bound collectors. #110

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Sep 5, 2021

This PR adds unit-test for the network bound-collector, key motivation is to improve code base quality along with code-cov.

Thanks.

cc: @arnaud-tincelin 🙏☕️ & fyi: @rzhang628 and @qpetraroia

@Tatsinnit Tatsinnit self-assigned this Sep 5, 2021
@Tatsinnit Tatsinnit added the enhancement 🏎 New feature or request label Sep 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #110 (ff0dafc) into master (7e0b1a9) will increase coverage by 8.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   18.30%   26.78%   +8.47%     
==========================================
  Files          12       12              
  Lines         519      519              
==========================================
+ Hits           95      139      +44     
+ Misses        412      367      -45     
- Partials       12       13       +1     
Impacted Files Coverage Δ
pkg/collector/networkoutbound_collector.go 91.66% <0.00%> (+91.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0b1a9...ff0dafc. Read the comment docs.

@Tatsinnit Tatsinnit merged commit 184bc3f into Azure:master Sep 6, 2021
@Tatsinnit Tatsinnit deleted the unittest/networkbound-collector branch September 6, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏎 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants