Fix APIServerNaming issue - handle Ripple effect in AZ-CLI and VsCode.

[Tatsinnit]

This issue is open to handle effect of a fix which will impact consuming tools, since the fix needs to be deployed to the consuming tools az-cli and vscode aks extension https://github.com/Azure/aks-periscope#dependent-consuming-tools-and-working-contract

What is the issue?

Part of the issue is that the periscope exporter formulates the container name from the APIServerName, but the way it does it makes the tool highly coupled to a kubeconfig hardocded file existing in AKS cluster. There are other issues which are documented here: #92 so from within the in-cluster scenarios there are various things which we cannot get information regarding clusters external kubeconfig, hence we need to handle it more elegantly and open the tool usage to wider scenarios.

How we could fix that? (i.e. Solution)

Keep usage i.e. apiservername as the consuming tools used for the container name for azure storage but instead of internally doing it supply them from tool. like kubectl cluster-info can give much information and it could be passed on to the tool.

Simplest organic solution is to supply the container from consuming tool. Implementation to remove the hard-coded kubeconfig path will look like this. #96

What next:

Before we change or publish the way container name works for storage with in periscope we need to make sure we open Connecting issues for az-cli and vscode get their repos ready for this change hence not-break any of this tool

ToDo: Open tracking workitem against both the az-cli and vscode regarding this impacting change.

• AKS Periscope breaking change: Need to supply ContainerName to AKS Periscope from future release v0.5 onwards vscode-aks-tools#80
• AKS Periscope breaking change: Need to supply ContainerName to AKS Periscope from future release v0.5 onwards  azure-cli-extensions#3766

Thank you @qpetraroia for opening these tracking workitem for information and fix tracking.

Thanks.

cc: @arnaud-tincelin , @JunSun17 , @palma21 , @justindavies , @qpetraroia and @rzhang628 - FYI - Thanks heaps

[Tatsinnit]

💡Please Note: The repo level PR is merged but I am keeping this issue open for other 2 tools to gradually make changes which will be part of image v0.5 - I will work on getting that image up today. thanks.

[Tatsinnit]

Update: Here are the 2 PR in respective projects to resolve this in consuming tools:

• [AKS] Handle containerName passing and edge case for containerName. azure-cli-extensions#3971
• Periscope work for kustomise related changes. vscode-aks-tools#82

Thanks 🙏☕️

[Tatsinnit]

🔔 Update: both the consuming tools PR are merged now so both key consuming tools no longer use the aks-periscope yaml from this repo via http, please note we should keep the deprecated aks-periscope.yaml for few days more because az cli is not released yet, and some folks run on old azcli.

Hence closing the issue, thanks 🙏☕️