Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SMI collector to use client-go. #127

Closed
Tatsinnit opened this issue Oct 9, 2021 · 0 comments · Fixed by #179
Closed

Refactor SMI collector to use client-go. #127

Tatsinnit opened this issue Oct 9, 2021 · 0 comments · Fixed by #179
Assignees
Labels
enhancement 🏎 New feature or request

Comments

@Tatsinnit
Copy link
Member

Following workitem is associated with #124 in a sense that both the collectors extensively used the kubectl implementation which we should plan of converting into golang -> pkg based implementations which could involve using kubernetes - client-go or kubernetes or apiextensionsClient under the hood.

The long term benefit we are aiming for is the test-ability (Increase codeCoverage), along with removal of kubectl binary download, if we 100% move to using the pkgs, (which is medium to long term plan)

some helpful pkgs:

Thanks heaps, fyi: @SanyaKochhar , thanks and I could collaborate with you, for help.

cc: @rzhang628 , @arnaud-tincelin , @qpetraroia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏎 New feature or request
Projects
None yet
2 participants