Add support for applications on Azure Stack Cloud #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arnaud-tincelin
suggested changes
Jun 3, 2021
Tatsinnit
reviewed
Jun 3, 2021
Tatsinnit
reviewed
Jun 3, 2021
jadarsie
reviewed
Jun 3, 2021
shwetamurali
force-pushed
the
shweta-azurestackcloud
branch
3 times, most recently
from
8d16ac3 to
b4a7a3f
Compare
shwetamurali
force-pushed
the
shweta-azurestackcloud
branch
from
b4a7a3f to
ff67860
Compare
arnaud-tincelin
approved these changes
Jun 8, 2021
Tatsinnit
approved these changes
Jun 8, 2021
shwetamurali
added a commit
to shwetamurali/aks-periscope
that referenced
this pull request
Jun 23, 2021
Add support for applications on Azure Stack Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aks-periscope is not currently supported on Azure Stack. This change is needed in order to support the aks kollect and kanalyze commands on Azure Stack, which will deploy aks-periscope on the customer cluster. The changes made, such as verifying if the application is running on Azure Stack Cloud, and if so, gathering the cert and storage endpoint suffix and modifying the url accordingly, allows these commands to run on Stack and therefore enables the forwarding of specified node logs to the storage account.