fix test according to non-buggy behaviour. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
force-pushed
the
fix-end-to-end-test
branch
from
828168a to
4d25d7e
Compare
arnaud-tincelin
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a code refactor PR which got rid of a buggy behaviour which caused the test to fail for obvious reasons.
This test fix is more true to its correct behaviour rightnow.
Previous behaviour: if user reply periscope with validation as false, oi.e. no storage in play, it will still go and run the pods under the hood.
Note: We cannot emulate storage hence as an end to end earlier, we were piggy backing on a bug which was hdden on the aks-periscope, which had a pod running even with the validation=false