Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade \ Move RunCommandOnHost to using client-go api. #88

Closed
Tatsinnit opened this issue Jul 29, 2021 · 0 comments · Fixed by #89
Closed

Upgrade \ Move RunCommandOnHost to using client-go api. #88

Tatsinnit opened this issue Jul 29, 2021 · 0 comments · Fixed by #89
Labels
enhancement 🏎 New feature or request triage 💭 Need triage to replicate or identify right fix

Comments

@Tatsinnit
Copy link
Member

Tatsinnit commented Jul 29, 2021

Currently this project uses the uitls function called RunCommandOnHost which runs kubectl command under the hood on various occasions using os.exec, this feature upgrade request work item is open to scope the work which is required to move away from this.

Key challenges:

Translating the kubectl to the exact command is something we need to figure out, translating the kubectl what we run from command prompt needs to be implemented via API, might be best approach will be to write a separate helper and start this by translating one collector which uses kubctl under the hood.

Some helpful link:

Thanks,

FYI : few co-maintainer and founders - cc: @arnaud-tincelin , @JunSun17 or anyone interested and reading this (Please feel free to add any solutions which you have in mind)

@Tatsinnit Tatsinnit added triage 💭 Need triage to replicate or identify right fix enhancement 🏎 New feature or request labels Jul 29, 2021
@Tatsinnit Tatsinnit linked a pull request Aug 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏎 New feature or request triage 💭 Need triage to replicate or identify right fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant