Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go linter for workflow and repo. #62

Merged
merged 11 commits into from
May 31, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented May 31, 2021

This PR enables the golang linter all the changes for this PR is for the existing code and the errors it had.

Following PR achieves:

  • Enabling GoLang Linter in repo.
  • Add it to the git-workflow.

Thanks

Old error vs new run looks like this:

With Changes:

Screen Shot 2021-05-31 at 6 06 05 PM

Without changes:

Screen Shot 2021-05-31 at 4 56 40 PM

@Tatsinnit Tatsinnit self-assigned this May 31, 2021
@arnaud-tincelin
Copy link
Collaborator

did you have a look at https://github.com/golangci/golangci-lint-action#how-to-use ?

@Tatsinnit Tatsinnit requested a review from arnaud-tincelin May 31, 2021 09:44
@Tatsinnit Tatsinnit requested a review from arnaud-tincelin May 31, 2021 10:03
@Tatsinnit Tatsinnit requested a review from arnaud-tincelin May 31, 2021 10:10
@Tatsinnit Tatsinnit merged commit e7b9fbf into Azure:master May 31, 2021
@Tatsinnit Tatsinnit deleted the feature/golang-linter branch September 2, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants