sync from master. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Risk Level: n/a (code not yet used) Testing: existing tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <[email protected]>
…15863) Commit Message: extended request options to support passing metadata match criteria Additional Description: Extended request options to support passing metadata match criteria. Check #15163 for more info about that why we need this PR. This PR is just a possible solution. I would be willing to modify it if there is a more elegant solution. Risk Level: Low. Testing: Added. Docs Changes: N/A. Signed-off-by: wbpcode <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
) In #15668 we began supporting cluster level metrics for the thrift_proxy connection manager. These metrics were limited to messageType counters only; now that these are working OK we are comfortable moving to cluster level histograms for upstream_rq_time. Risk Level: Low Testing: New unit tests Docs Changes: future pr Release Notes: updated Signed-off-by: William Fu <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
H2 waitForReset also picks up end stream, while H2 doesn't, so a bunch of QUIC tests were actually spinning on waitForReset until disconnect happened. Fixing it and fixing it forward by having a faster timeout which catches if we're waiting for the wrong thing. Risk Level: n/a Testing: passes locally at least =P Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <[email protected]>
…sion (#15914) The PR updates the example plugin configuration section related to wasm service in the envoy documentation. Signed-off-by: Lahiru Udayanga <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
This hadn't been run in a while, will re-enable in CI when this lands. Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Commit Message: Fixing a crash when the decoder receives an empty metadata map. Additional Description: Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode. The proposed fix ignores the empty metadata maps and updates a stats if one is received. Risk Level: Medium for Envoy's running with Metadata support. Testing: Added integration tests. Docs Changes: Added a codec stats counter description. Release Notes: Added bug fix description. Platform Specific Features: N/A. Fixes a fuzz bug: 25303 Signed-off-by: Tony Allen <[email protected]>
Fixes CVE-2021-28682, a remotely exploitable integer overflow. Signed-off-by: Asra Ali <[email protected]> Co-authored-by: Tony Allen <[email protected]> Signed-off-by: Tony Allen <[email protected]>
Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Greg Greenway <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]> Signed-off-by: Tony Allen <[email protected]>
Signed-off-by: Tony Allen <[email protected]>
Signed-off-by: Tony Allen <[email protected]>
Signed-off-by: Tony Allen <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Once more unto the breach. Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Risk Level: n/a (hidden by default) Testing: e2e tests Docs Changes: n/a Release Notes: n/a Part of #14829
Signed-off-by: Florin Coras <[email protected]>
Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 3.5.3 to 3.5.4. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES) - [Commits](https://github.com/sphinx-doc/sphinx/commits/v3.5.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…cache_impl.{h,cc} (#16424)
grid: Rename alternate_protocols_cache.{h,cc} to alternate_protocols_cache_impl.{h,cc}
Risk Level: Low
Testing: N/A - rename only
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Signed-off-by: Ryan Hamilton <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Fixes: CVE-2021-29492 Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
* build(deps): bump protobuf in /examples/grpc-bridge/client Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.15.8 to 3.16.0. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.15.8...v3.16.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump attrs from 20.3.0 to 21.2.0 in /ci/flaky_test Bumps [attrs](https://github.com/python-attrs/attrs) from 20.3.0 to 21.2.0. - [Release notes](https://github.com/python-attrs/attrs/releases) - [Changelog](https://github.com/python-attrs/attrs/blob/main/CHANGELOG.rst) - [Commits](python-attrs/attrs@20.3.0...21.2.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump attrs from 20.3.0 to 21.2.0 in /tools/testing Bumps [attrs](https://github.com/python-attrs/attrs) from 20.3.0 to 21.2.0. - [Release notes](https://github.com/python-attrs/attrs/releases) - [Changelog](https://github.com/python-attrs/attrs/blob/main/CHANGELOG.rst) - [Commits](python-attrs/attrs@20.3.0...21.2.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump flake8 from 3.9.1 to 3.9.2 in /tools/code_format Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.9.1 to 3.9.2. - [Release notes](https://gitlab.com/pycqa/flake8/tags) - [Commits](https://gitlab.com/pycqa/flake8/compare/3.9.1...3.9.2) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The python3-pip package is needed on both Ubuntu and Fedora. Signed-off-by: James Peach <[email protected]>
Conform to default C:\msys64 path name. Signed-off-by: Long Dai <[email protected]>
* build(deps): bump sphinx-tabs from 2.1.0 to 3.0.0 in /docs Bumps [sphinx-tabs](https://github.com/executablebooks/sphinx-tabs) from 2.1.0 to 3.0.0. - [Release notes](https://github.com/executablebooks/sphinx-tabs/releases) - [Changelog](https://github.com/executablebooks/sphinx-tabs/blob/master/CHANGELOG.md) - [Commits](executablebooks/sphinx-tabs@v2.1.0...v3.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump sphinx from 3.5.4 to 4.0.1 in /docs Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 3.5.4 to 4.0.1. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES) - [Commits](sphinx-doc/sphinx@v3.5.4...v4.0.1) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * update-intersphinx Signed-off-by: Ryan Northey <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Mike Schore <[email protected]>
Signed-off-by: Snow Pettersen <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Vladimir Moskva <[email protected]>
In order to support calls to Server::Instance::flushStats while also having a flush timer activated we need to handle a flush being requested while in the process of doing a periodic flush. This PR avoids triggering a flush in these cases under the assumption that it is not needed since we're already flushing. Signed-off-by: Snow Pettersen <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
This PR is part of #16049 to support general tracing. Please check #16049 get more details. Commit Message: remove trace drivers' dependency on HttpTracerImpl Additional Description: Now all tracers (zipkin, skywalking, etc.) will depend on HttpTracerImpl, making it difficult for Tracers to be reused by other protocols (Dubbo, Thrift, etc.). The purpose of this PR is to change this dependency. Risk Level: Low (No new logic). Testing: Add. Docs Changes: N/A Release Notes: N/A Signed-off-by: wbpcode <[email protected]>
canonical must include the hashed payload for most services. The prior behavior of using UNSIGNED-PAYLOAD is an exception to the rule, which select services like s3 support, since hashing the payload may be impractical if the payload is very large. A new filter option is introduced, so that the filter may be explicitly configured to use the UNSIGNED-PAYLOAD string literal as specified in the S3 signing docs: https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html fixes #13904 Additional Description: The original implementation was seemingly very specific to S3 and was subsequently amended to extend the same niche singing behaviors for ES and Glacier. This changes the filter's default behavior to match the general SigV4 guidelines while providing a configuration option to enable the specialized UNSIGNED-PAYLOAD behavior. https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html Risk Level: Medium? Deployments using the filter will now buffer requests by default, which could result in 413 responses for requests with bodies exceeding the buffer limit. These users can mitigate buffering by enabling the `unsigned_payload` option. Testing: I tested locally with a filter config. I anticipate updating the automated tests based on feedback from maintainers. Docs Changes: Added Signed-off-by: Jonathan Stewmon <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
* build(deps): bump markupsafe in /source/extensions/filters/network/kafka Bumps [markupsafe](https://github.com/pallets/markupsafe) from 1.1.1 to 2.0.0. - [Release notes](https://github.com/pallets/markupsafe/releases) - [Changelog](https://github.com/pallets/markupsafe/blob/main/CHANGES.rst) - [Commits](pallets/markupsafe@1.1.1...2.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump markupsafe from 1.1.1 to 2.0.0 in /tools/protodoc Bumps [markupsafe](https://github.com/pallets/markupsafe) from 1.1.1 to 2.0.0. - [Release notes](https://github.com/pallets/markupsafe/releases) - [Changelog](https://github.com/pallets/markupsafe/blob/main/CHANGES.rst) - [Commits](pallets/markupsafe@1.1.1...2.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump jinja2 in /source/extensions/filters/network/kafka Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.3 to 3.0.0. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@2.11.3...3.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump jinja2 from 2.11.3 to 3.0.0 in /tools/protodoc Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.3 to 3.0.0. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@2.11.3...3.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump jinja2 from 2.11.3 to 3.0.0 in /docs Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.3 to 3.0.0. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@2.11.3...3.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump markupsafe from 1.1.1 to 2.0.0 in /configs Bumps [markupsafe](https://github.com/pallets/markupsafe) from 1.1.1 to 2.0.0. - [Release notes](https://github.com/pallets/markupsafe/releases) - [Changelog](https://github.com/pallets/markupsafe/blob/main/CHANGES.rst) - [Commits](pallets/markupsafe@1.1.1...2.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> * build(deps): bump jinja2 from 2.11.3 to 3.0.0 in /configs Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.3 to 3.0.0. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@2.11.3...3.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump markupsafe from 1.1.1 to 2.0.0 in /docs Bumps [markupsafe](https://github.com/pallets/markupsafe) from 1.1.1 to 2.0.0. - [Release notes](https://github.com/pallets/markupsafe/releases) - [Changelog](https://github.com/pallets/markupsafe/blob/main/CHANGES.rst) - [Commits](pallets/markupsafe@1.1.1...2.0.0) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ryan Northey <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This reverts commit ff62ef1. Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Long Dai <[email protected]>
Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Ryan Northey <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The client_secret field was not updated on configuration changes. Signed-off-by: i.makarychev <[email protected]>
Signed-off-by: Christoph Pakulski <[email protected]>
Signed-off-by: Benjamin Peterson <[email protected]>
This is a follow-up to: #14432 (comment) After that PR, it's no longer possible (unless you do a dynamic_cast) to set the remote address from a filter. This is something that we need to do because we have specialized logic for this (XFF doesn't work for us). So this adds an extension point which will allow us to push that logic down to ConnectionManagerUtility::mutateRequestHeaders() where it belongs. Signed-off-by: Raul Gutierrez Segales <[email protected]>
* docs: comment config extension Signed-off-by: Long Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]