docs : update wasm service example plugin config as a bootstrap extension #15914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NomadXD, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Lahiru Udayanga <[email protected]>
Signed-off-by: Lahiru Udayanga <[email protected]>
Signed-off-by: Lahiru Udayanga <[email protected]>
|
@PiotrSikora does this make sense? |
PiotrSikora
previously approved these changes
Apr 12, 2021
There was a problem hiding this comment.
@PiotrSikora does this make sense?
Yes, see: #15860 (comment).
Signed-off-by: Lahiru Udayanga <[email protected]>
PiotrSikora
approved these changes
Apr 14, 2021
douglas-reid
pushed a commit
to douglas-reid/envoy
that referenced
this pull request
Apr 19, 2021
…sion (envoyproxy#15914) The PR updates the example plugin configuration section related to wasm service in the envoy documentation. Signed-off-by: Lahiru Udayanga <[email protected]> Signed-off-by: Douglas Reid <[email protected]>
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
…sion (envoyproxy#15914) The PR updates the example plugin configuration section related to wasm service in the envoy documentation. Signed-off-by: Lahiru Udayanga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: update wasm service example plugin config as a bootstrap extension
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: The PR updates the example plugin configuration section related to wasm service in the envoy documentation.
Release Notes: N/A
Platform Specific Features: N/A