Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for CI gcc build error with long argument list #16484

Merged
merged 2 commits into from
May 14, 2021

Conversation

yanavlasov
Copy link
Contributor

@yanavlasov yanavlasov commented May 13, 2021

Issue: #16196
Signed-off-by: Yan Avlasov [email protected]

@yanavlasov
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

lizan
lizan previously approved these changes May 13, 2021
Copy link
Contributor

@antoniovicente antoniovicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the temporary workaround, it's good to unblock PRs in progress.

bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild "${TEST_TARGETS[@]}"
# Disable //test/config_test:example_configs_test so it does not fail because of excluded extensions above
echo "Testing ${TEST_TARGETS[*]} -//test/config_test:example_configs_test"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c fastbuild -- "${TEST_TARGETS[@]}" -//test/config_test:example_configs_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fastbuild is hit the hardest by command line limits because of the longer bazel output paths of "fastbuild" while "opt" and "dbg" are considerably shorter: 6 characters shorter for each of the thousands of include and library paths.

Changing the gcc CI to use opt or dbg may serve as a decent work around until we find a better alternative.

@yanavlasov yanavlasov merged commit 8c59b6a into envoyproxy:main May 14, 2021
@yanavlasov yanavlasov deleted the gcc-ci-fix branch December 21, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants