grid: Rename alternate_protocols_cache.{h,cc} to alternate_protocols_cache_impl.{h,cc} #16424
Conversation
…cache_impl.{h,cc}
Signed-off-by: Ryan Hamilton <[email protected]>
RyanTheOptimist
force-pushed
the
AlternateProtocolsCacheImpl
branch
from
e7bc390 to
d7ee30d
Compare
|
/assign @alyssawilk |
Signed-off-by: Ryan Hamilton <[email protected]>
Signed-off-by: Ryan Hamilton <[email protected]>
include/envoy/common/http/BUILD
Outdated
| envoy_package() | ||
|
|
||
| envoy_cc_library( | ||
| name = "alternate_protocols_cache_interface", |
There was a problem hiding this comment.
generally we skip interface for these library names
There was a problem hiding this comment.
-> include/envoy/http and I'm so sorry if I guessed the wrong name offhand
There was a problem hiding this comment.
Moved to envoy/http/. But the others in that dir have _interface so I kept the suffix.
| @@ -73,34 +73,22 @@ class AlternateProtocolsCache { | |||
| uint32_t port_; | |||
| }; | |||
|
|
|||
| explicit AlternateProtocolsCache(TimeSource& time_source); | |||
| virtual ~AlternateProtocolsCache() = default; | |||
|
|
|||
| // Sets the possible alternative protocols which can be used to connect to the | |||
| // specified origin. Expires after the specified expiration time. | |||
| explicit AlternateProtocolsCacheImpl(TimeSource& time_source); | ||
| ~AlternateProtocolsCacheImpl() override; | ||
|
|
||
| // Sets the possible alternative protocols which can be used to connect to the |
There was a problem hiding this comment.
Now these are overrides the common thing to do is
// AlternateProtocolsCache
block of uncommented override functions
since it's "known" you refer to the API for what it's doing
There was a problem hiding this comment.
Ah, good point. Done.
| // Tracks alternate protocols that can be used to make an HTTP connection to an origin server. | ||
| // See https://tools.ietf.org/html/rfc7838 for HTTP Alternate Services and | ||
| // https://datatracker.ietf.org/doc/html/draft-ietf-dnsop-svcb-https-04 for the | ||
| // "HTTPS" DNS resource record. |
There was a problem hiding this comment.
update class comments for less copy/pasting?
an implementation of AlternateProtocolsCache [anything special or unique]
There was a problem hiding this comment.
Done. (Will expand the comment in the larger PR when it does more, like use TLS)
Signed-off-by: Ryan Hamilton <[email protected]>
Signed-off-by: Ryan Hamilton <[email protected]>
There was a problem hiding this comment.
lgtm modulo whitespace nit
Let's land that in #16385 so you don't lose an hour of CI :-)
Signed-off-by: Ryan Hamilton <[email protected]>
grid: Rename alternate_protocols_cache.{h,cc} to alternate_protocols_cache_impl.{h,cc}
Risk Level: Low
Testing: N/A - rename only
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A