docs: comment config extension #16406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Long Dai <[email protected]>
|
Hi @daixiang0, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
phlax
reviewed
May 10, 2021
Signed-off-by: Long Dai <[email protected]>
phlax
reviewed
May 11, 2021
Signed-off-by: Long Dai <[email protected]>
phlax
reviewed
May 11, 2021
phlax
reviewed
May 11, 2021
Signed-off-by: Long Dai <[email protected]>
phlax
reviewed
May 11, 2021
Signed-off-by: Long Dai <[email protected]>
phlax
reviewed
May 11, 2021
Signed-off-by: Long Dai <[email protected]>
|
@daixiang0 the change looks gtm - but unfortunately CI has been taken down - so i will review again tomorrow |
|
@phlax take your time, thanks for review |
phlax
reviewed
May 11, 2021
Signed-off-by: Long Dai <[email protected]>
|
@phlax could it be merged? |
ntgsx92
pushed a commit
to ntgsx92/envoy
that referenced
this pull request
May 18, 2021
* docs: comment config extension Signed-off-by: Long Dai <[email protected]> Signed-off-by: Sixiang Gu <[email protected]>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
* docs: comment config extension Signed-off-by: Long Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
If the extension is not
yaml, it would parse an error "INVALID_ARGUMENT:Unexpected token", while it is hard to know where wrong.Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]