http/1.1: correctly handle connection header for for incoming requests #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't previously handle the Connection: close header for incoming HTTP/1.1 requests. This commit fixes that. There are also some perf related changes/cleanup in this commit also: 1) Remove synthetic :version header and replace with an explicit codec protocol method. 2) Remove the x-envoy-protocol-version response header. This was used for debugging when we first rolled out HTTP/2 support and no longer has any real value.
|
@lyft/network-team |
RomanDzhabarov
approved these changes
Nov 23, 2016
| @@ -175,7 +174,7 @@ Network::FilterStatus ConnectionManagerImpl::onData(Buffer::Instance& data) { | |||
| // The HTTP/1.1 codec will pause dispatch after a single message is complete. We want to | |||
There was a problem hiding this comment.
nit: it's also the case for HTTP/1.0, something like non HTTP/2 codec ..
| const HeaderString& codec_version = request_headers_->Version()->value(); | ||
| if (!(codec_version == "HTTP/1.1" || codec_version == "HTTP/2")) { | ||
| Protocol protocol = connection_manager_.codec_->protocol(); | ||
| if (!(protocol == Protocol::Http11 || protocol == Protocol::Http2)) { |
There was a problem hiding this comment.
why not directly, protocol == Protocol::Http10 ?
There was a problem hiding this comment.
Just in case we add something else in the future, but the chance of that happening is basicaly zero so I will fix it.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Oct 10, 2019
Signed-off-by: Piotr Sikora <[email protected]>
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 2, 2020
mattklein123
pushed a commit
that referenced
this pull request
Apr 15, 2021
Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Greg Greenway <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]> Signed-off-by: Tony Allen <[email protected]>
douglas-reid
referenced
this pull request
in douglas-reid/envoy
Apr 19, 2021
Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Greg Greenway <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]> Signed-off-by: Tony Allen <[email protected]> Signed-off-by: Douglas Reid <[email protected]>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…oyproxy#239) Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Greg Greenway <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]> Signed-off-by: Tony Allen <[email protected]> Signed-off-by: Gokul Nair <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Restricting subclassing and visibility of these types. Risk Level: None Testing: CI Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Restricting subclassing and visibility of these types. Risk Level: None Testing: CI Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't previously handle the Connection: close header for incoming
HTTP/1.1 requests. This commit fixes that.
There are also some perf related changes/cleanup in this commit also:
protocol method.
for debugging when we first rolled out HTTP/2 support and no longer
has any real value.