Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: follow up to #15926 #16421

Merged
merged 1 commit into from
May 12, 2021
Merged

docs: follow up to #15926 #16421

merged 1 commit into from
May 12, 2021

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 10, 2021 •
edited
Loading

Risk Level: n/a
Testing: n/a
Docs Changes: yes
Release Notes: n/a

danzh2010
danzh2010 approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@danzh2010 danzh2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing all the docs!

phlax
phlax approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm, thanks

@alyssawilk alyssawilk merged commit 06c8d41 into envoyproxy:main May 12, 2021
@alyssawilk alyssawilk deleted the docs branch August 18, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danzh2010 danzh2010 danzh2010 approved these changes

@ggreenway ggreenway ggreenway approved these changes

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

@danzh2010 danzh2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alyssawilk @phlax @ggreenway @danzh2010