Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cleanups for 1.18.0 release #15983

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 15, 2021

Signed-off-by: Ryan Northey [email protected]

Commit Message: docs: Cleanups for 1.18.0 release
Additional Description:

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #14995
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #15983 was opened by phlax.

see: more, trace.

@phlax phlax marked this pull request as draft April 15, 2021 12:34
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Apr 15, 2021

re admin section, the reasoning for not including the admin section in the default config is that it exposes the server and i felt it was better to make adding the admin section explicit - so i added an admin section in getting started to compensate

i mistakenly approved #14833 that added this back when the better fix would have been to fix the docs

there is still the admin section in the actual docker image which we may want to follow up and remove

Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Apr 15, 2021

phlax added 2 commits April 15, 2021 14:58
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Apr 15, 2021

@htuch ive added a fix to prevent the empty json dicts for extensions that dont have config

not sure if this is the correct fix - but its certainly better than what it does currently (at least where i have checked)

@phlax phlax changed the title [WIP] docs: Cleanups for 1.18.0 release docs: Cleanups for 1.18.0 release Apr 15, 2021
@phlax phlax marked this pull request as ready for review April 15, 2021 14:24
@phlax
Copy link
Member Author

phlax commented Apr 15, 2021

cc @mattklein123

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mattklein123 mattklein123 merged commit d6a9f31 into envoyproxy:main Apr 15, 2021
douglas-reid pushed a commit to douglas-reid/envoy that referenced this pull request Apr 19, 2021
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Douglas Reid <[email protected]>
Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are showing an empty dictionary in places
3 participants