-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Cleanups for 1.18.0 release #15983
Conversation
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
re admin section, the reasoning for not including the admin section in the default config is that it exposes the server and i felt it was better to make adding the admin section explicit - so i added an admin section in getting started to compensate i mistakenly approved #14833 that added this back when the better fix would have been to fix the docs there is still the admin section in the actual docker image which we may want to follow up and remove |
Signed-off-by: Ryan Northey <[email protected]>
docs rendered here https://storage.googleapis.com/envoy-pr/15983/docs/index.html |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@htuch ive added a fix to prevent the empty not sure if this is the correct fix - but its certainly better than what it does currently (at least where i have checked) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Douglas Reid <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey [email protected]
Commit Message: docs: Cleanups for 1.18.0 release
Additional Description:
:refs:
and other api issues #15766Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #14995
[Optional Deprecated:]
[Optional API Considerations:]