Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are showing an empty dictionary in places #14995

Closed
phlax opened this issue Feb 9, 2021 · 1 comment · Fixed by #15983
Closed

Docs are showing an empty dictionary in places #14995

phlax opened this issue Feb 9, 2021 · 1 comment · Fixed by #15983
Assignees
Labels

Comments

@phlax
Copy link
Member

phlax commented Feb 9, 2021

description

seems like there is an issue with protodoc that is causing an empty dictionarry to be added to some of the generated docs

for example:

https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/filter/thrift/router/v2alpha1/router.proto#config-filter-thrift-router-v2alpha1-router

@phlax phlax added bug triage Issue requires triage labels Feb 9, 2021
@antoniovicente antoniovicente self-assigned this Feb 9, 2021
@mattklein123 mattklein123 added help wanted Needs help! and removed bug triage Issue requires triage labels Feb 12, 2021
@phlax
Copy link
Member Author

phlax commented Apr 15, 2021

@antoniovicente ive added a "fix" for this in #15983

not sure if this is the best fix - it just stops it from outputting the empty dict - im wondering if you had a better idea here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants