Units integration matterlab #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHKnudsen
requested changes
Jun 29, 2021
There was a problem hiding this comment.
@M-JULIANI as a general note i think a lot of the public members are missing summaries
SHKnudsen
requested changes
Jul 8, 2021
* Local Definitions in workspace references * Serialize local definitions information and display it in the workspace references view extension. * Display file size. * Add icons * adjust formatting * Serialize LocalDefinitions info into NodeLibraryDependencies property and add tests * Fix some tests. * Fix view extension expansion property incase of missing references. Also fixing serialization issue around missing references * Comments * some serialization fixes * some comments * modify logs * Use TryGetValue method. * Remove System.Windows.Forms references. * Update WorkspaceModel.cs * use constant. * update comments * Update WorkspaceDependencyView.xaml.cs * Update Icon properties to Embedded in resx. * Change the enum value to DYFFile * Update LocalDefinitionsTest.dyn
…ynamoDS#12003) * Node Redesign (DynamoDS#11892) * DYN-3768-SurveyWindowUI (DynamoDS#11834) * DYN-3768-SurveyWindowUI I created 3 resources for the two titles of the SurveyWindow and one for the text content. I modified the CustomRichTextBox because hyperlink names separated by spaces were not supported then I did some changes and now are working. I added the RatingControl UI and the SurveyPopup UI and some used styles in the DynamoModern.xaml. Finally I added a instance of the Survey in the DynamoView.xaml.cs and now a survey popup will be displayed just for testing purposes. * DYN-3768-SurveyWindowUI Code Review I added several comments in SurveyPopupViewModel and RatingControl and removed a comment Survey * DYN-3768-SurveyWindowUI Code Review2 Updated the DependencyProperty name to Value * Update and rename 4_stdlib.md to 4_builtinpackages.md (DynamoDS#11850) * Update and rename 4_stdlib.md to 4_builtinpackages.md * Update 4_builtinpackages.md * Add ways to pass Analytics Host Entitlement info for out of process integrators (DynamoDS#11841) * Initial Commit * Add ParentId to update manager * Updates * Add CLI support * Add unit tests * Update tests * Update HostContextInfo type usage * Comments to use struct * Move properties out of update manager * Update * Comments * Comments * update test * Force Dynamo to run on nvidia graphics card to address helix crash with multiple monitors (DynamoDS#11855) * enable nvidia graphics card for helix * make new field private * Triggering Node AutoComplete on input port should not destroy the connection. (DynamoDS#11859) * Extension fix (DynamoDS#11861) DYN-3773 * Upgrade Helix to 2.17.0. (DynamoDS#11860) * DYN-3834-GeoScaling-GraphRun (DynamoDS#11845) * DYN-3834-GeoScaling-GraphRun There was an issue that when the Geometry Scaling was updated in a very large graph the Preferences panel was blocked not allowing the user to close it. I think this behavior was because when the Preference panel was opened immediately a graph run was executed (without changing anything in the Preferences panel). I was NOT able to reproduce the Preferences panel freezing behavior but we noticed that the graph execution was always happening when the Preferences panel was opened (when nothing was changed), then I did a fix in a way that the selected radio button (in geometry scaling section) is updated every time a new workspace is created or a dyn file is loaded (as is happening with the WorkspaceModel.ScaleFactor), so the graph run will be executed just when the ScaleFactor is changed. * DYN-3834-GeoScaling-GraphRun Code Review Unsubscribing from the WorkspaceSettingsChanged when the PreferencesViewModel is cleared. * DYN-3834-GeoScaling-GraphRun Code Review Making method private due that is just used in the same class. * DYN-3834-GeoScaling-GraphRun Code Review I did some changes so only when the ScaleFactor was changed a graph run will be executed when the Preferences dialog is closed * DYN-3834-GeoScaling-GraphRun Code Review2 Replacing the call to ForceRunCancelCommand method for MarkNodesAsModifiedAndRequestRun due that the first one was executing the graph when the RunMode = Manual at the moment of updating the Geometry Scaling in the other hand with the MarkNodesAsModifiedAndRequestRun doesn't happen that behavior. * Pin Note to Node (DynamoDS#11840) * Pin to node squashed commit * Changes for pin to node pr * Add spacing to pin icon * Retain pin node in copy paste, also correct spacing between note pin icon and text * Move selection to command * Place PIN_WIDTH as constant * Fix distance in unit tests * update libG for perimeter curves refactor (DynamoDS#11870) Co-authored-by: pinzart <[email protected]> * add test for dyn-3628 fix (DynamoDS#11872) * add dump bytecode debug mode (DynamoDS#11871) * add dump bytecode debug mode * DYN-3815 - Prevent reloading of packages unless there are new packages in list of package paths (DynamoDS#11835) * initial commit - WIP * fixes for extraneous notifications and duplicate nodes * cleanup * revert unchanged file * fix new package logic * remove unused property * fix some tests * revert unchanged file * fix remaining tests * obsolete property * cleanup * edit obsoletion message * load loose custom node defn files by simply adding root path * add unit tests * review comments * revert rename of public API * unsub events in tests * DYN-3834-GeoScaling-UnitTest (DynamoDS#11867) * DYN-3834-GeoScaling-UnitTest I added one unit tests with two parameters, one is for validating that when RunMode=Manual and the MarkNodesAsModifiedAndRequestRun() method is called the graph execution is NOT kicked off. The other when the RunMode=Automatic and the MarkNodesAsModifiedAndRequestRun() method is called the graph execution is kicked off. * DYN-3834-GeoScaling-UnitTest Code Review I had to split the tests in two (one for Automatic and other for Manual) due that the Resources strings can not be used as a parameters in nUnit Tests parameters (since parameters expected should be constant values). * DYN-3834-GeoScaling-UnitTest Code Review2 Adding extra assert before validating the node warning state. A comment was updated reflecting the behavior when RunType = Manual * Pin to Node Selection Behaivior (DynamoDS#11874) * Pin to node squashed commit * Changes for pin to node pr * Add spacing to pin icon * Retain pin node in copy paste, also correct spacing between note pin icon and text * Move selection to command * Place PIN_WIDTH as constant * Fix distance in unit tests * Selection behaviour corrected * Limit pin to node behaviour * Add tooltip for Pin to node command, Enable Pin To Node only when a node and a note is selected * Add test to PinToNodeCommand.canExecute * Update ScopeIf description (DynamoDS#11876) * Update ScopeIf description * ScopeIf Description Update * Update Resources.Designer.cs * DYN-3875: Restore LocalPackages property in PreferencesViewModel (DynamoDS#11881) * restore property in PreferencesViewModel * add regression test for installedpackagesview * fix test * remove setting datacontext for installed packages view control as it is inherited * undo unnecessary changes * more cleanup * fix node autocomplete crash (DynamoDS#11887) * Node redesign (#3) * Updates node styling * Updates UI Adds Artifakt font, changes colors, port/header height config, code block editor colours. * Update UI * Updates UI * Updates UI * Updates UI * Ports visual states are working. * Revert "Ports visual states are working." * Revert "Revert "Ports visual states are working."" This reverts commit 3557726. * Updates UI * Updates ContextMenu style * Updates UI * Updates UI * Updates ComboBox and Output Ports style for Code Blocks * Loads icon to node header * Updates UI * Updates UI * Updates UI * Bug fixes and responding to comments * DYN-3875: Restore LocalPackages property in PreferencesViewModel (DynamoDS#11881) * restore property in PreferencesViewModel * add regression test for installedpackagesview * fix test * remove setting datacontext for installed packages view control as it is inherited * undo unnecessary changes * more cleanup * Updates UI * fix node autocomplete crash (DynamoDS#11887) * Minor UI changes to Autodesk feedback * Temporarily disabled dismissed alerts features * Minor UI fix to the nodes' GlyphStackPanel Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Jorgen Dahl <[email protected]> Co-authored-by: Martin Stacey <[email protected]> Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Sol Amour <[email protected]> * Wire modifications (DynamoDS#11897) * Wire modifications (DynamoDS#23) * Got hidden wire implementation working with View->ConnectorDisplay * Watch node behaviour modified. * Added image resources. Corrected hover/unhover of watch icon based on whether data passing through meets a requirement of 5 or more items. * WirePin: Model, ViewModel, View. Placeable/removable via ContextMenus. * Modified 'RunSharedParams' functionality to work properly. * Basic implementation of pins. Multi-control point bezier implemented. Need to implement a segmented version between pairs of pins. * Added WirePinViewModel discard functionality: DiscardAllWirePins() * Expected behaviour when deleting nodes (pins delete). Provision for opaque/halftone pins/watch icon depending on wire visibility. * Redrawing Watch (hover) icon at the midpoint when there are pins on the wire. * This fixes the 'WatchHoverIcon' when there are pins/ when they are removed. Previously when removing pins the icon was drawn in the wrong place. * Cleanup of unused code. * Clearup + pin highlighting behaviour. * Serialization/Deserialization of pins achieved. * 'Wire' to 'Connector' rename throughout for more consistency with the existing codebase. * Fixed unwanted duplicate pin placement (the one at the origin). * Discarded unused methods. Fixed pin multi-selection functionality. * Fixes to hidden wire display when pin selected. * Preview behaviour of wires fixed when a pin is selected (similar to that of nodes). RaisePropertyChanged(nameof(Property)) throughout ConnectorViewModel. * Basic implementation of 'Autolayout' which includes ConnectorPins. * Delete AssemblySharedInfo. * Remove unnecessary files/ file changes. * Delete unnecessary change. * Removed unnecessary files/file changes. * Delete unneeded change. * Revert "Delete unneeded change." This reverts commit 090fb18. * Revert "Merge branch 'Wire-Modifications' of https://github.com/M-JULIANI/Dynamo into Wire-Modifications" This reverts commit 23dc696, reversing changes made to 06378f0. * Reverted unneeded changes. * Reverting unneeded changes. * Removing unneeded changes. * Removing unneeded changes. * Unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Various PR fixes. * Reverted Resharper renaming of various comments. * PR fixes. * PR fixes. * ConnectorPin visibility fixed (follows Connector visibility). * Fixed PR issues. * Ironed out edge condition- AutoLayout _seems_ to work without any errors thrown at the moment. * PR Cleanup and Autolayout edge case fixes. * Ensures ConnectorPins cannot be copied and pasted (like notes & nodes) but rather have to be placed deliberately. * Functionality added to preserve pins when 'WatchIcon' is clicked and Watch Node is placed. Previously they were discarded. * Cleanup. * Added correct ConnectorPin icons for 'selected' and 'hidden' visibility. Got Undo/Redo functionality working partially. * Got 'undo' working for when a connector is pinned. * Undo/redo functionality between OOTB nodes and between custom nodes. * Cleanup. * Cleanup * Cleanup. * Cleanup. * Cleanup. * Cleanup. * Fixes. * Fixes. * Fixes. * Fixes. * Small fixes. * Removed unused argument. * Fixes. * Small PR fixes. * PR fix. * Small fixes to ensure toggle between pline/bezier connectors and correct pin visibility. * fix breaks * Update RecordedTests.cs * PR fixes. * Connector anchor behaviour implemented. * Added wire hover behaviour (grey outline). Updated 'default' icon behaviour (onhover). * Updates to jive with unit tests. * Bug fix related to pin removal/ watch node placement. * Fixes. Updated pin position/ transform in xaml to achieve correct alignment with GraphLayout routines. * Undo/redo bug fixed. * PR comment fixes. * PR comments fixed. * PR fixes. * PR fixes. * PR fixes. * fix coreWpf csproj file after rebase Co-authored-by: Sylvester Knudsen <[email protected]> * Wire modifications unit tests revised (DynamoDS#11899) * Wire modifications (DynamoDS#23) * Got hidden wire implementation working with View->ConnectorDisplay * Watch node behaviour modified. * Added image resources. Corrected hover/unhover of watch icon based on whether data passing through meets a requirement of 5 or more items. * WirePin: Model, ViewModel, View. Placeable/removable via ContextMenus. * Modified 'RunSharedParams' functionality to work properly. * Basic implementation of pins. Multi-control point bezier implemented. Need to implement a segmented version between pairs of pins. * Added WirePinViewModel discard functionality: DiscardAllWirePins() * Expected behaviour when deleting nodes (pins delete). Provision for opaque/halftone pins/watch icon depending on wire visibility. * Redrawing Watch (hover) icon at the midpoint when there are pins on the wire. * This fixes the 'WatchHoverIcon' when there are pins/ when they are removed. Previously when removing pins the icon was drawn in the wrong place. * Cleanup of unused code. * Clearup + pin highlighting behaviour. * Serialization/Deserialization of pins achieved. * 'Wire' to 'Connector' rename throughout for more consistency with the existing codebase. * Fixed unwanted duplicate pin placement (the one at the origin). * Discarded unused methods. Fixed pin multi-selection functionality. * Fixes to hidden wire display when pin selected. * Preview behaviour of wires fixed when a pin is selected (similar to that of nodes). RaisePropertyChanged(nameof(Property)) throughout ConnectorViewModel. * Basic implementation of 'Autolayout' which includes ConnectorPins. * Delete AssemblySharedInfo. * Remove unnecessary files/ file changes. * Delete unnecessary change. * Removed unnecessary files/file changes. * Delete unneeded change. * Revert "Delete unneeded change." This reverts commit 090fb18. * Revert "Merge branch 'Wire-Modifications' of https://github.com/M-JULIANI/Dynamo into Wire-Modifications" This reverts commit 23dc696, reversing changes made to 06378f0. * Reverted unneeded changes. * Reverting unneeded changes. * Removing unneeded changes. * Removing unneeded changes. * Unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Removed unneeded changes. * Various PR fixes. * Reverted Resharper renaming of various comments. * PR fixes. * PR fixes. * ConnectorPin visibility fixed (follows Connector visibility). * Fixed PR issues. * Ironed out edge condition- AutoLayout _seems_ to work without any errors thrown at the moment. * PR Cleanup and Autolayout edge case fixes. * Ensures ConnectorPins cannot be copied and pasted (like notes & nodes) but rather have to be placed deliberately. * Functionality added to preserve pins when 'WatchIcon' is clicked and Watch Node is placed. Previously they were discarded. * Cleanup. * Added correct ConnectorPin icons for 'selected' and 'hidden' visibility. Got Undo/Redo functionality working partially. * Got 'undo' working for when a connector is pinned. * Undo/redo functionality between OOTB nodes and between custom nodes. * Cleanup. * Cleanup * Cleanup. * Cleanup. * Cleanup. * Cleanup. * Fixes. * Fixes. * Fixes. * Fixes. * Small fixes. * Removed unused argument. * Fixes. * Small PR fixes. * PR fix. * Small fixes to ensure toggle between pline/bezier connectors and correct pin visibility. * fix breaks * Update RecordedTests.cs * PR fixes. * Connector anchor behaviour implemented. * Added wire hover behaviour (grey outline). Updated 'default' icon behaviour (onhover). * Updates to jive with unit tests. * Bug fix related to pin removal/ watch node placement. * Fixes. Updated pin position/ transform in xaml to achieve correct alignment with GraphLayout routines. * Undo/redo bug fixed. * PR comment fixes. * PR comments fixed. * PR fixes. * PR fixes. * PR fixes. * Unit tests re-added. * Unit tests updated. Co-authored-by: Sylvester Knudsen <[email protected]> * Update DynamoColorsAndBrushes.xaml, which was accidentally tampered with. (DynamoDS#11928) We accidentally deleted some key lines of code having to do with the styling of nodes. * Node visual refresh updates (DynamoDS#11933) * Adjustments made to node height, code block syntax colouring, output port arrows. * Updates UI * Responds to latest feedback from Autodesk Changes path-based icons to PNGs. Updates Code Block syntax highlighting colors and font to monospace. Adds some extra new strings into Resources. Fixes bug where unnamed port that shows output port chevron control could lead to the user being presented with a double-chevron port. DynamoTextBox now has a minimum width set. Slight adjustment to the sizes of various node parts. All node icons should now load successfully. * Code block minor pixel edits Ensuring all code block elements align as they need to. Tested with 200 outputs. * Minor UI fixes * Removing redundant code * Updates some failing tests. Switches .Cast<MenuItem> to .OfType<MenuItem> in many instances. * Removes node informational states icons - these appear in another branch * Responds to PR comments * Node visual refresh updates (DynamoDS#11941) * Adjustments made to node height, code block syntax colouring, output port arrows. * Updates UI * Responds to latest feedback from Autodesk Changes path-based icons to PNGs. Updates Code Block syntax highlighting colors and font to monospace. Adds some extra new strings into Resources. Fixes bug where unnamed port that shows output port chevron control could lead to the user being presented with a double-chevron port. DynamoTextBox now has a minimum width set. Slight adjustment to the sizes of various node parts. All node icons should now load successfully. * Code block minor pixel edits Ensuring all code block elements align as they need to. Tested with 200 outputs. * Minor UI fixes * Removing redundant code * Updates some failing tests. Switches .Cast<MenuItem> to .OfType<MenuItem> in many instances. * Removes node informational states icons - these appear in another branch * Responds to PR comments * Fixes many failing regression tests. Adjusts Artifakt font location. * Update Defect_MAGN_904.xml * Update PortViewModel.cs * Resets command interval in 2 recorded tests. * Same again * Node informational states (#4) (DynamoDS#11910) * Updates node styling * Updates UI Adds Artifakt font, changes colors, port/header height config, code block editor colours. * Update UI * Updates UI * Updates UI * Updates UI * Ports visual states are working. * Revert "Ports visual states are working." * Revert "Revert "Ports visual states are working."" This reverts commit 3557726. * Updates UI * Updates ContextMenu style * Updates UI * Updates UI * Updates ComboBox and Output Ports style for Code Blocks * Loads icon to node header * Updates UI * Updates UI * Updates UI * Bug fixes and responding to comments * Updates UI * WIP changes * ViewModel logic working as per mockup * Node redesign (#3) * Updates node styling * Updates UI Adds Artifakt font, changes colors, port/header height config, code block editor colours. * Update UI * Updates UI * Updates UI * Updates UI * Ports visual states are working. * Revert "Ports visual states are working." * Revert "Revert "Ports visual states are working."" This reverts commit 3557726. * Updates UI * Updates ContextMenu style * Updates UI * Updates UI * Updates ComboBox and Output Ports style for Code Blocks * Loads icon to node header * Updates UI * Updates UI * Updates UI * Bug fixes and responding to comments * DYN-3875: Restore LocalPackages property in PreferencesViewModel (DynamoDS#11881) * restore property in PreferencesViewModel * add regression test for installedpackagesview * fix test * remove setting datacontext for installed packages view control as it is inherited * undo unnecessary changes * more cleanup * Updates UI * fix node autocomplete crash (DynamoDS#11887) * Minor UI changes to Autodesk feedback * Temporarily disabled dismissed alerts features * Minor UI fix to the nodes' GlyphStackPanel Co-authored-by: aparajit-pratap <[email protected]> * Updates * Updates node informational states * Minor fixes * Removed INodeInformationalState interface, no longer needed. * Restored previously-removed commands in InfoBubbleCommand.cs * Typo fix and restoring old NodeInfoBubbleViewModel methods to original state. * Added comments, minor (old) API restoration work * Renaming, refactoring and added 2 tests. * Removed new constructor for OutputMessage. Class is no longer being used for Informational States. * Minor fixes. Removed outdated and unused collection on NodeModel. Changed command name to be less confusing. * Update * Responds to comments * Removed unneeded references * Reponse to comments * Removed 'else' from method body * two more Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> * Wire Behaviour UI fixes (DynamoDS#11946) * Update DynamoColorsAndBrushes.xaml, which was accidentally tampered with. We accidentally deleted some key lines of code having to do with the styling of nodes. * PR fixes. Button rectangular border removed, hover state for polyline connectors disabled, instantiation location of pins fixed. - Button rectangular border removed. - Hover state for polyline connectors disabled. - Instantiation location of pins fixed. - Connector tooltip behaviour to match that of temporary hover icons. * PR fix. * This makes more sense as a static member than a const. * PR fixes. * PR fixes. * PR fixes. * Update UIDispatcher usage (DynamoDS#11951) * Fix the build by adding back missing code (DynamoDS#11952) * Fix two regressions (DynamoDS#11953) * Wire Behaviour UI fixes (DynamoDS#11954) * Wire UI Fixes 1. Made wire tooltip highest ZIndex. 2. Made first line of tooltip bold, the rest is regular 3. Added a clickable item under View-> Connectors to turn tooltip on/off. * Added comments. * Update CommandLineTests.cs (DynamoDS#11955) * Graph Layout regression test fixed. (DynamoDS#11956) * Update ConnectorAnchorView.xaml (DynamoDS#11969) * Remove Extra Files (DynamoDS#11970) * Node visual refresh updates (DynamoDS#11973) * Adjustments made to node height, code block syntax colouring, output port arrows. * Updates UI * Responds to latest feedback from Autodesk Changes path-based icons to PNGs. Updates Code Block syntax highlighting colors and font to monospace. Adds some extra new strings into Resources. Fixes bug where unnamed port that shows output port chevron control could lead to the user being presented with a double-chevron port. DynamoTextBox now has a minimum width set. Slight adjustment to the sizes of various node parts. All node icons should now load successfully. * Code block minor pixel edits Ensuring all code block elements align as they need to. Tested with 200 outputs. * Minor UI fixes * Removing redundant code * Updates some failing tests. Switches .Cast<MenuItem> to .OfType<MenuItem> in many instances. * Removes node informational states icons - these appear in another branch * Responds to PR comments * Fixes many failing regression tests. Adjusts Artifakt font location. * Update Defect_MAGN_904.xml * Update PortViewModel.cs * Resets command interval in 2 recorded tests. * Same again * Fixes bugs and makes requested adjustments Connected Break Connection / Hide Wires to Commands. Added a tick for Context Menu items like 'Hidden' / 'Frozen' Fixed Integer / Number slider visual input bug Fixed Node Context Menu double separator bug Fixed ToolTip spacing Fixed Node Preview / Hidden eye icon not showing up bug Adjusted Connector colour when selected to be same blue as node selection border. Adjusted port names color to be same as node header Adjusted Port default value marker to be same blue as port is connected border color Adjusted node default icon to new icon from Jingyi Fixed Code block 'Enter code here' vertical alignment Adjusted AvalonEdit line numbers to fade them out a bit more * Fixes bugs and makes requested adjustments Connected Break Connection / Hide Wires to Commands. Added a tick for Context Menu items like 'Hidden' / 'Frozen' Fixed Integer / Number slider visual input bug Fixed Node Context Menu double separator bug Fixed ToolTip spacing Fixed Node Preview / Hidden eye icon not showing up bug Adjusted Connector colour when selected to be same blue as node selection border. Adjusted port names color to be same as node header Adjusted Port default value marker to be same blue as port is connected border color Adjusted node default icon to new icon from Jingyi Fixed Code block 'Enter code here' vertical alignment Adjusted AvalonEdit line numbers to fade them out a bit more * Node visual refresh updates (DynamoDS#11977) * Adjustments made to node height, code block syntax colouring, output port arrows. * Updates UI * Responds to latest feedback from Autodesk Changes path-based icons to PNGs. Updates Code Block syntax highlighting colors and font to monospace. Adds some extra new strings into Resources. Fixes bug where unnamed port that shows output port chevron control could lead to the user being presented with a double-chevron port. DynamoTextBox now has a minimum width set. Slight adjustment to the sizes of various node parts. All node icons should now load successfully. * Code block minor pixel edits Ensuring all code block elements align as they need to. Tested with 200 outputs. * Minor UI fixes * Removing redundant code * Updates some failing tests. Switches .Cast<MenuItem> to .OfType<MenuItem> in many instances. * Removes node informational states icons - these appear in another branch * Responds to PR comments * Fixes many failing regression tests. Adjusts Artifakt font location. * Update Defect_MAGN_904.xml * Update PortViewModel.cs * Resets command interval in 2 recorded tests. * Same again * Fixes bugs and makes requested adjustments Connected Break Connection / Hide Wires to Commands. Added a tick for Context Menu items like 'Hidden' / 'Frozen' Fixed Integer / Number slider visual input bug Fixed Node Context Menu double separator bug Fixed ToolTip spacing Fixed Node Preview / Hidden eye icon not showing up bug Adjusted Connector colour when selected to be same blue as node selection border. Adjusted port names color to be same as node header Adjusted Port default value marker to be same blue as port is connected border color Adjusted node default icon to new icon from Jingyi Fixed Code block 'Enter code here' vertical alignment Adjusted AvalonEdit line numbers to fade them out a bit more * Fixes bugs and makes requested adjustments Connected Break Connection / Hide Wires to Commands. Added a tick for Context Menu items like 'Hidden' / 'Frozen' Fixed Integer / Number slider visual input bug Fixed Node Context Menu double separator bug Fixed ToolTip spacing Fixed Node Preview / Hidden eye icon not showing up bug Adjusted Connector colour when selected to be same blue as node selection border. Adjusted port names color to be same as node header Adjusted Port default value marker to be same blue as port is connected border color Adjusted node default icon to new icon from Jingyi Fixed Code block 'Enter code here' vertical alignment Adjusted AvalonEdit line numbers to fade them out a bit more * Reponse to comments * Group improvements to the graph view (DynamoDS#11912) * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Group improvements unit tests (DynamoDS#29) * WIP * view model tests * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Update SerializationTests.cs * Update SerializationTests.cs * comment updates * comment updates * fix GetOutputPorts errors * fix serialization * Update WorkspaceModel.cs * remove grid style (not needed anymore) * Remove BelongsToGroup property from ModelBase * Update AnnotationViewModel.cs * fix setting the graph to have unsaved changes on graph open * disable drag and drop on collapsed groups * fix spelling mistake * Node informational states (DynamoDS#11983) * Updates node styling * Updates UI Adds Artifakt font, changes colors, port/header height config, code block editor colours. * Update UI * Updates UI * Updates UI * Updates UI * Ports visual states are working. * Revert "Ports visual states are working." * Revert "Revert "Ports visual states are working."" This reverts commit 3557726. * Updates UI * Updates ContextMenu style * Updates UI * Updates UI * Updates ComboBox and Output Ports style for Code Blocks * Loads icon to node header * Updates UI * Updates UI * Updates UI * Bug fixes and responding to comments * Updates UI * WIP changes * ViewModel logic working as per mockup * Node redesign (#3) * Updates node styling * Updates UI Adds Artifakt font, changes colors, port/header height config, code block editor colours. * Update UI * Updates UI * Updates UI * Updates UI * Ports visual states are working. * Revert "Ports visual states are working." * Revert "Revert "Ports visual states are working."" This reverts commit 3557726. * Updates UI * Updates ContextMenu style * Updates UI * Updates UI * Updates ComboBox and Output Ports style for Code Blocks * Loads icon to node header * Updates UI * Updates UI * Updates UI * Bug fixes and responding to comments * DYN-3875: Restore LocalPackages property in PreferencesViewModel (DynamoDS#11881) * restore property in PreferencesViewModel * add regression test for installedpackagesview * fix test * remove setting datacontext for installed packages view control as it is inherited * undo unnecessary changes * more cleanup * Updates UI * fix node autocomplete crash (DynamoDS#11887) * Minor UI changes to Autodesk feedback * Temporarily disabled dismissed alerts features * Minor UI fix to the nodes' GlyphStackPanel Co-authored-by: aparajit-pratap <[email protected]> * Updates * Updates node informational states * Minor fixes * Removed INodeInformationalState interface, no longer needed. * Restored previously-removed commands in InfoBubbleCommand.cs * Typo fix and restoring old NodeInfoBubbleViewModel methods to original state. * Added comments, minor (old) API restoration work * Renaming, refactoring and added 2 tests. * Removed new constructor for OutputMessage. Class is no longer being used for Informational States. * Minor fixes. Removed outdated and unused collection on NodeModel. Changed command name to be less confusing. * Update * Responds to comments * Removed unneeded references * Reponse to comments * Removed 'else' from method body * two more * Fixes UI bug * Switched out vector-based info/warning/error icons for .png equivalents. * Removes reference to WindowsBase in DynamoCore and flags many properties in the InfoBubbleViewModel as obsolete. * Updates * Minor graphical updates * Updates in response to feedback Adds new resource strings. Adds a ToolTip for the node context menu. Makes node context menu visible for all nodes. Fixes error bubble Z Index issue. Adds chevron to error bubble design. Unsubscribes from NodeMessages.CollectionChanged on InfoBubbleViewModel's Dispose method. Co-authored-by: aparajit-pratap <[email protected]> * Code Cleanup (DynamoDS#11984) * Code Cleanup * Call Dispose() on ConnectorAnchorViewModel * Node redesign timeouts (DynamoDS#11986) * Code Cleanup * Call Dispose() on ConnectorAnchorViewModel * unsub collection change * formatting fix broken path to pin icon * revert schema change * revert schema change in serialization as well * actually dispose annotationviewmodels Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: michael kirschner <[email protected]> * Connector View Model Dispose (DynamoDS#11991) * ConnectorViewModel dispose * More Dispose spots * Revert Node States Changes * Fix build * Initial Commit * UI Fix Co-authored-by: Ollie Green <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Jorgen Dahl <[email protected]> Co-authored-by: Martin Stacey <[email protected]> Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Sol Amour <[email protected]> Co-authored-by: Marco Juliani <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: michael kirschner <[email protected]>
* Re-added refs. * Updated reference calls. * PR fixes. * PR fixes. * PR fixes.
* bug fix size of background * Remove deconstructor * Bug fix background Rect * Setting Z index to 0 to the elements * Hide libraryview when reaches step 2 * Adding some comments * Uncommenting code * PR comments fixes * Checks if the guided tour already started * Resolving unit test issue * code refactor
* Responds to feedback * Fixes bugs * Fixes Test PythonNodeHasLabelDisplayingCurrentEngine
* Fixed crash as a result of frozen node + pin. -Also added `HasUnsavedChanges * PR fix.
* filtering UI Implementation
Removes hard-coded tooltip left over from previous debugging exercise (sorry!).
* Group improvements to the graph view (DynamoDS#11912) * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Group improvements unit tests (DynamoDS#29) * WIP * view model tests * initial commit * wip * clean up * remove leftovers * UndoRedo behaviour + grouped groups cut out + general fixes * update images * fix CopyPaste + few minor bugs * minor clean ups * Update SerializationTests.cs * Update SerializationTests.cs * comment updates * comment updates * fix GetOutputPorts errors * fix serialization * Update WorkspaceModel.cs * remove grid style (not needed anymore) * Remove BelongsToGroup property from ModelBase * Update AnnotationViewModel.cs * fix setting the graph to have unsaved changes on graph open * disable drag and drop on collapsed groups * fix spelling mistake * Node redesign timeouts (DynamoDS#11986) * Code Cleanup * Call Dispose() on ConnectorAnchorViewModel * unsub collection change * formatting fix broken path to pin icon * revert schema change * revert schema change in serialization as well * actually dispose annotationviewmodels Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: michael kirschner <[email protected]> * [DYN-3975] Fix non clickable textboxes (DynamoDS#12007) * Fix non clickable textboxes * use nameof * Update AnnotationViewTests.cs * Change output port background (DynamoDS#12017) * SelectAll after node has been dragged into group (DynamoDS#12010) * Remove ProxyPortModel creation (DynamoDS#12008) * Update AnnotationView.xaml (DynamoDS#12022) * code clean up Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: michael kirschner <[email protected]>
* Fixed crash as a result of frozen node + pin. -Also added `HasUnsavedChanges * PR fix. * Undo/redo implemented for 'BreakConnector' command. * Undo/redo fixed for `break connector` and `hide/show connector`. Also `IsVisible` is now serialized as a connector property so that the visibility state of connectors in the graph are saved properly. * Added updated `ConnectorPinTests.dyn` test file. * Unit tests updated. * PR fixes. * Regression fixes. -Renamed `IsVisible` to `IsDisplayed` and `IsPartlyVisible` o `IsTemporarilyDisplayed` -Corrected deserialization to account for legacy graphs where connectors dont have the `IsDisplayed` property serialized. * Regression fixes. * Regression fix.
…amoDS#12026) * Fixed crash as a result of frozen node + pin. -Also added `HasUnsavedChanges * PR fix. * Undo/redo implemented for 'BreakConnector' command. * Undo/redo fixed for `break connector` and `hide/show connector`. Also `IsVisible` is now serialized as a connector property so that the visibility state of connectors in the graph are saved properly. * Added updated `ConnectorPinTests.dyn` test file. * Unit tests updated. * PR fixes. * Regression fixes. -Renamed `IsVisible` to `IsDisplayed` and `IsPartlyVisible` o `IsTemporarilyDisplayed` -Corrected deserialization to account for legacy graphs where connectors dont have the `IsDisplayed` property serialized. * Regression fixes. * First commit. * First commit. * Clarifying logic. * PR fix. > > @M-JULIANI Oops now this PR is no longer clean since some changes are already in master 😉 If you plan to make another PR you can either cherry-pick your changes there or fix this one > > @QilongTang cool just resolved those conflicts.. Now we wait for it to build 😉 Thanks!
* fix string format arguments
…#12025) * Add menu item to preference panel * Update PreviewBubbleTests.cs * comments
DynamoDS#12031) * Minor bug fixes related to the behavio of the popup when the window is moved or resized * setting properties to internal
…ructors as well (DynamoDS#12032) * isvisibleattribute now honored for ZT constructors as well * update tests to fix test failures * review comments
…alidate function definitions on opening new workspace (DynamoDS#12002) * reset library management core on opening new workspace * do not log function not found warnings during precompilation of CBNs * revert unchanged file * precompile all function definition ASTs first * tie loose ends * refactor CBN constructors * more refactoring * corrections - cbns need to be compiled as soon as they're being deserialized * cleanup * more cleanup * rename method * add missing code comments * final fixes * set CBN first pass compilation flags at the right place * undefine function definitions on closing/opening new workspace * mark all function defs inactive * add tests, fix workspace changed regression * more tests * review comments
…DS#12036) * add icons for new nodes * fixes * update libg nugets * update test
* Fix duplicate nodes
* split download and install into 2 methods, one that is async and one that is sync so we can control install order. * make methods virtual for mocking add access to internal methods for mocks add test * add test for installPackage method with error download * review comments * add comments Co-authored-by: michael kirschner <[email protected]>
…ynamoDS#12039) * Fixes. * Fix. * PR fix.
…rl key pressed. (DynamoDS#12040) * Fixes. * Fix. * Added checks to prevent connectorPin from being pasted from Clipboard. * PR fix. * Fix.
…oDS#12038) * disable horizontal scroll * Disable drag and select instead of horizontal scroll
…ViewModel to work with `IsCollapsed` from groups (DynamoDS#12041) * Fixes. * Fix. * Added checks to prevent connectorPin from being pasted from Clipboard. * `IsVisible` switched for inverse `IsCollapsible` in ConnetorModel and related classes... Many repercussions... * PR fixes.
…DynamoDS#12042) * Fix node note crsh bug * correct event unsubscribe
…licts (DynamoDS#12239) * initial commit * add new resource strings for message boxes * build fix * minor fix * more fixes * add cases where package to download conflicts by itself * add tests * review comments * review comments * add clarifying message
DynamoDS#12249) * Do not hide the package delete command * Add additional tooltop for delete/unload package command. * Hide delete/unload when a operation is scheduled. * Fix comment * More comment fixes * Address review comments. * Simplify logic
* Updates groups context menu style * Update AnnotationView.xaml * Update AnnotationView.xaml * Update AnnotationView.xaml
* Update PULL_REQUEST_TEMPLATE.md and adding new github action PR_merged
* Adjust hight of the step 2 * Update dynamo_guides.json
* Creating pointer pointing down * Adjusting Height/Width values
* Text wrapping enabled * Remove extra space
* DYN-4241-Step6-PackageDependencies I added the Step 6 to the packages guide, the automation needed for opening the PackageDetaiils and adding support for showing the PackageDetails User Control over the dark overlay. The highlight and cutoff functionality was moved from the Guide class to the Step class, so it will be executed on Step.Show(), Step.Hide() or when exiting the Guide. Also I modified resources for the Package Details popup and remove the resource for the "Autodesk Sample Package" due that it shouldn't be localized. I added some code to subscribe the "Search for a Package" menuitem Click event to the NextStep method. I disable the Back button in the Step1 due that was closing all the Steps and leaving the dark overlay. Finally I added some methods for closing the PackageSearch window * DYN-4241-Step6-PackageDependencies Code Review Some comments were updated.
saintentropy
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Python editor visual restyle - initial commit - initial commit for python editor visual restyle - for general idea of the desired scope, visit https://www.figma.com/file/1q7EWQGYO7pPDhyLf8nuwW/Python-node-editor-restyling?node-id=0%3A1&t=QGCSTKllX8Q7OnhK-0 * Icon Update - updated python scrip editor icons * Hover icon update - minor update for one of the icons * Change hyperlink color - due to readability issues, changed the hyperlink text color * Text Folding - first implementation working * Custom indentation strategy added - added custom Python indentation strategy based around line ending with a column * TabFoldingStrategy changes, saves on Esc exist, WIP - WIP code, still playing with the avalon editor visual capabilities - Implemented the 'save on exit' (still missing prompt) - Folding strategy works more or less correctly, except we are not tracking folded states (which we can) - more work needed, but should we? * Undo/Redo, Zoom-in/out buttons added - added buttons for the undo/redo and zoom-in/out functionalities * Keywords color update - updated keywords as per latest Figma color scheme * Warning bar on unsaved changes exit added - added a warning message with controls when user tries to exit the Script interface by pressing the Escape button, but has unsaved changes - made Avalon edit support classes Internal * Fix tab folding - now will correctly continue after ":" not being the end of the text line (no tabbing) * Small icons test - testing screen resolution against 24x24 icons * Back to 48x48 icons - updated icons back to 48x48px * Disable UI when prompt to save changes - will disable any user interaction while in 'warning' mode - forces the user to `keep editing` -> `save` -> `close` * Color brushes replaced with Dynamo brushes where possible - re[placed with dynamo library brushes where possible * Localized unsaved changes prompt texts - unsaved changes prompt title and text localized * Cleaned up tabfoldingstrategy comments - removed old or unnecessary comments - kept comments that help to clarify the logic * Update ScriptEditorWindow.xaml
saintentropy
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Python editor visual restyle - initial commit - initial commit for python editor visual restyle - for general idea of the desired scope, visit https://www.figma.com/file/1q7EWQGYO7pPDhyLf8nuwW/Python-node-editor-restyling?node-id=0%3A1&t=QGCSTKllX8Q7OnhK-0 * Icon Update - updated python scrip editor icons * Hover icon update - minor update for one of the icons * Change hyperlink color - due to readability issues, changed the hyperlink text color * Text Folding - first implementation working * Custom indentation strategy added - added custom Python indentation strategy based around line ending with a column * TabFoldingStrategy changes, saves on Esc exist, WIP - WIP code, still playing with the avalon editor visual capabilities - Implemented the 'save on exit' (still missing prompt) - Folding strategy works more or less correctly, except we are not tracking folded states (which we can) - more work needed, but should we? * Undo/Redo, Zoom-in/out buttons added - added buttons for the undo/redo and zoom-in/out functionalities * Keywords color update - updated keywords as per latest Figma color scheme * Warning bar on unsaved changes exit added - added a warning message with controls when user tries to exit the Script interface by pressing the Escape button, but has unsaved changes - made Avalon edit support classes Internal * Fix tab folding - now will correctly continue after ":" not being the end of the text line (no tabbing) * Small icons test - testing screen resolution against 24x24 icons * Back to 48x48 icons - updated icons back to 48x48px * Disable UI when prompt to save changes - will disable any user interaction while in 'warning' mode - forces the user to `keep editing` -> `save` -> `close` * Color brushes replaced with Dynamo brushes where possible - re[placed with dynamo library brushes where possible * Localized unsaved changes prompt texts - unsaved changes prompt title and text localized * Cleaned up tabfoldingstrategy comments - removed old or unnecessary comments - kept comments that help to clarify the logic * Update ScriptEditorWindow.xaml
saintentropy
pushed a commit
that referenced
this pull request
Jun 22, 2023
…vent (DynamoDS#14007) * Create dynamoBinDiff.yml * update nuget step * add bin diff job script * add cache test * fixing cache * test * fixing cache #2 * fixing cache #3 * fixing cache #4 * debug * debug * debug * debug * fixed cache * cleanup step * test cleanup * final version * Update bin_diff.ps1 * remove cleanup step, because failing * add colors * Change hashing algo to SHA256 * add net6 win for bin diff * fix * only status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR includes the scope of work outlined in GD Q2 for Unit Nodes.
Description
This PR includes the scope of work outlined in GD Q2 for Unit Nodes. It includes all nodes in the Units/Units UI project. Most of the functionality of these nodes wraps the Forge Units API.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@saintentropy
FYIs