DYN-4117: Delete Button missing from Package Manager preferences panel #12249
Conversation
sm6srw
changed the title
|
Thank you for restoring it, I love this function! |
| && Model.LoadState.ScheduledState != PackageLoadState.ScheduledTypes.ScheduledForDeletion | ||
| && !CanUninstall()) | ||
| { | ||
| return Resources.PackageContextMenuDeletePackageCustomNodesInUseTooltip; |
There was a problem hiding this comment.
@sm6srw By custom nodes ...do you mean non-built-in ? or custom node definitions ?
There was a problem hiding this comment.
Custom Node definitions
There was a problem hiding this comment.
Hmm..I do not see any specific checks for custom node defs...is that the only possibility?...what about packages with loaded assemblies...
There was a problem hiding this comment.
The check is in CanUnInstall(). It is a little strange because we say that a package can always be uninstalled if the package has a loaded assembly. But it can not be uninstalled if it has custom nodes that are in use. We missed that case. What I think is missing is to do the same thing for all packages (allow or not allow). But that is future work. For now we just try to clarify this a bit.
| public bool LoadedWithNoScheduledOperation | ||
| { | ||
| get | ||
| { | ||
| return Model.BuiltInPackage ? | ||
| Model.LoadState.State != PackageLoadState.StateTypes.Unloaded && | ||
| Model.LoadState.ScheduledState != PackageLoadState.ScheduledTypes.ScheduledForUnload : | ||
| Model.LoadState.ScheduledState != PackageLoadState.ScheduledTypes.ScheduledForDeletion; | ||
| } | ||
| } |
There was a problem hiding this comment.
How is this condition different from simply checking Model.LoadState.State == PackageLoadState.StateTypes.Loaded?
There was a problem hiding this comment.
I am not 100% sure why we can't check for Loaded only but I think it has to do with packages in an error state. I just followed the existing pattern and made a property of it so I can use it here and for viability control in the xaml file.
| if (Model.LoadState.State != PackageLoadState.StateTypes.Unloaded | ||
| && Model.LoadState.ScheduledState != PackageLoadState.ScheduledTypes.ScheduledForDeletion |
There was a problem hiding this comment.
How about just checking for if(!CanUininstall())?
There was a problem hiding this comment.
Thanks, that should work I think. The control will be hidden in those cases when this matter. I will give it a try.
Purpose
This pull request does:
Declaration
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhacement. Mandatory section