Groups Context Menu Visual Refresh

[OliverEGreen]

Purpose

This PR updates the context menu on groups (AnnotationView) to the new visual refresh style.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated

Release Notes

Updates the styling of the group context menu.

Reviewers

@QilongTang
@Amoursol

FYIs

@shk

[reddyashish]

Looks good to me.

[QilongTang]

question: do we repeat a lot of the following style definitions?

[OliverEGreen]

You mean the MenuItem style?
We do; this is something I've struggled with.
Because our Menus contain MenuItems, but also Separators (and sometimes other things too, e.g. the Node Group Color ItemCollections), we get an exception when setting the ItemContainerStyle property.

The workaround is to have the styles passively sitting around in a ContextMenu.Resources scope, being applied when the correct Type is found. That's what we do currently. However, I have issues when trying to define a ContextMenu.Resources scope inside of a ResourceDictionary. So while we can set a global ContextMenu Style just fine, we can't do the same for ContextMenuItems. It would be great if we could - could clean up a lot of code!

[QilongTang]

Thank you for the reasoning, glad this has been considered

[OliverEGreen]

I just slimmed down the context menu by 40 pixels, there was a lot of empty space hanging around for no reason.