Resize Nodes #12009
Merged
Resize Nodes #12009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check regression |
QilongTang
reviewed
Sep 3, 2021
QilongTang
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
@OliverEGreen Thanks! LGTM and will merge once all checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new node design has been upated to take up less space on the graph.
This PR is mostly adjustments made to height, paddings and margins.
A new, smaller node context menu icon has been switched out for the old one.
Each node's context menu can now display a column of checkboxes, if IsCheckable is set to true.
The original right/left click functionality has been restored to nodes at the zoomed-out level (right click opens context menu, left clicks selects and drags).
The main adjustment made to the nodes is that the PresentationGrid now lives centrally, and occupies a single layout column on the NodeView. This mostly affects nodes like the Watch and Watch3D nodes. These also now have an updated resize control.
This PR addresses issues:
[DYN-4014] https://jira.autodesk.com/projects/DYN/issues/DYN-4014
[DYN-3961] https://jira.autodesk.com/projects/DYN/issues/DYN-3961
[DYN-4032] https://jira.autodesk.com/projects/DYN/issues/DYN-4032
[DYN-3936] https://jira.autodesk.com/projects/DYN/issues/DYN-3936
[DYN-3937] https://jira.autodesk.com/projects/DYN/issues/DYN-3937