Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Jira issues: [DYN-3890] | [DYN-3963] #12015

Merged

Conversation

M-JULIANI
Copy link
Contributor

@M-JULIANI M-JULIANI commented Sep 5, 2021

Description

This PR addresses and fixes the following Jira issues:

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@SHKnudsen

-Also added `HasUnsavedChanges
@M-JULIANI M-JULIANI changed the title PR - Jira issues: [DYN-3890] | [DYN-3961] PR - Jira issues: [DYN-3890] | [DYN-3963] Sep 6, 2021
@QilongTang
Copy link
Contributor

@QilongTang QilongTang merged commit bd5e1a6 into DynamoDS:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants