Adding a GitHub action to perform a Binary Diff job on each PR/push event #14007
Conversation
zeusongit
changed the title
| @@ -0,0 +1,258 @@ | |||
| ################################################################################ | |||
There was a problem hiding this comment.
is this script based on some sample code? Did it have a license, can we link to it?
.github/scripts/bin_diff.ps1
Outdated
| [string]$Path, | ||
|
|
||
| [parameter(HelpMessage="The hash algorithm to use.")] | ||
| [string]$Algorithm="MD5" |
There was a problem hiding this comment.
| if($Compare.length -ne 2) { | ||
| Print -x "Compare requires passing exactly 2 path parameters separated by comma, you passed $($Compare.length)." -f | ||
| } | ||
| Print "Comparing $($Compare[0]) to $($Compare[1])..." -a 1 |
There was a problem hiding this comment.
so I have a bit of a hard time understanding how this code works - but from your screenshot I have a few questions/comments.
- I think noting that a file is
modifiedif it still exists is probably just noise - IMO we don't really care, I expect files to be different when I do a build - they will contain different version numbers etc. - What I really care about are new files and deleted files - if we need to keep
modifiedfiles - can we make deleted and added files pop out some how? (color text?) - Is a deleted file also considered modified or does it have a separate state? Can you show a screenshot of this?
There was a problem hiding this comment.
- Agreed, do you suggest removing modified entries? I think we can let them be.
- I have added colors to make them pop, green for Added, and red for Deleted entries.
- Yes, deleted files has a separate "Deleted" label. attaching ss below.
There was a problem hiding this comment.
removed hash and side indicator columns as they were not useful.
| build-current: | ||
| runs-on: windows-2022 | ||
| steps: | ||
| - name: Checkout Dynamo Repo current branch |
There was a problem hiding this comment.
I have a complication for you - we also need to do this same comparison for the DynamoAll.Net6.Sln targeting windows.
Would you prefer to just duplicate this action for net6 or have this job do 4 builds?
There was a problem hiding this comment.
Added 2 more builds for Net6-Windows (parallel builds for quick results)
|
@mjkkirschner I don't think the coloring worked in Github Action console logs, but it did work in powershell. |
Purpose
Add a binary diff workflow that will run on each push and PR, this will enable devs to check for updated files (Added, Deleted or Modified) in their PR vs files on the master branch.
Note: caches will be removed automatically after 7 days.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Add Bin Diff support on PRs
Reviewers
@DynamoDS/dynamo