DYN-4241-Step6-PackageDependencies #12277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the Step 6 to the packages guide, the automation needed for opening the PackageDetaiils and adding support for showing the PackageDetails User Control over the dark overlay. The highlight and cutoff functionality was moved from the Guide class to the Step class, so it will be executed on Step.Show(), Step.Hide() or when exiting the Guide. Also I modified resources for the Package Details popup and remove the resource for the "Autodesk Sample Package" due that it shouldn't be localized. I added some code to subscribe the "Search for a Package" menuitem Click event to the NextStep method. I disable the Back button in the Step1 due that was closing all the Steps and leaving the dark overlay. Finally I added some methods for closing the PackageSearch window
|
This is how the Packages guide looks until Step6 (Package Dependencies) |
QilongTang
reviewed
Nov 12, 2021
| if (packageManagerViewModel == null) | ||
| return; | ||
|
|
||
| //Due that we need to search the Autodesk Sample package after the inicial search is completed |
There was a problem hiding this comment.
@QilongTang fixed in the next commit:
7b9f128
QilongTang
reviewed
Nov 12, 2021
| /// <summary> | ||
| /// This method will set the highlight rectangle color if there is any configured in the json file | ||
| /// </summary> | ||
| /// <param name="bVisible">It will say it the Highlight Area will be disabled or enable</param> |
There was a problem hiding this comment.
if the Highlight Area will be disabled or enable? Please update
There was a problem hiding this comment.
@QilongTang fixed in the next commit:
7b9f128
QilongTang
reviewed
Nov 12, 2021
| /// <summary> | ||
| /// This method will update the CutOff rectangle size everytime that the step change | ||
| /// </summary> | ||
| /// <param name="bVisible">It will say it the CutOff Area will be disabled or enable</param> |
There was a problem hiding this comment.
@QilongTang fixed in the next commit:
7b9f128
Some comments were updated.
QilongTang
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I added the Step 6 to the packages guide, the automation needed for opening the PackageDetaiils and adding support for showing the PackageDetails User Control over the dark overlay.
Basically I did the next changes:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Adding the Step 6 (package dependencies) to the Packages Guide
Reviewers
@QilongTang
FYIs
@filipeotero