Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Jira Issues: [DYN-4095] Cleanup layout rearranges pin and node #12039

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

M-JULIANI
Copy link
Contributor

@M-JULIANI M-JULIANI commented Sep 15, 2021

Description

Fixes a previous bug visible when running Cleanup Layout. When selecting a single node and running the command multiple
times, any connector pin in the graph moved upwards.

Fixed behaviour:
WireIssueFix-CleanLayoutPin

This PR also adds a HasUnsavedChanges flag when calling BreakConnection from a port.

Fixed behaviour:
WireIssueFix-UndoFlagAddedToBreakConnection-FromPort

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@SHKnudsen
@Amoursol

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@QilongTang QilongTang merged commit 1c6f72e into DynamoDS:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants