[RELEASE] cudf v23.04 #13038
Merged
[RELEASE] cudf v23.04 #13038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[gpuCI] Forward-merge branch-23.02 to branch-23.04 [skip gpuci]
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Update JNI version to 23.04.0-SNAPSHOT Authors: - Peixin (https://github.com/pxLi) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #12599
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
Found when debugging some CI build failures where the `SegmentedSortInt.Bool` gtest failure occurred. This was caused by an improperly applied code patch to the CUB source dependency. The link between the CUB patch and this gtest is not common knowledge and could've taken much time to diagnose otherwise. This PR adds a simple comment to provide the appropriate context in case the error occurs again and then the test case is investigated. Reference #12234 where the patch was applied. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Yunsong Wang (https://github.com/PointKernel) URL: #12611
Forward-merge branch-23.02 to branch-23.04
Forward-merge branch-23.02 to branch-23.04
This makes the java APIs for RMM more closely match the C++ APIs. Authors: - Robert (Bobby) Evans (https://github.com/revans2) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #12632
Ensure we pin `cuda-nvrtc` the same way as `cuda-nvrtc-dev`. This is necessary to avoid pulling a newer `cuda-nvrtc` at build time. The `-dev` package is pinned to `cuda-nvrtc >= (dev version)` but we want the pinnings of both packages to be the same, and not let `cuda-nvrtc` float ahead. Authors: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #12606
Forward-merge branch-23.02 to branch-23.04
Removes unneeded calls to `cudf::test::print` and `std::printf` in libcudf gtests source code. Some of these were found in the build log while diagnosing a CI build failure. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Vyas Ramasubramani (https://github.com/vyasr) URL: #12604
Fixes a bug found in the gtests `AllocateLikeTest.ColumnNumericTestSameSize` and `AllocateLikeTest.ColumnNumericTestSpecifiedSize` where uninitialized column null-masks are used to verify null-counts. This error was found by running the following in the libcudf build directory: ``` gtests/COPYING_TEST --rmm_mode=cuda ``` The `AllocateLikeTest` tests `cudf::allocate_like()` which produces an uninitialized fixed-width column which is usually filled in by internal functions. The uninitialized column data includes its null-mask. The gtest uses `CUDF_TEST_EXPECT_COLUMN_PROPERTIES_EQUAL` to verify the column returned by `allocate_like()` which also includes the `null_count()`. The null-count property returned by `allocate_like()` sets the null-count to `UNKNOWN_NULL_COUNT` which causes a future call to `null_count()` to calculate the count by reading the bits in the null-mask. Since the null-mask is uninitialized (garbage), the null-count would be invalid and likely not match any predictable value. The gtests are updated to check for appropriate column properties excluding the null-count. While debugging this issue, the `allocate_like()` logic was found to also attempt to build child columns incorrectly assuming the children will contain the same size and null-mask. Since the `allocate_like()` only supports fixed-width types which do not have children, this logic was removed. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Vyas Ramasubramani (https://github.com/vyasr) URL: #12643
Forward-merge branch-23.02 to branch-23.04
Fixes a subtle bug in `CudfEngine.read_partition`, and removes stale code in `test_parquet.py`. One motivation for this PR is to avoid CI failures if/when dask/dask#9637 is merged in upstream Dask. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #12663
Fixes: #12648 This PR fixes an error in the `round` API when a bool column is present. The changes include cleaning up the pytest. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - https://github.com/brandon-b-miller - Lawrence Mitchell (https://github.com/wence-) URL: #12670
Fixes: #12463 This PR handles any kind of outdated pandas index metadata in `from_arrow` by ignoring it. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Matthew Roeschke (https://github.com/mroeschke) URL: #12665
GPUtester
requested review from
shwina,
skirui-source,
karthikeyann and
divyegala
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
ci
CMake
ttnghia
approved these changes
Mar 30, 2023
cupy just released version 12, which we do not yet support, so wheels CI must be pinned to require a lower version Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Sevag H (https://github.com/sevagh)
[REVIEW] Pin `dask` and `distributed` for release
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #13038 +/- ##
===========================================
+ Coverage 10.56% 85.47% +74.90%
===========================================
Files 116 152 +36
Lines 18677 24650 +5973
===========================================
+ Hits 1974 21070 +19096
+ Misses 16703 3580 -13123 see 160 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
karthikeyann
approved these changes
Apr 6, 2023
galipremsagar
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-23.04and v23.04 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-23.04until release (merging of this PR).What is the purpose of this PR?
branch-23.04intomainfor the release