Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask-cudf read_parquet bug for multi-file aggregation #12663

Merged
merged 10 commits into from
Feb 2, 2023

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Jan 31, 2023

Description

Fixes a subtle bug in CudfEngine.read_partition, and removes stale code in test_parquet.py.
One motivation for this PR is to avoid CI failures if/when dask/dask#9637 is merged in upstream Dask.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jan 31, 2023
@rjzamora rjzamora requested a review from a team as a code owner January 31, 2023 19:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 31, 2023
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

python/dask_cudf/dask_cudf/io/parquet.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@5b278b1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12663   +/-   ##
===============================================
  Coverage                ?   85.81%           
===============================================
  Files                   ?      158           
  Lines                   ?    25151           
  Branches                ?        0           
===============================================
  Hits                    ?    21584           
  Misses                  ?     3567           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 2, 2023
@rjzamora
Copy link
Member Author

rjzamora commented Feb 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3fa081a into rapidsai:branch-23.04 Feb 2, 2023
@rjzamora rjzamora deleted the fix-multi-file-pq-bug branch February 2, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants