Pay off some JNI RMM API tech debt #12632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
revans2
added
3 - Ready for Review
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #12632 +/- ##
===============================================
Coverage ? 85.82%
===============================================
Files ? 158
Lines ? 25184
Branches ? 0
===============================================
Hits ? 21614
Misses ? 3570
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jlowe
reviewed
Jan 30, 2023
java/src/main/java/ai/rapids/cudf/RmmCudaAsyncMemoryResource.java
Outdated
Show resolved
Hide resolved
java/src/main/java/ai/rapids/cudf/RmmEventHandlerResourceAdaptor.java
Outdated
Show resolved
Hide resolved
java/src/main/java/ai/rapids/cudf/RmmLimitingResourceAdaptor.java
Outdated
Show resolved
Hide resolved
jlowe
approved these changes
Jan 30, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
Fixes a bug introduced here #12632 where the C++ version of the jni call `Rmm.newCudaAsyncMemoryResource` was taking an extra argument (`child`), causing the `threshold` to be set to a random value since the calling code defined the native method has taking 2 longs, not 3. The above can affect performance if the threshold is set to 0 for example. The async pool will reduce its footprint by releasing memory, which means we need to go back and reallocate. This is how I found it. I am starting the build process for this, so it's going to take me a bit to test. Authors: - Alessandro Bellina (https://github.com/abellina) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #12681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert (Bobby) Evans [email protected]
Description
This makes the java APIs for RMM more closely match the C++ APIs.
Checklist