Patch CUB DeviceSegmentedSort and remove workaround #12234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12234 +/- ##
===============================================
Coverage ? 88.17%
===============================================
Files ? 137
Lines ? 22660
Branches ? 0
===============================================
Hits ? 19981
Misses ? 2679
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidwendt
added
3 - Ready for Review
elstehle
approved these changes
Nov 28, 2022
robertmaynard
requested changes
Nov 28, 2022
robertmaynard
approved these changes
Nov 28, 2022
|
@gpucibot merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
Found when debugging some CI build failures where the `SegmentedSortInt.Bool` gtest failure occurred. This was caused by an improperly applied code patch to the CUB source dependency. The link between the CUB patch and this gtest is not common knowledge and could've taken much time to diagnose otherwise. This PR adds a simple comment to provide the appropriate context in case the error occurs again and then the test case is investigated. Reference #12234 where the patch was applied. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Yunsong Wang (https://github.com/PointKernel) URL: #12611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix in CUB DeviceSegmentedSort allows for workaround to removed. The CUB fix is applied as a patch in the libcudf build process.
Reference NVIDIA/cub#594 and #12217
Checklist