-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Handle bool types in round
API
#12670
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #12670 +/- ##
===============================================
Coverage ? 85.82%
===============================================
Files ? 158
Lines ? 25184
Branches ? 0
===============================================
Hits ? 21614
Misses ? 3570
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess I never realized that a rounded bool
column is always just itself :)
Co-authored-by: brandon-b-miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense.
/merge |
Description
Fixes: #12648
This PR fixes an error in the
round
API when a bool column is present. The changes include cleaning up the pytest.Checklist