Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Handle bool types in round API #12670

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #12648

This PR fixes an error in the round API when a bool column is present. The changes include cleaning up the pytest.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Feb 1, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner February 1, 2023 18:05
@galipremsagar galipremsagar self-assigned this Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@6a67e8f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12670   +/-   ##
===============================================
  Coverage                ?   85.82%           
===============================================
  Files                   ?      158           
  Lines                   ?    25184           
  Branches                ?        0           
===============================================
  Hits                    ?    21614           
  Misses                  ?     3570           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess I never realized that a rounded bool column is always just itself :)

Co-authored-by: brandon-b-miller <[email protected]>
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 2, 2023
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3aab6b8 into rapidsai:branch-23.04 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DataFrame.round fails in presence of bool column
3 participants