[gpuCI] Forward-merge branch-23.02 to branch-23.04 [skip gpuci] #12591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues: - A very old issue where we were incorrectly setting the output nesting depth in the PageNestingInfo struct in some cases. Previously, this was benign, but the chunked reader broke because of it. I fixed this and did some variable renaming to make things more clear. - Fixed an issue with an optimization that was added for the chunked reader: We were incorrectly determining when we could early out for a given page during the preprocessing step. There is an issue as far as generating a test for this PR. The conditions under which the second bug occurs require that values from a given row span multiple pages. I couldn't get the cudf writer to make this happen. The alternative is to use a pre-created file and use the python tests, but the issue there is that we don't expose skip_rows/num_rows through that API. So I have no good way of building a test. This fix has been vetted against a known real-world failure case. Fixes #12376 Authors: - https://github.com/nvdbaranec - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Yunsong Wang (https://github.com/PointKernel) URL: #12488
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-23.02that creates a PR to keepbranch-23.04up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.