Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cuda-nvrtc. #12606

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Pin cuda-nvrtc. #12606

merged 3 commits into from
Jan 31, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 24, 2023

Description

Ensure we pin cuda-nvrtc the same way as cuda-nvrtc-dev. This is necessary to avoid pulling a newer cuda-nvrtc at build time. The -dev package is pinned to cuda-nvrtc >= (dev version) but we want the pinnings of both packages to be the same, and not let cuda-nvrtc float ahead.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner January 24, 2023 23:44
@github-actions github-actions bot added the conda label Jan 24, 2023
ajschmidt8
ajschmidt8 previously approved these changes Jan 24, 2023
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@1204a2e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12606   +/-   ##
===============================================
  Coverage                ?   85.82%           
===============================================
  Files                   ?      158           
  Lines                   ?    25184           
  Branches                ?        0           
===============================================
  Hits                    ?    21614           
  Misses                  ?     3570           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice bdice changed the base branch from branch-23.02 to branch-23.04 January 26, 2023 16:56
@bdice bdice dismissed ajschmidt8’s stale review January 26, 2023 16:56

The base branch was changed.

@vyasr vyasr requested a review from ajschmidt8 January 31, 2023 00:02
@vyasr
Copy link
Contributor

vyasr commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6d8a01e into rapidsai:branch-23.04 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants