Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cudf::test::print calls from libcudf gtests #12604

Merged
merged 12 commits into from
Jan 31, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Removes unneeded calls to cudf::test::print and std::printf in libcudf gtests source code.
Some of these were found in the build log while diagnosing a CI build failure.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2023
@davidwendt davidwendt self-assigned this Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@d715ac8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04   #12604   +/-   ##
===============================================
  Coverage                ?   85.82%           
===============================================
  Files                   ?      158           
  Lines                   ?    25184           
  Branches                ?        0           
===============================================
  Hits                    ?    21614           
  Misses                  ?     3570           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 26, 2023
@davidwendt davidwendt marked this pull request as ready for review January 26, 2023 21:12
@davidwendt davidwendt requested a review from a team as a code owner January 26, 2023 21:12
@vyasr
Copy link
Contributor

vyasr commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2b270da into rapidsai:branch-23.04 Jan 31, 2023
@davidwendt davidwendt deleted the remove-print-from-gtests branch January 31, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants