Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invalid action status when receiving unexpected message during invoke/read/subscribe/write #19356

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Jun 9, 2022

Problem

Based upon IM spec,
we need to send invalid action status when receiving unexpected message during invoke/read/subscribe/write. and process this status in other side accordingly.
Fix: #8030

Change overview

see above

Testing

The existing tests covers the happy paths.
Add new tests covers the negative paths.

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

PR #19356: Size comparison from 57cb679 to c079ae4

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 57cb679 c079ae4 change % change
bl602 lighting-app bl602 (read/write) 1397386 1397874 488 0.0
.text 1058588 1058896 308 0.0
bl602+rpc (read/write) 1442818 1443298 480 0.0
.text 1090276 1090576 300 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666275 666411 136 0.0
.rodata 88139 88147 8 0.0
.text 577820 577948 128 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632083 632219 136 0.0
.rodata 77379 77387 8 0.0
.text 554380 554508 128 0.0
lock-ftd LP_CC2652R7 (read only) 669183 669383 200 0.0
.rodata 76279 76295 16 0.0
.text 592424 592608 184 0.0
lock-mtd LP_CC2652R7 (read only) 618591 618791 200 0.0
.rodata 76159 76175 16 0.0
.text 541944 542128 184 0.0
pump-app LP_CC2652R7 (read only) 678183 678567 384 0.1
.rodata 88503 88687 184 0.2
.text 589196 589396 200 0.0
pump-controller-app LP_CC2652R7 (read only) 664007 664399 392 0.1
.rodata 84367 84559 192 0.2
.text 579160 579360 200 0.0
shell LP_CC2652R7 (read only) 658766 658918 152 0.0
.rodata 84918 84934 16 0.0
.text 573532 573668 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579822 200 0.0
.app_xip_area 458376 458576 200 0.0
lock cyw930739m2evb_01 (read/write) 585574 585774 200 0.0
.app_xip_area 459600 459800 200 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582774 583134 360 0.1
.app_xip_area 462376 462736 360 0.1
efr32 lighting-app BRD4161A (read/write) 1081436 1081900 464 0.0
.text 946372 946836 464 0.0
BRD4161A+rpc (read/write) 1135764 1136236 472 0.0
.text 983808 984280 472 0.0
BRD4161A+rs911x (read/write) 947924 948388 464 0.0
.text 805088 805552 464 0.1
lock-app BRD4161A+wf200 (read/write) 1128848 1129240 392 0.0
.text 982580 982972 392 0.0
window-app BRD4161A (read/write) 1075244 1075708 464 0.0
.text 938676 939140 464 0.0
esp32 all-clusters-app c3devkit (read only) 1020100 1020332 232 0.0
(read/write) 1485642 1485826 184 0.0
.flash.rodata 215528 215712 184 0.1
.flash.text 1020100 1020332 232 0.0
m5stack (read only) 1073971 1074151 180 0.0
(read/write) 487712 487888 176 0.0
.flash.rodata 245972 246148 176 0.1
.flash.text 1068587 1068767 180 0.0
k32w light k32w061+release (read/write) 658832 658976 144 0.0
.text 581524 581668 144 0.0
lock k32w061+release (read/write) 685684 685828 144 0.0
.text 607900 608044 144 0.0
linux all-clusters-app debug (read only) 2960825 2962073 1248 0.0
(read/write) 154752 154784 32 0.0
.data.rel.ro 84968 85000 32 0.0
.rodata 263613 263805 192 0.1
.text 2520002 2520962 960 0.0
all-clusters-minimal-app debug (read only) 2813401 2814649 1248 0.0
(read/write) 146688 146720 32 0.0
.data.rel.ro 77608 77640 32 0.0
.rodata 265341 265533 192 0.1
.text 2373026 2373986 960 0.0
bridge-app debug+rpc (read only) 2315449 2316377 928 0.0
(read/write) 125504 125536 32 0.0
.data.rel.ro 66984 67016 32 0.0
.rodata 198016 198176 160 0.1
.text 1955698 1956370 672 0.0
chip-tool debug (read only) 10345025 10346913 1888 0.0
(read/write) 622240 622272 32 0.0
.data.rel.ro 587888 587920 32 0.0
.rodata 515861 516021 160 0.0
.text 8397476 8399108 1632 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10031716 10034068 2352 0.0
(read/write) 684529 684705 176 0.0
.data.rel.ro 623432 623608 176 0.0
.rodata 478260 478452 192 0.0
.text 7992788 7994708 1920 0.0
lighting-app debug+rpc (read only) 2551193 2552105 912 0.0
(read/write) 129528 129560 32 0.0
.data.rel.ro 72136 72168 32 0.0
.rodata 213704 213864 160 0.1
.text 2167522 2168178 656 0.0
lock-app debug (read only) 2515913 2516841 928 0.0
(read/write) 124512 124544 32 0.0
.data.rel.ro 69096 69128 32 0.0
.rodata 228744 228904 160 0.1
.text 2122002 2122674 672 0.0
ota-provider-app debug (read only) 2322305 2323281 976 0.0
(read/write) 118312 118344 32 0.0
.data.rel.ro 63096 63128 32 0.1
.rodata 203512 203736 224 0.1
.text 1956018 1956674 656 0.0
ota-requestor-app debug (read only) 2439361 2440609 1248 0.1
(read/write) 125216 125248 32 0.0
.data.rel.ro 67288 67320 32 0.0
.rodata 207296 207488 192 0.1
.text 2060914 2061874 960 0.0
shell debug (read only) 2551169 2552113 944 0.0
(read/write) 141104 141136 32 0.0
.data.rel.ro 76688 76720 32 0.0
.rodata 227762 227954 192 0.1
.text 2166306 2166962 656 0.0
thermostat-no-ble arm64 (read only) 2595316 2596548 1232 0.0
(read/write) 158289 158337 48 0.0
.data.rel.ro 83240 83296 56 0.1
.rodata 165476 165668 192 0.1
.text 2190064 2190992 928 0.0
tv-app debug (read only) 3102225 3104145 1920 0.1
(read/write) 257704 257736 32 0.0
.data.rel.ro 79392 79424 32 0.0
.rodata 249024 249216 192 0.1
.text 2665298 2666930 1632 0.1
tv-casting-app debug (read only) 5577785 5579673 1888 0.0
(read/write) 161968 162000 32 0.0
.data.rel.ro 103048 103080 32 0.0
.rodata 343209 343369 160 0.0
.text 4956626 4958258 1632 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448112 2448584 472 0.0
.text 1410756 1411228 472 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175175 1175547 372 0.0
rodata 141888 142068 180 0.1
text 811492 811696 204 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155367 1155759 392 0.0
rodata 133416 133600 184 0.1
text 800936 801140 204 0.0
p6 all-clusters-app default (read/write) 2566144 2566552 408 0.0
.text 1524408 1524816 408 0.0
all-clusters-minimal-app default (read/write) 2511440 2511848 408 0.0
.text 1469704 1470112 408 0.0
light-app default (read/write) 2441368 2441776 408 0.0
.text 1399632 1400040 408 0.0
lock-app default (read/write) 2468520 2468928 408 0.0
.text 1426784 1427192 408 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797284 797708 424 0.1
text 565678 565908 230 0.0
lighting-app tlsr9518adk80d (read/write) 817116 817492 376 0.0
text 582002 582186 184 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 57cb679 c079ae4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 184948 184812 -136 -0.1
lock-ftd LP_CC2652R7 (read/write) 172184 171984 -200 -0.1
pump-app LP_CC2652R7 (read/write) 164032 163648 -384 -0.2
pump-controller-app LP_CC2652R7 (read/write) 178328 177936 -392 -0.2
shell LP_CC2652R7 (read/write) 187960 187808 -152 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 57cb679 c079ae4 change % change
bl602 lighting-app bl602 (read/write) 1397386 1397874 488 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1058588 1058896 308 0.0
bl602+rpc (read/write) 1442818 1443298 480 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1090276 1090576 300 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666275 666411 136 0.0
(read/write) 184948 184812 -136 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88139 88147 8 0.0
.text 577820 577948 128 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632083 632219 136 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77379 77387 8 0.0
.text 554380 554508 128 0.0
lock-ftd LP_CC2652R7 (read only) 669183 669383 200 0.0
(read/write) 172184 171984 -200 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76279 76295 16 0.0
.text 592424 592608 184 0.0
lock-mtd LP_CC2652R7 (read only) 618591 618791 200 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76159 76175 16 0.0
.text 541944 542128 184 0.0
pump-app LP_CC2652R7 (read only) 678183 678567 384 0.1
(read/write) 164032 163648 -384 -0.2
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88503 88687 184 0.2
.text 589196 589396 200 0.0
pump-controller-app LP_CC2652R7 (read only) 664007 664399 392 0.1
(read/write) 178328 177936 -392 -0.2
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84367 84559 192 0.2
.text 579160 579360 200 0.0
shell LP_CC2652R7 (read only) 658766 658918 152 0.0
(read/write) 187960 187808 -152 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84918 84934 16 0.0
.text 573532 573668 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579822 200 0.0
.app_xip_area 458376 458576 200 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585574 585774 200 0.0
.app_xip_area 459600 459800 200 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 582774 583134 360 0.1
.app_xip_area 462376 462736 360 0.1
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081436 1081900 464 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946372 946836 464 0.0
BRD4161A+rpc (read/write) 1135764 1136236 472 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 983808 984280 472 0.0
BRD4161A+rs911x (read/write) 947924 948388 464 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 805088 805552 464 0.1
lock-app BRD4161A+wf200 (read/write) 1128848 1129240 392 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982580 982972 392 0.0
window-app BRD4161A (read/write) 1075244 1075708 464 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938676 939140 464 0.0
esp32 all-clusters-app c3devkit (read only) 1020100 1020332 232 0.0
(read/write) 1485642 1485826 184 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215528 215712 184 0.1
.flash.text 1020100 1020332 232 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073971 1074151 180 0.0
(read/write) 487712 487888 176 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245972 246148 176 0.1
.flash.text 1068587 1068767 180 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658832 658976 144 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581524 581668 144 0.0
lock k32w061+release (read/write) 685684 685828 144 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607900 608044 144 0.0
linux all-clusters-app debug (read only) 2960825 2962073 1248 0.0
(read/write) 154752 154784 32 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 85000 32 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 263613 263805 192 0.1
.text 2520002 2520962 960 0.0
all-clusters-minimal-app debug (read only) 2813401 2814649 1248 0.0
(read/write) 146688 146720 32 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77640 32 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265341 265533 192 0.1
.text 2373026 2373986 960 0.0
bridge-app debug+rpc (read only) 2315449 2316377 928 0.0
(read/write) 125504 125536 32 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 67016 32 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198016 198176 160 0.1
.text 1955698 1956370 672 0.0
chip-tool debug (read only) 10345025 10346913 1888 0.0
(read/write) 622240 622272 32 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587888 587920 32 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 515861 516021 160 0.0
.text 8397476 8399108 1632 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10031716 10034068 2352 0.0
(read/write) 684529 684705 176 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 623432 623608 176 0.0
.dynamic 528 528 0 0.0
.got 13520 13520 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 478260 478452 192 0.0
.text 7992788 7994708 1920 0.0
lighting-app debug+rpc (read only) 2551193 2552105 912 0.0
(read/write) 129528 129560 32 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72168 32 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213704 213864 160 0.1
.text 2167522 2168178 656 0.0
lock-app debug (read only) 2515913 2516841 928 0.0
(read/write) 124512 124544 32 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69128 32 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 228744 228904 160 0.1
.text 2122002 2122674 672 0.0
ota-provider-app debug (read only) 2322305 2323281 976 0.0
(read/write) 118312 118344 32 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63128 32 0.1
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203512 203736 224 0.1
.text 1956018 1956674 656 0.0
ota-requestor-app debug (read only) 2439361 2440609 1248 0.1
(read/write) 125216 125248 32 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67320 32 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207296 207488 192 0.1
.text 2060914 2061874 960 0.0
shell debug (read only) 2551169 2552113 944 0.0
(read/write) 141104 141136 32 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76720 32 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227762 227954 192 0.1
.text 2166306 2166962 656 0.0
thermostat-no-ble arm64 (read only) 2595316 2596548 1232 0.0
(read/write) 158289 158337 48 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83296 56 0.1
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165476 165668 192 0.1
.text 2190064 2190992 928 0.0
tv-app debug (read only) 3102225 3104145 1920 0.1
(read/write) 257704 257736 32 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79424 32 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249024 249216 192 0.1
.text 2665298 2666930 1632 0.1
tv-casting-app debug (read only) 5577785 5579673 1888 0.0
(read/write) 161968 162000 32 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 103048 103080 32 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343209 343369 160 0.0
.text 4956626 4958258 1632 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448112 2448584 472 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410756 1411228 472 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175175 1175547 372 0.0
bss 142900 142900 0 0.0
rodata 141888 142068 180 0.1
text 811492 811696 204 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155367 1155759 392 0.0
bss 142136 142136 0 0.0
rodata 133416 133600 184 0.1
text 800936 801140 204 0.0
p6 all-clusters-app default (read/write) 2566144 2566552 408 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1524408 1524816 408 0.0
all-clusters-minimal-app default (read/write) 2511440 2511848 408 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1469704 1470112 408 0.0
light-app default (read/write) 2441368 2441776 408 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1399632 1400040 408 0.0
lock-app default (read/write) 2468520 2468928 408 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1426784 1427192 408 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797284 797708 424 0.1
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565678 565908 230 0.0
lighting-app tlsr9518adk80d (read/write) 817116 817492 376 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 582002 582186 184 0.0

@stale
Copy link

stale bot commented Jul 21, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 21, 2022
@yunhanw-google yunhanw-google force-pushed the feature/invalid_action_status branch from c079ae4 to a79623e Compare July 21, 2022 18:52
@stale stale bot removed the stale Stale issue or PR label Jul 21, 2022
@github-actions github-actions bot added the tests label Jul 21, 2022
@yunhanw-google yunhanw-google force-pushed the feature/invalid_action_status branch from a79623e to 3f74629 Compare July 21, 2022 19:01
@github-actions
Copy link

github-actions bot commented Jul 21, 2022

PR #19356: Size comparison from 1d88b32 to 3f74629

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1d88b32 3f74629 change % change
bl602 lighting-app bl602 (read/write) 1380794 1381090 296 0.0
.text 1050932 1051184 252 0.0
bl602+rpc (read/write) 1426202 1426498 296 0.0
.text 1082588 1082840 252 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668447 120 0.0
.rodata 88311 88327 16 0.0
.text 579700 579804 104 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633935 634047 112 0.0
.rodata 77551 77559 8 0.0
.text 556060 556164 104 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671723 168 0.0
.rodata 76443 76459 16 0.0
.text 594632 594784 152 0.0
lock-mtd LP_CC2652R7 (read only) 653839 654047 208 0.0
.rodata 101183 101223 40 0.0
.text 552176 552344 168 0.0
pump-app LP_CC2652R7 (read only) 680579 680859 280 0.0
.rodata 88811 88923 112 0.1
.text 591284 591452 168 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666627 272 0.0
.rodata 84667 84779 112 0.1
.text 581208 581368 160 0.0
shell LP_CC2652R7 (read only) 660810 660930 120 0.0
.rodata 85090 85106 16 0.0
.text 575404 575508 104 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582210 160 0.0
.app_xip_area 460440 460600 160 0.0
lock cyw930739m2evb_01 (read/write) 587966 588118 152 0.0
.app_xip_area 461628 461780 152 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585646 216 0.0
.app_xip_area 464668 464884 216 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1087144 384 0.0
.text 951472 951856 384 0.0
BRD4161A+rpc (read/write) 1141036 1141420 384 0.0
.text 988860 989244 384 0.0
BRD4161A+rs911x (read/write) 972716 973084 368 0.0
.text 808984 809352 368 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128496 272 0.0
.text 981844 982116 272 0.0
window-app BRD4161A (read/write) 1080236 1080620 384 0.0
.text 943448 943832 384 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1022140 210 0.0
(read/write) 1486282 1486394 112 0.0
.flash.rodata 216008 216120 112 0.1
.flash.text 1021930 1022140 210 0.0
m5stack (read only) 1075691 1075823 132 0.0
(read/write) 488304 488408 104 0.0
.flash.rodata 246412 246516 104 0.0
.flash.text 1070307 1070439 132 0.0
k32w light k32w061+release (read/write) 660784 660912 128 0.0
.text 583324 583452 128 0.0
lock k32w061+release (read/write) 687788 687900 112 0.0
.text 609844 609956 112 0.0
linux all-clusters-app debug (read only) 2981121 2982081 960 0.0
(read/write) 155344 155376 32 0.0
.data.rel.ro 85224 85256 32 0.0
.rodata 265707 265803 96 0.0
.text 2537298 2538066 768 0.0
all-clusters-minimal-app debug (read only) 2827073 2828033 960 0.0
(read/write) 147016 147048 32 0.0
.data.rel.ro 77784 77816 32 0.0
.rodata 266603 266699 96 0.0
.text 2385010 2385778 768 0.0
bridge-app debug+rpc (read only) 2341705 2342377 672 0.0
(read/write) 126920 126952 32 0.0
.data.rel.ro 67240 67272 32 0.0
.rodata 199208 199304 96 0.0
.text 1980210 1980690 480 0.0
chip-tool debug (read only) 10350497 10352257 1760 0.0
(read/write) 631912 631944 32 0.0
.data.rel.ro 597480 597512 32 0.0
.rodata 521525 521653 128 0.0
.text 8375380 8376916 1536 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9776284 2176 0.0
(read/write) 679441 679617 176 0.0
.data.rel.ro 624824 625000 176 0.0
.rodata 457340 457452 112 0.0
.text 7732372 7734196 1824 0.0
lighting-app debug+rpc (read only) 2564897 2565601 704 0.0
(read/write) 129888 129920 32 0.0
.data.rel.ro 72296 72328 32 0.0
.rodata 214896 215024 128 0.1
.text 2179602 2180082 480 0.0
lock-app debug (read only) 2529921 2530593 672 0.0
(read/write) 124872 124904 32 0.0
.data.rel.ro 69272 69304 32 0.0
.rodata 229936 230032 96 0.0
.text 2134386 2134866 480 0.0
ota-provider-app debug (read only) 2333505 2334241 736 0.0
(read/write) 118672 118704 32 0.0
.data.rel.ro 63256 63288 32 0.1
.rodata 204728 204888 160 0.1
.text 1965570 1966050 480 0.0
ota-requestor-app debug (read only) 2451961 2452953 992 0.0
(read/write) 125576 125608 32 0.0
.data.rel.ro 67480 67512 32 0.0
.rodata 208448 208576 128 0.1
.text 2071906 2072674 768 0.0
shell debug (read only) 2567729 2568417 688 0.0
(read/write) 141400 141432 32 0.0
.data.rel.ro 76856 76888 32 0.0
.rodata 229010 229106 96 0.0
.text 2181186 2181682 496 0.0
thermostat-no-ble arm64 (read only) 2341476 2342436 960 0.0
(read/write) 141265 141329 64 0.0
.data.rel.ro 75616 75672 56 0.1
.rodata 139420 139532 112 0.1
.text 1965248 1965968 720 0.0
tv-app debug (read only) 3115497 3117225 1728 0.1
(read/write) 257024 257056 32 0.0
.data.rel.ro 78792 78824 32 0.0
.rodata 250408 250504 96 0.0
.text 2676690 2678226 1536 0.1
tv-casting-app debug (read only) 5369113 5370825 1712 0.0
(read/write) 158328 158360 32 0.0
.data.rel.ro 98352 98384 32 0.0
.rodata 334561 334657 96 0.0
.text 4768050 4769570 1520 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449032 2449488 456 0.0
.text 1411676 1412132 456 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176671 288 0.0
rodata 142200 142312 112 0.1
text 812248 812420 172 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156735 288 0.0
rodata 133744 133856 112 0.1
text 801564 801736 172 0.0
p6 all-clusters-app default (read/write) 1686428 1686732 304 0.0
.text 1526328 1526632 304 0.0
all-clusters-minimal-app default (read/write) 1630540 1630860 320 0.0
.text 1471160 1471480 320 0.0
light-app default (read/write) 1550780 1551084 304 0.0
.text 1399704 1400008 304 0.0
lock-app default (read/write) 1588372 1588676 304 0.0
.text 1432824 1433128 304 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798852 799172 320 0.0
text 566822 567032 210 0.0
lighting-app tlsr9518adk80d (read/write) 818908 819180 272 0.0
text 583370 583530 160 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 1d88b32 3f74629 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183016 182896 -120 -0.1
lock-ftd LP_CC2652R7 (read/write) 169964 169796 -168 -0.1
lock-mtd LP_CC2652R7 (read/write) 183368 183160 -208 -0.1
pump-app LP_CC2652R7 (read/write) 161796 161516 -280 -0.2
pump-controller-app LP_CC2652R7 (read/write) 176140 175868 -272 -0.2
shell LP_CC2652R7 (read/write) 186036 185916 -120 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1d88b32 3f74629 change % change
bl602 lighting-app bl602 (read/write) 1380794 1381090 296 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050932 1051184 252 0.0
bl602+rpc (read/write) 1426202 1426498 296 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082840 252 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668447 120 0.0
(read/write) 183016 182896 -120 -0.1
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88327 16 0.0
.text 579700 579804 104 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633935 634047 112 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77559 8 0.0
.text 556060 556164 104 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671723 168 0.0
(read/write) 169964 169796 -168 -0.1
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76459 16 0.0
.text 594632 594784 152 0.0
lock-mtd LP_CC2652R7 (read only) 653839 654047 208 0.0
(read/write) 183368 183160 -208 -0.1
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101223 40 0.0
.text 552176 552344 168 0.0
pump-app LP_CC2652R7 (read only) 680579 680859 280 0.0
(read/write) 161796 161516 -280 -0.2
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88923 112 0.1
.text 591284 591452 168 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666627 272 0.0
(read/write) 176140 175868 -272 -0.2
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84779 112 0.1
.text 581208 581368 160 0.0
shell LP_CC2652R7 (read only) 660810 660930 120 0.0
(read/write) 186036 185916 -120 -0.1
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85106 16 0.0
.text 575404 575508 104 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582210 160 0.0
.app_xip_area 460440 460600 160 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 588118 152 0.0
.app_xip_area 461628 461780 152 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585646 216 0.0
.app_xip_area 464668 464884 216 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1087144 384 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951856 384 0.0
BRD4161A+rpc (read/write) 1141036 1141420 384 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 989244 384 0.0
BRD4161A+rs911x (read/write) 972716 973084 368 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808984 809352 368 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128496 272 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981844 982116 272 0.0
window-app BRD4161A (read/write) 1080236 1080620 384 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943832 384 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1022140 210 0.0
(read/write) 1486282 1486394 112 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216120 112 0.1
.flash.text 1021930 1022140 210 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075691 1075823 132 0.0
(read/write) 488304 488408 104 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246516 104 0.0
.flash.text 1070307 1070439 132 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660784 660912 128 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583324 583452 128 0.0
lock k32w061+release (read/write) 687788 687900 112 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609956 112 0.0
linux all-clusters-app debug (read only) 2981121 2982081 960 0.0
(read/write) 155344 155376 32 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85256 32 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265707 265803 96 0.0
.text 2537298 2538066 768 0.0
all-clusters-minimal-app debug (read only) 2827073 2828033 960 0.0
(read/write) 147016 147048 32 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77816 32 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266699 96 0.0
.text 2385010 2385778 768 0.0
bridge-app debug+rpc (read only) 2341705 2342377 672 0.0
(read/write) 126920 126952 32 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67272 32 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199208 199304 96 0.0
.text 1980210 1980690 480 0.0
chip-tool debug (read only) 10350497 10352257 1760 0.0
(read/write) 631912 631944 32 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597512 32 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521525 521653 128 0.0
.text 8375380 8376916 1536 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9776284 2176 0.0
(read/write) 679441 679617 176 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 625000 176 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457452 112 0.0
.text 7732372 7734196 1824 0.0
lighting-app debug+rpc (read only) 2564897 2565601 704 0.0
(read/write) 129888 129920 32 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72328 32 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214896 215024 128 0.1
.text 2179602 2180082 480 0.0
lock-app debug (read only) 2529921 2530593 672 0.0
(read/write) 124872 124904 32 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69304 32 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 230032 96 0.0
.text 2134386 2134866 480 0.0
ota-provider-app debug (read only) 2333505 2334241 736 0.0
(read/write) 118672 118704 32 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63288 32 0.1
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204888 160 0.1
.text 1965570 1966050 480 0.0
ota-requestor-app debug (read only) 2451961 2452953 992 0.0
(read/write) 125576 125608 32 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67512 32 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208576 128 0.1
.text 2071906 2072674 768 0.0
shell debug (read only) 2567729 2568417 688 0.0
(read/write) 141400 141432 32 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76888 32 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229010 229106 96 0.0
.text 2181186 2181682 496 0.0
thermostat-no-ble arm64 (read only) 2341476 2342436 960 0.0
(read/write) 141265 141329 64 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75672 56 0.1
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139532 112 0.1
.text 1965248 1965968 720 0.0
tv-app debug (read only) 3115497 3117225 1728 0.1
(read/write) 257024 257056 32 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78824 32 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250408 250504 96 0.0
.text 2676690 2678226 1536 0.1
tv-casting-app debug (read only) 5369113 5370825 1712 0.0
(read/write) 158328 158360 32 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98384 32 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334561 334657 96 0.0
.text 4768050 4769570 1520 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449488 456 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1412132 456 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176671 288 0.0
bss 143068 143068 0 0.0
rodata 142200 142312 112 0.1
text 812248 812420 172 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156735 288 0.0
bss 142304 142304 0 0.0
rodata 133744 133856 112 0.1
text 801564 801736 172 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686428 1686732 304 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526328 1526632 304 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630540 1630860 320 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471160 1471480 320 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550780 1551084 304 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399704 1400008 304 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588372 1588676 304 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432824 1433128 304 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798852 799172 320 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566822 567032 210 0.0
lighting-app tlsr9518adk80d (read/write) 818908 819180 272 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583370 583530 160 0.0

@github-actions
Copy link

github-actions bot commented Jul 26, 2022

PR #19356: Size comparison from 2987329 to 1235b2e

Increases (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 2987329 1235b2e change % change
bl602 lighting-app bl602 (read/write) 1381762 1381882 120 0.0
.text 1051808 1051932 124 0.0
bl602+rpc (read/write) 1427170 1427290 120 0.0
.text 1083464 1083588 124 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668791 668799 8 0.0
.text 580084 580092 8 0.0
lock-ftd LP_CC2652R7 (read only) 671907 671963 56 0.0
.text 594952 595008 56 0.0
lock-mtd LP_CC2652R7 (read only) 654167 654215 48 0.0
.text 552504 552552 48 0.0
pump-app LP_CC2652R7 (read only) 681579 681707 128 0.0
.rodata 89219 89299 80 0.1
.text 591876 591924 48 0.0
pump-controller-app LP_CC2652R7 (read only) 667331 667451 120 0.0
.rodata 85059 85131 72 0.1
.text 581792 581840 48 0.0
shell LP_CC2652R7 (read only) 661250 661266 16 0.0
.text 575772 575788 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583642 583682 40 0.0
.app_xip_area 460780 460820 40 0.0
lock cyw930739m2evb_01 (read/write) 589554 589602 48 0.0
.app_xip_area 461964 462012 48 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588078 588182 104 0.0
.app_xip_area 466064 466168 104 0.0
efr32 lighting-app BRD4161A (read/write) 1088680 1088880 200 0.0
.text 953336 953536 200 0.0
BRD4161A+rpc (read/write) 1142980 1143180 200 0.0
.text 990744 990944 200 0.0
BRD4161A+rs911x (read/write) 953224 953424 200 0.0
.text 810164 810364 200 0.0
lock-app BRD4161A+wf200 (read/write) 1128668 1128788 120 0.0
.text 982232 982352 120 0.0
window-app BRD4161A (read/write) 1082172 1082372 200 0.0
.text 945324 945524 200 0.0
esp32 all-clusters-app c3devkit (read only) 1022416 1022504 88 0.0
(read/write) 1486618 1486690 72 0.0
.flash.rodata 216296 216368 72 0.0
.flash.text 1022416 1022504 88 0.0
m5stack (read only) 1075959 1075983 24 0.0
(read/write) 488616 488688 72 0.0
.flash.rodata 246676 246748 72 0.0
.flash.text 1070575 1070599 24 0.0
linux all-clusters-app debug .rodata 267627 267723 96 0.0
all-clusters-minimal-app debug .rodata 267659 267755 96 0.0
bridge-app debug+rpc .rodata 200008 200104 96 0.0
chip-tool debug (read only) 10384193 10384769 576 0.0
.rodata 531477 531541 64 0.0
.text 8401236 8401748 512 0.0
chip-tool-ipv6only arm64 (read only) 9808692 9810004 1312 0.0
(read/write) 678561 678705 144 0.0
.data.rel.ro 623904 624048 144 0.0
.rodata 466244 466340 96 0.0
.text 7760244 7761316 1072 0.0
lighting-app debug+rpc .rodata 215728 215792 64 0.0
lock-app debug .rodata 230704 230800 96 0.0
ota-provider-app debug .rodata 205688 205784 96 0.0
ota-requestor-app debug .rodata 209248 209312 64 0.0
shell debug .rodata 230034 230130 96 0.0
thermostat-no-ble arm64 (read only) 2342092 2342316 224 0.0
(read/write) 141345 141361 16 0.0
.data.rel.ro 75624 75648 24 0.0
.rodata 139460 139572 112 0.1
.text 1965728 1965808 80 0.0
tv-app debug (read only) 3116649 3117257 608 0.0
.rodata 251400 251496 96 0.0
.text 2676706 2677218 512 0.0
tv-casting-app debug (read only) 5370969 5371577 608 0.0
.rodata 335521 335617 96 0.0
.text 4768802 4769314 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449472 2449768 296 0.0
.text 1412116 1412412 296 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177675 1177795 120 0.0
rodata 142692 142764 72 0.1
text 812924 812976 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157727 1157847 120 0.0
rodata 134224 134296 72 0.1
text 802232 802288 56 0.0
p6 all-clusters-app default (read/write) 1687524 1687660 136 0.0
.text 1527360 1527496 136 0.0
all-clusters-minimal-app default (read/write) 1631636 1631772 136 0.0
.text 1472192 1472328 136 0.0
light-app default (read/write) 1551708 1551844 136 0.0
.text 1400568 1400704 136 0.0
lock-app default (read/write) 1589300 1589436 136 0.0
.text 1433688 1433824 136 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799980 800124 144 0.0
text 567494 567566 72 0.0
lighting-app tlsr9518adk80d (read/write) 820064 820168 104 0.0
text 584046 584080 34 0.0
Decreases (14 builds for cc13x2_26x2, linux)
platform target config section 2987329 1235b2e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182568 182560 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 169644 169588 -56 -0.0
lock-mtd LP_CC2652R7 (read/write) 183072 183024 -48 -0.0
pump-app LP_CC2652R7 (read/write) 160804 160676 -128 -0.1
pump-controller-app LP_CC2652R7 (read/write) 175188 175068 -120 -0.1
shell LP_CC2652R7 (read/write) 185628 185612 -16 -0.0
linux all-clusters-app debug (read only) 2986169 2986089 -80 -0.0
.text 2540354 2540178 -176 -0.0
all-clusters-minimal-app debug (read only) 2829081 2829001 -80 -0.0
.text 2385842 2385666 -176 -0.0
bridge-app debug+rpc (read only) 2343497 2343209 -288 -0.0
.text 1981058 1980674 -384 -0.0
lighting-app debug+rpc (read only) 2566601 2566281 -320 -0.0
.text 2180354 2179970 -384 -0.0
lock-app debug (read only) 2531625 2531337 -288 -0.0
.text 2135202 2134818 -384 -0.0
ota-provider-app debug (read only) 2335401 2335113 -288 -0.0
.text 1966386 1966002 -384 -0.0
ota-requestor-app debug (read only) 2453601 2453505 -96 -0.0
.text 2072626 2072466 -160 -0.0
shell debug (read only) 2569825 2569537 -288 -0.0
.text 2182114 2181730 -384 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2987329 1235b2e change % change
bl602 lighting-app bl602 (read/write) 1381762 1381882 120 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051808 1051932 124 0.0
bl602+rpc (read/write) 1427170 1427290 120 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083464 1083588 124 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668791 668799 8 0.0
(read/write) 182568 182560 -8 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88391 88391 0 0.0
.text 580084 580092 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634391 634391 0 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77615 77615 0 0.0
.text 556452 556452 0 0.0
lock-ftd LP_CC2652R7 (read only) 671907 671963 56 0.0
(read/write) 169644 169588 -56 -0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76475 76475 0 0.0
.text 594952 595008 56 0.0
lock-mtd LP_CC2652R7 (read only) 654167 654215 48 0.0
(read/write) 183072 183024 -48 -0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552504 552552 48 0.0
pump-app LP_CC2652R7 (read only) 681579 681707 128 0.0
(read/write) 160804 160676 -128 -0.1
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89219 89299 80 0.1
.text 591876 591924 48 0.0
pump-controller-app LP_CC2652R7 (read only) 667331 667451 120 0.0
(read/write) 175188 175068 -120 -0.1
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85059 85131 72 0.1
.text 581792 581840 48 0.0
shell LP_CC2652R7 (read only) 661250 661266 16 0.0
(read/write) 185628 185612 -16 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85162 85162 0 0.0
.text 575772 575788 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583642 583682 40 0.0
.app_xip_area 460780 460820 40 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589554 589602 48 0.0
.app_xip_area 461964 462012 48 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588078 588182 104 0.0
.app_xip_area 466064 466168 104 0.0
.bss 64864 64864 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088680 1088880 200 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 953336 953536 200 0.0
BRD4161A+rpc (read/write) 1142980 1143180 200 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990744 990944 200 0.0
BRD4161A+rs911x (read/write) 953224 953424 200 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 810164 810364 200 0.0
lock-app BRD4161A+wf200 (read/write) 1128668 1128788 120 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 982232 982352 120 0.0
window-app BRD4161A (read/write) 1082172 1082372 200 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 945324 945524 200 0.0
esp32 all-clusters-app c3devkit (read only) 1022416 1022504 88 0.0
(read/write) 1486618 1486690 72 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216296 216368 72 0.0
.flash.text 1022416 1022504 88 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075959 1075983 24 0.0
(read/write) 488616 488688 72 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246676 246748 72 0.0
.flash.text 1070575 1070599 24 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641876 641876 0 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567392 567392 0 0.0
lock k32w0+release (read/write) 699180 699180 0 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624248 624248 0 0.0
linux all-clusters-app debug (read only) 2986169 2986089 -80 -0.0
(read/write) 155416 155416 0 0.0
.bss 61856 61856 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 267627 267723 96 0.0
.text 2540354 2540178 -176 -0.0
all-clusters-minimal-app debug (read only) 2829081 2829001 -80 -0.0
(read/write) 147120 147120 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 267659 267755 96 0.0
.text 2385842 2385666 -176 -0.0
bridge-app debug+rpc (read only) 2343497 2343209 -288 -0.0
(read/write) 127024 127024 0 0.0
.bss 50144 50144 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 200008 200104 96 0.0
.text 1981058 1980674 -384 -0.0
chip-tool debug (read only) 10384193 10384769 576 0.0
(read/write) 631056 631056 0 0.0
.bss 24824 24824 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596568 596568 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 531477 531541 64 0.0
.text 8401236 8401748 512 0.0
chip-tool-ipv6only arm64 (read only) 9808692 9810004 1312 0.0
(read/write) 678561 678705 144 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623904 624048 144 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466244 466340 96 0.0
.text 7760244 7761316 1072 0.0
lighting-app debug+rpc (read only) 2566601 2566281 -320 -0.0
(read/write) 129992 129992 0 0.0
.bss 49696 49696 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72328 72328 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 215728 215792 64 0.0
.text 2180354 2179970 -384 -0.0
lock-app debug (read only) 2531625 2531337 -288 -0.0
(read/write) 124976 124976 0 0.0
.bss 48096 48096 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69304 69304 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 230704 230800 96 0.0
.text 2135202 2134818 -384 -0.0
ota-provider-app debug (read only) 2335401 2335113 -288 -0.0
(read/write) 118776 118776 0 0.0
.bss 47744 47744 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63288 63288 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 205688 205784 96 0.0
.text 1966386 1966002 -384 -0.0
ota-requestor-app debug (read only) 2453601 2453505 -96 -0.0
(read/write) 125680 125680 0 0.0
.bss 50080 50080 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67512 67512 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 209248 209312 64 0.0
.text 2072626 2072466 -160 -0.0
shell debug (read only) 2569825 2569537 -288 -0.0
(read/write) 141568 141568 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76888 76888 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 230034 230130 96 0.0
.text 2182114 2181730 -384 -0.0
thermostat-no-ble arm64 (read only) 2342092 2342316 224 0.0
(read/write) 141345 141361 16 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75624 75648 24 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139460 139572 112 0.1
.text 1965728 1965808 80 0.0
tv-app debug (read only) 3116649 3117257 608 0.0
(read/write) 257160 257160 0 0.0
.bss 167160 167160 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78824 78824 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 251400 251496 96 0.0
.text 2676706 2677218 512 0.0
tv-casting-app debug (read only) 5370969 5371577 608 0.0
(read/write) 158432 158432 0 0.0
.bss 51320 51320 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98384 98384 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 335521 335617 96 0.0
.text 4768802 4769314 512 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449472 2449768 296 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1412116 1412412 296 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177675 1177795 120 0.0
bss 143132 143132 0 0.0
rodata 142692 142764 72 0.1
text 812924 812976 52 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157727 1157847 120 0.0
bss 142368 142368 0 0.0
rodata 134224 134296 72 0.1
text 802232 802288 56 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687524 1687660 136 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1527360 1527496 136 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631636 1631772 136 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1472192 1472328 136 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551708 1551844 136 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400568 1400704 136 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589300 1589436 136 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433688 1433824 136 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799980 800124 144 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567494 567566 72 0.0
lighting-app tlsr9518adk80d (read/write) 820064 820168 104 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 584046 584080 34 0.0

@yunhanw-google yunhanw-google force-pushed the feature/invalid_action_status branch from 1235b2e to 7450f57 Compare July 27, 2022 21:41
@@ -186,7 +181,7 @@ void CommandHandler::DecrementHoldOff()
return;
}

if (!mExchangeCtx->IsGroupExchangeContext() && !mSentStatusResponse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this now going to cause us to send two messages: the IM engine sending a status response (see this), and this here sending a response?

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, given the bugs in the code and the bugs in the tests (e.g. the message-dropping code) and the pain of reviewing this huge thing every time (I just needed a 2-hour solid chunk to go through it, and I have zero confidence I found all the bugs), I would like to suggest the following break-up of this into multiple PRs:

  1. A PR to change NetworkTestHelpers to allow the behavior we want. That behavior is "allow through N messages, then block M messages", right? I think that the right way to do that is to have a "number of messages we have let through before we start blocking" counter that counts down to 0, instead of tying it to the unrelated "total messages we have ever sent" counter. I'm happy to do this PR if you want.
  2. A PR to change the signature of StatusResponse parsing, so we are not conflating the mechanical changes there with the substantive changes in this PR.
  3. Separate PRs for commands/reads/writes, or better yet for each client/server bit (so 3 or 6 PRs). That will hopefully lead to PRs that are not too big, test changes that are not too big, and the whole thing can be reviewed sanely and actually land in a finite amount of time.... Importantly, we can parallelize and do reviews on one while another is being updated, etc.


if (mExchangeCtx->IsGroupExchangeContext())
{
ReturnErrorOnFailure(ProcessGroupCommandDataIB(commandData));
VerifyOrReturnError(ProcessGroupCommandDataIB(commandData) == CHIP_NO_ERROR, Status::Failure);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this (and ProcessCommandData) Status::Failure? Please file a followup to have those return a useful status for parsing errors in the payloads....

@@ -186,7 +181,7 @@ void CommandHandler::DecrementHoldOff()
return;
}

if (!mExchangeCtx->IsGroupExchangeContext() && !mSentStatusResponse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few problems here:

  1. The IM engine will not in fact be able to send a status response, as far as I can tell. That's because we're going to Close at the bottom of this function, which will destroy this object, but we grabbed the exchange into our exchange holder already and it's expecting a send because we called WillSendMessage, so we're going to abort the exchange. That looks like a bug that got introduced with the ExchangeHolder PR @mrjerryjohns . :(
  2. If we are returning failure to the IM engine so it will send a status response, we do not want to send anything here.

It seems like we might want to:

  • Not call WillSendMessage on the exchange until we return successfully from ProcessInvokeRequest.
  • If ProcessInvokeRequest fails, Release our mExchangeCtx so we don't do any message sending here.

or something like that.

It also seems like we should break this apart into three (if not 6) separate PRs so we don't end up needing a huge time-sink of a review very time and don't block fixes to some of these objects because of problems with others. :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not call WillSendMessage on the exchange until we return successfully from ProcessInvokeRequest.
If ProcessInvokeRequest fails, Release our mExchangeCtx so we don't do any message sending here.

Part of the reason why this bug is happening and is being exposed is the jarring mismatch between the expectation that the IM engine still be involved in sending out some messages on an exchange (i.e this final status response) vs. the CommandHandler taking over management of that exchange.

I have posted on this PR earlier, but I think that model is dangerous. Once you transfer ownership and management of the EC to a more suited protocol object, it should be the one responsible for sending back status responses and the like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To that end, I don't think either solution suggested would be favorable for me. I'd rather CommandHandler (and I guess by extension), all the other IM handler objects manage sending their own StatusResponses. That is the cleanest, and safest.

{
System::PacketBufferTLVReader reader;
reader.Init(aPayload.Retain());

ReportDataMessage::Parser report;
ReturnErrorOnFailure(report.Init(reader));
VerifyOrReturnError(report.Init(reader) == CHIP_NO_ERROR, Status::InvalidSubscription);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be InvalidAction? Same for the other parse failures here....

Comment on lines +484 to +485
StatusResponse::Send(Protocols::InteractionModel::Status::InvalidAction, apExchangeContext, false /*aExpectResponse*/);
if (!aSuppressErrorStatusResponse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make any sense. Why is aSuppressErrorStatusResponse affecting calls to mpCallback but not affecting the sending of the status response? And how are tests possibly passing with this code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to point me to the tests that would have failed due to this bug in the updates.

StatusResponse::Send(Protocols::InteractionModel::Status::InvalidAction, apExchangeContext, false /*aExpectResponse*/);
if (mpCallback != nullptr)
{
mpCallback->OnError(this, aError);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not making our OnError call if aSuppressErrorStatusResponse is true? That's broken.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, there should be tests covering this, and the fact that there are not is really confusing to me.

@@ -102,19 +102,37 @@ class LoopbackTransport : public Transport::Base
{
ReturnErrorOnFailure(mMessageSendError);
mSentMessageCount++;

if (mNumMessagesToDrop == 0)
if (mNumMessagesToDropSinceIndex == 0)
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this get to be 0 if it's ever set nonzero.

@github-actions
Copy link

github-actions bot commented Jul 28, 2022

PR #19356: Size comparison from 6cd4676 to 7450f57

Increases (31 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6cd4676 7450f57 change % change
bl602 lighting-app bl602 (read/write) 1381322 1381450 128 0.0
.text 1051628 1051752 124 0.0
bl602+rpc (read/write) 1426738 1426866 128 0.0
.text 1083292 1083416 124 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 .text 579788 579796 8 0.0
all-clusters-minimal-app LP_CC2652R7 .text 556140 556148 8 0.0
lock-ftd LP_CC2652R7 (read only) 671439 671495 56 0.0
.text 594712 594768 56 0.0
lock-mtd LP_CC2652R7 (read only) 653547 653595 48 0.0
.text 552200 552248 48 0.0
pump-app LP_CC2652R7 (read only) 680735 680855 120 0.0
.rodata 88855 88927 72 0.1
.text 591396 591444 48 0.0
pump-controller-app LP_CC2652R7 (read only) 666471 666599 128 0.0
.rodata 84671 84751 80 0.1
.text 581320 581368 48 0.0
shell LP_CC2652R7 (read only) 660998 661006 8 0.0
.text 575524 575532 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583190 583246 56 0.0
.app_xip_area 460000 460056 56 0.0
lock cyw930739m2evb_01 (read/write) 589110 589158 48 0.0
.app_xip_area 461192 461240 48 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588930 589026 96 0.0
.app_xip_area 466556 466652 96 0.0
efr32 lighting-app BRD4161A (read/write) 1087824 1088024 200 0.0
.text 952472 952672 200 0.0
BRD4161A+rpc (read/write) 1142116 1142316 200 0.0
.text 989872 990072 200 0.0
BRD4161A+rs911x (read/write) 952480 952680 200 0.0
.text 809412 809612 200 0.0
lock-app BRD4161A+wf200 (read/write) 1128288 1128408 120 0.0
.text 981844 981964 120 0.0
window-app BRD4161A (read/write) 1081300 1081500 200 0.0
.text 944444 944644 200 0.0
esp32 all-clusters-app c3devkit (read only) 1022460 1022546 86 0.0
(read/write) 1486266 1486338 72 0.0
.flash.rodata 215928 216000 72 0.0
.flash.text 1022460 1022546 86 0.0
m5stack (read only) 1076107 1076131 24 0.0
(read/write) 488304 488368 64 0.0
.flash.rodata 246356 246420 64 0.0
.flash.text 1070723 1070747 24 0.0
k32w lock k32w0+release (read/write) 699824 699840 16 0.0
.text 624884 624900 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9839124 9840436 1312 0.0
(read/write) 678609 678753 144 0.0
.data.rel.ro 623936 624080 144 0.0
.rodata 467796 467892 96 0.0
.text 7788980 7790052 1072 0.0
thermostat-no-ble arm64 (read only) 2343380 2343572 192 0.0
(read/write) 141601 141633 32 0.0
.data.rel.ro 75856 75880 24 0.0
.rodata 138956 139052 96 0.1
.text 1967200 1967280 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2450376 2450608 232 0.0
.text 1413020 1413252 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172683 1172803 120 0.0
rodata 141820 141892 72 0.1
text 808808 808864 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152735 1152855 120 0.0
rodata 133352 133424 72 0.1
text 798120 798168 48 0.0
p6 all-clusters-app default (read/write) 1686692 1686844 152 0.0
.text 1526520 1526672 152 0.0
all-clusters-minimal-app default (read/write) 1630788 1630940 152 0.0
.text 1471336 1471488 152 0.0
light-app default (read/write) 1552212 1552348 136 0.0
.text 1401064 1401200 136 0.0
lock-app default (read/write) 1589820 1589956 136 0.0
.text 1434200 1434336 136 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799592 799744 152 0.0
text 567240 567316 76 0.0
lighting-app tlsr9518adk80d (read/write) 819700 819804 104 0.0
text 583814 583848 34 0.0
Decreases (7 builds for cc13x2_26x2)
platform target config section 6cd4676 7450f57 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 88187 88179 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 .rodata 77403 77395 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 170120 170064 -56 -0.0
lock-mtd LP_CC2652R7 (read/write) 183700 183652 -48 -0.0
pump-app LP_CC2652R7 (read/write) 161656 161536 -120 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176056 175928 -128 -0.1
shell LP_CC2652R7 (read/write) 185888 185880 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6cd4676 7450f57 change % change
bl602 lighting-app bl602 (read/write) 1381322 1381450 128 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051628 1051752 124 0.0
bl602+rpc (read/write) 1426738 1426866 128 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083292 1083416 124 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668291 668291 0 0.0
(read/write) 183076 183076 0 0.0
.bss 74260 74260 0 0.0
.data 3356 3356 0 0.0
.rodata 88187 88179 -8 -0.0
.text 579788 579796 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633867 633867 0 0.0
(read/write) 157828 157828 0 0.0
.bss 73556 73556 0 0.0
.data 3356 3356 0 0.0
.rodata 77403 77395 -8 -0.0
.text 556140 556148 8 0.0
lock-ftd LP_CC2652R7 (read only) 671439 671495 56 0.0
(read/write) 170120 170064 -56 -0.0
.bss 71340 71340 0 0.0
.data 3280 3280 0 0.0
.rodata 76247 76247 0 0.0
.text 594712 594768 56 0.0
lock-mtd LP_CC2652R7 (read only) 653547 653595 48 0.0
(read/write) 183700 183652 -48 -0.0
.bss 67028 67028 0 0.0
.data 3280 3280 0 0.0
.rodata 100867 100867 0 0.0
.text 552200 552248 48 0.0
pump-app LP_CC2652R7 (read only) 680735 680855 120 0.0
(read/write) 161656 161536 -120 -0.1
.bss 71404 71404 0 0.0
.data 3280 3280 0 0.0
.rodata 88855 88927 72 0.1
.text 591396 591444 48 0.0
pump-controller-app LP_CC2652R7 (read only) 666471 666599 128 0.0
(read/write) 176056 175928 -128 -0.1
.bss 71540 71540 0 0.0
.data 3276 3276 0 0.0
.rodata 84671 84751 80 0.1
.text 581320 581368 48 0.0
shell LP_CC2652R7 (read only) 660998 661006 8 0.0
(read/write) 185888 185880 -8 -0.0
.bss 76580 76580 0 0.0
.data 3360 3360 0 0.0
.rodata 85158 85158 0 0.0
.text 575524 575532 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583190 583246 56 0.0
.app_xip_area 460000 460056 56 0.0
.bss 65648 65648 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589110 589158 48 0.0
.app_xip_area 461192 461240 48 0.0
.bss 70376 70376 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588930 589026 96 0.0
.app_xip_area 466556 466652 96 0.0
.bss 64888 64888 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087824 1088024 200 0.0
.bss 133284 133284 0 0.0
.data 2048 2048 0 0.0
.text 952472 952672 200 0.0
BRD4161A+rpc (read/write) 1142116 1142316 200 0.0
.bss 149964 149964 0 0.0
.data 2260 2260 0 0.0
.text 989872 990072 200 0.0
BRD4161A+rs911x (read/write) 952480 952680 200 0.0
.bss 141000 141000 0 0.0
.data 2048 2048 0 0.0
.text 809412 809612 200 0.0
lock-app BRD4161A+wf200 (read/write) 1128288 1128408 120 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981844 981964 120 0.0
window-app BRD4161A (read/write) 1081300 1081500 200 0.0
.bss 134756 134756 0 0.0
.data 2076 2076 0 0.0
.text 944444 944644 200 0.0
esp32 all-clusters-app c3devkit (read only) 1022460 1022546 86 0.0
(read/write) 1486266 1486338 72 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215928 216000 72 0.0
.flash.text 1022460 1022546 86 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076107 1076131 24 0.0
(read/write) 488304 488368 64 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246356 246420 64 0.0
.flash.text 1070723 1070747 24 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642592 642592 0 0.0
.bss 69736 69736 0 0.0
.data 2028 2028 0 0.0
.text 568100 568100 0 0.0
lock k32w0+release (read/write) 699824 699840 16 0.0
.bss 70176 70176 0 0.0
.data 2036 2036 0 0.0
.text 624884 624900 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9839124 9840436 1312 0.0
(read/write) 678609 678753 144 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 624080 144 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467796 467892 96 0.0
.text 7788980 7790052 1072 0.0
thermostat-no-ble arm64 (read only) 2343380 2343572 192 0.0
(read/write) 141601 141633 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 138956 139052 96 0.1
.text 1967200 1967280 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450376 2450608 232 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413020 1413252 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172683 1172803 120 0.0
bss 143140 143140 0 0.0
rodata 141820 141892 72 0.1
text 808808 808864 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152735 1152855 120 0.0
bss 142376 142376 0 0.0
rodata 133352 133424 72 0.1
text 798120 798168 48 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686692 1686844 152 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526520 1526672 152 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1630788 1630940 152 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471336 1471488 152 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552212 1552348 136 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401064 1401200 136 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589820 1589956 136 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434200 1434336 136 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799592 799744 152 0.0
bss 70816 70816 0 0.0
noinit 40416 40416 0 0.0
text 567240 567316 76 0.0
lighting-app tlsr9518adk80d (read/write) 819700 819804 104 0.0
bss 71660 71660 0 0.0
noinit 40416 40416 0 0.0
text 583814 583848 34 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommandHandler does not send required status responses in many cases
5 participants