Fix status response handling in write handler #21440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
yunhanw-google
force-pushed
the
feature/fix_write_handler
branch
2 times, most recently
from
32ec9c5 to
d2518cd
Compare
|
PR #21440: Size comparison from 561eaea to d2518cd Increases (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
yunhanw-google
force-pushed
the
feature/fix_write_handler
branch
from
d2518cd to
ad59476
Compare
|
PR #21440: Size comparison from 90fe78e to ad59476 Increases (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2022
yunhanw-google
force-pushed
the
feature/fix_write_handler
branch
from
ad59476 to
964f055
Compare
|
PR #21440: Size comparison from 0ac799e to 964f055 Increases (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
yufengwangca
approved these changes
Aug 5, 2022
|
@yunhanw-google This is failing the nRF Connect unit tests, with this error: I am guessing the PacketBuffers there are bigger, and we end up not chunking.... We should probably reserve an amount of space dependent on the packet buffer available space, not a hardcoded 900 bytes. |
woody-apple
added a commit
that referenced
this pull request
Aug 6, 2022
This reverts commit 75ffda4.
woody-apple
added a commit
that referenced
this pull request
Aug 6, 2022
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Aug 8, 2022
…chip#21440)" (project-chip#21701)" This reverts commit 5ab5be3.
yunhanw-google
added a commit
that referenced
this pull request
Aug 9, 2022
#21707) * Revert "Revert "Fix status report handling in write handler (#21440)" (#21701)" This reverts commit 5ab5be3. * Fix nrf test in nrf test, somehow CONFIG_BUILD_FOR_HOST_UNIT_TEST is disabled, need to disable this test in nrf tests apply restyle * Update src/app/WriteHandler.cpp Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…)" (project-chip#21701) This reverts commit 75ffda4.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…chip#21440)"… (project-chip#21707) * Revert "Revert "Fix status report handling in write handler (project-chip#21440)" (project-chip#21701)" This reverts commit 5ab5be3. * Fix nrf test in nrf test, somehow CONFIG_BUILD_FOR_HOST_UNIT_TEST is disabled, need to disable this test in nrf tests apply restyle * Update src/app/WriteHandler.cpp Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix status response handler in ReadHandler
This PR is cut from #19356
Change overview
When receiving unknown message in write handler, write handler would send status response with invalid action.
Testing
Write client sends out the chunked write request and receive response, then inject the unknown report message in write handler side, write handler would send status response with invalid action.