Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix status response handling in write handler" #21701

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Revert "Fix status response handling in write handler" #21701

merged 1 commit into from
Aug 6, 2022

Conversation

woody-apple
Copy link
Contributor

Reverts #21440

@woody-apple woody-apple enabled auto-merge (squash) August 6, 2022 16:57
@woody-apple
Copy link
Contributor Author

@yunhanw-google

@woody-apple woody-apple added hotfix urgent fix needed, can bypass review fast track labels Aug 6, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022 •
edited
Loading

PR #21701: Size comparison from 75ffda4 to 9cc7245

Increases (6 builds for cc13x2_26x2)
platform target config section 75ffda4 9cc7245 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180576 180608 32 0.0
lock-ftd LP_CC2652R7 (read/write) 168916 168948 32 0.0
lock-mtd LP_CC2652R7 (read/write) 182116 182148 32 0.0
pump-app LP_CC2652R7 (read/write) 159552 159584 32 0.0
pump-controller-app LP_CC2652R7 (read/write) 175224 175256 32 0.0
shell LP_CC2652R7 (read/write) 183420 183452 32 0.0
Decreases (16 builds for bl602, cc13x2_26x2, esp32, mbed, p6)
platform target config section 75ffda4 9cc7245 change % change
bl602 lighting-app bl602 (read/write) 1379682 1379634 -48 -0.0
.text 1047920 1047876 -44 -0.0
bl602+rpc (read/write) 1424938 1424890 -48 -0.0
.text 1079424 1079376 -48 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670807 670775 -32 -0.0
.text 582020 581988 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636343 636311 -32 -0.0
.text 558292 558260 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 672651 672619 -32 -0.0
.text 595760 595728 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 655139 655107 -32 -0.0
.text 553352 553320 -32 -0.0
pump-app LP_CC2652R7 (read only) 682823 682791 -32 -0.0
.text 593092 593060 -32 -0.0
pump-controller-app LP_CC2652R7 (read only) 667287 667255 -32 -0.0
.text 582016 581984 -32 -0.0
shell LP_CC2652R7 (read only) 663482 663450 -32 -0.0
.text 577748 577716 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1025886 1025862 -24 -0.0
.flash.text 1025886 1025862 -24 -0.0
m5stack (read only) 1079191 1079155 -36 -0.0
.flash.text 1073807 1073771 -36 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452456 2452392 -64 -0.0
.text 1415100 1415036 -64 -0.0
p6 all-clusters-app default (read/write) 1690804 1690756 -48 -0.0
.text 1530600 1530552 -48 -0.0
all-clusters-minimal-app default (read/write) 1634996 1634948 -48 -0.0
.text 1475512 1475464 -48 -0.0
light-app default (read/write) 1553716 1553668 -48 -0.0
.text 1402552 1402504 -48 -0.0
lock-app default (read/write) 1591004 1590956 -48 -0.0
.text 1435344 1435296 -48 -0.0
Full report (16 builds for bl602, cc13x2_26x2, esp32, mbed, p6)
platform target config section 75ffda4 9cc7245 change % change
bl602 lighting-app bl602 (read/write) 1379682 1379634 -48 -0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047920 1047876 -44 -0.0
bl602+rpc (read/write) 1424938 1424890 -48 -0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079424 1079376 -48 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670807 670775 -32 -0.0
(read/write) 180576 180608 32 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 582020 581988 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636343 636311 -32 -0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558292 558260 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 672651 672619 -32 -0.0
(read/write) 168916 168948 32 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595760 595728 -32 -0.0
lock-mtd LP_CC2652R7 (read only) 655139 655107 -32 -0.0
(read/write) 182116 182148 32 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101307 101307 0 0.0
.text 553352 553320 -32 -0.0
pump-app LP_CC2652R7 (read only) 682823 682791 -32 -0.0
(read/write) 159552 159584 32 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89247 0 0.0
.text 593092 593060 -32 -0.0
pump-controller-app LP_CC2652R7 (read only) 667287 667255 -32 -0.0
(read/write) 175224 175256 32 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84791 0 0.0
.text 582016 581984 -32 -0.0
shell LP_CC2652R7 (read only) 663482 663450 -32 -0.0
(read/write) 183420 183452 32 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577748 577716 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1025886 1025862 -24 -0.0
(read/write) 1487226 1487226 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216856 216856 0 0.0
.flash.text 1025886 1025862 -24 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079191 1079155 -36 -0.0
(read/write) 489232 489232 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247252 247252 0 0.0
.flash.text 1073807 1073771 -36 -0.0
.iram0.text 123267 123267 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452456 2452392 -64 -0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415100 1415036 -64 -0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690804 1690756 -48 -0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530600 1530552 -48 -0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634996 1634948 -48 -0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475512 1475464 -48 -0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553716 1553668 -48 -0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402552 1402504 -48 -0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591004 1590956 -48 -0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435344 1435296 -48 -0.0

@woody-apple woody-apple merged commit 5ab5be3 into master Aug 6, 2022
@woody-apple woody-apple deleted the revert-21440-feature/fix_write_handler branch August 6, 2022 19:55
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this pull request Aug 8, 2022
@yunhanw-google
Revert "Revert "Fix status report handling in write handler (project-…
0c7c4ce 
…chip#21440)" (project-chip#21701)"

This reverts commit 5ab5be3.
@yunhanw-google yunhanw-google mentioned this pull request Aug 8, 2022
Merged
yunhanw-google added a commit that referenced this pull request Aug 9, 2022
@yunhanw-google @bzbarsky-apple
Revert "Revert "Fix status report handling in write handler (#21440)"… (
7a981fd 
#21707)

* Revert "Revert "Fix status report handling in write handler (#21440)" (#21701)"

This reverts commit 5ab5be3.

* Fix nrf test

in nrf test, somehow CONFIG_BUILD_FOR_HOST_UNIT_TEST is disabled,
need to disable this test in nrf tests

apply restyle

* Update src/app/WriteHandler.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@woody-apple @isiu-apple
Revert "Fix status report handling in write handler (project-chip#21440…
e105070 
…)" (project-chip#21701)

This reverts commit 75ffda4.
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @bzbarsky-apple @isiu-apple
Revert "Revert "Fix status report handling in write handler (project-…
11a5d5d 
…chip#21440)"… (project-chip#21707)

* Revert "Revert "Fix status report handling in write handler (project-chip#21440)" (project-chip#21701)"

This reverts commit 5ab5be3.

* Fix nrf test

in nrf test, somehow CONFIG_BUILD_FOR_HOST_UNIT_TEST is disabled,
need to disable this test in nrf tests

apply restyle

* Update src/app/WriteHandler.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app fast track hotfix urgent fix needed, can bypass review review - pending tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woody-apple