Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status report handling in read handler #21374

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Fix status report handling in read handler #21374

merged 8 commits into from
Aug 8, 2022

Conversation

yunhanw-google
Copy link
Contributor

Problem

Fix status report in ReadHandler
This PR is cut from #19356

Change overview

When receiving status report in read handler, if message is malformed, the caller would send status report.
Refactor OnMessageReceived, it would send status report if sendStatusReport is set, and close the handler if any error is generated.

Testing

  1. Create the subscription, after the handler sends out the first chunked
    report, client sends out invalid status report message, handler sends status report with invalid action and close
  2. Create the subscription, after the handler sends out the first chunked
    report, client sends out unknown message, handler sends status report with invalid action and close.
  3. Client sends out malformed read request or subscribe request, InteractionModel engine would send out status report with invalid action.

@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from bd3e88f to c098a67 Compare August 7, 2022 23:10
@github-actions
Copy link

github-actions bot commented Aug 7, 2022 •
edited
Loading

PR #21374: Size comparison from 9665a20 to c098a67

Increases (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 9665a20 c098a67 change % change
bl602 lighting-app bl602 (read/write) 1379634 1379690 56 0.0
.text 1047876 1047928 52 0.0
bl602+rpc (read/write) 1424890 1424946 56 0.0
.text 1079380 1079432 52 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636303 636343 40 0.0
.text 558252 558292 40 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672659 40 0.0
.text 595728 595768 40 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655139 32 0.0
.text 553320 553352 32 0.0
pump-app LP_CC2652R7 (read only) 682791 682815 24 0.0
.rodata 89247 89255 8 0.0
.text 593060 593076 16 0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667279 24 0.0
.rodata 84791 84799 8 0.0
.text 581984 582000 16 0.0
shell LP_CC2652R7 (read only) 663450 663490 40 0.0
.text 577716 577756 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
lock cyw930739m2evb_01 (read/write) 590310 590350 40 0.0
.app_xip_area 462328 462368 40 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096060 56 0.0
.text 961068 961124 56 0.0
BRD4161A+rpc (read/write) 1150268 1150324 56 0.0
.text 998436 998492 56 0.0
BRD4161A+rs911x (read/write) 985284 985356 72 0.0
.text 821024 821096 72 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135992 32 0.0
.text 989052 989084 32 0.0
window-app BRD4161A (read/write) 1087736 1087792 56 0.0
.text 951328 951384 56 0.0
esp32 all-clusters-app c3devkit (read only) 1025862 1025892 30 0.0
(read/write) 1487226 1487266 40 0.0
.flash.rodata 216856 216896 40 0.0
.flash.text 1025862 1025892 30 0.0
m5stack (read only) 1079155 1079159 4 0.0
(read/write) 489232 489248 16 0.0
.flash.rodata 247252 247268 16 0.0
.flash.text 1073771 1073775 4 0.0
k32w light k32w0+release (read/write) 643340 643372 32 0.0
.text 568856 568888 32 0.0
lock k32w0+release (read/write) 700676 700724 48 0.0
.text 625712 625760 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859340 16 0.0
.rodata 464508 464540 32 0.0
thermostat-no-ble arm64 (read only) 2349676 2349708 32 0.0
.rodata 139620 139652 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452392 2452472 80 0.0
.text 1415036 1415116 80 0.0
p6 all-clusters-app default (read/write) 1690756 1690812 56 0.0
.text 1530552 1530608 56 0.0
all-clusters-minimal-app default (read/write) 1634948 1635020 72 0.0
.text 1475464 1475536 72 0.0
light-app default (read/write) 1553668 1553740 72 0.0
.text 1402504 1402576 72 0.0
lock-app default (read/write) 1590956 1591028 72 0.0
.text 1435296 1435368 72 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805908 72 0.0
text 569644 569674 30 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827716 72 0.0
text 587618 587648 30 0.0
Decreases (7 builds for cc13x2_26x2, linux)
platform target config section 9665a20 c098a67 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180576 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168908 -40 -0.0
lock-mtd LP_CC2652R7 (read/write) 182148 182116 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159584 159560 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175256 175232 -24 -0.0
shell LP_CC2652R7 (read/write) 183452 183412 -40 -0.0
linux chip-tool-ipv6only arm64 .text 7767524 7767508 -16 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 9665a20 c098a67 change % change
bl602 lighting-app bl602 (read/write) 1379634 1379690 56 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047876 1047928 52 0.0
bl602+rpc (read/write) 1424890 1424946 56 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079380 1079432 52 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670807 32 0.0
(read/write) 180608 180576 -32 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582020 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636303 636343 40 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558252 558292 40 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672659 40 0.0
(read/write) 168948 168908 -40 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595768 40 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655139 32 0.0
(read/write) 182148 182116 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101307 101307 0 0.0
.text 553320 553352 32 0.0
pump-app LP_CC2652R7 (read only) 682791 682815 24 0.0
(read/write) 159584 159560 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89255 8 0.0
.text 593060 593076 16 0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667279 24 0.0
(read/write) 175256 175232 -24 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84799 8 0.0
.text 581984 582000 16 0.0
shell LP_CC2652R7 (read only) 663450 663490 40 0.0
(read/write) 183452 183412 -40 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577756 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584422 32 0.0
.app_xip_area 461192 461224 32 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590350 40 0.0
.app_xip_area 462328 462368 40 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589410 32 0.0
.app_xip_area 466996 467028 32 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096060 56 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961068 961124 56 0.0
BRD4161A+rpc (read/write) 1150268 1150324 56 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998436 998492 56 0.0
BRD4161A+rs911x (read/write) 985284 985356 72 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821024 821096 72 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135992 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989052 989084 32 0.0
window-app BRD4161A (read/write) 1087736 1087792 56 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951328 951384 56 0.0
esp32 all-clusters-app c3devkit (read only) 1025862 1025892 30 0.0
(read/write) 1487226 1487266 40 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216856 216896 40 0.0
.flash.text 1025862 1025892 30 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079155 1079159 4 0.0
(read/write) 489232 489248 16 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247252 247268 16 0.0
.flash.text 1073771 1073775 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643340 643372 32 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568856 568888 32 0.0
lock k32w0+release (read/write) 700676 700724 48 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625712 625760 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859340 16 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464508 464540 32 0.0
.text 7767524 7767508 -16 -0.0
thermostat-no-ble arm64 (read only) 2349676 2349708 32 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139620 139652 32 0.0
.text 1972544 1972544 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452392 2452472 80 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415036 1415116 80 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690756 1690812 56 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530552 1530608 56 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634948 1635020 72 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475464 1475536 72 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553668 1553740 72 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402504 1402576 72 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1590956 1591028 72 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435296 1435368 72 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805908 72 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569644 569674 30 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827716 72 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587618 587648 30 0.0

@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from 9665a20 to 7e4859c

Increases (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 9665a20 7e4859c change % change
bl602 lighting-app bl602 (read/write) 1379634 1379666 32 0.0
.text 1047876 1047908 32 0.0
bl602+rpc (read/write) 1424890 1424922 32 0.0
.text 1079380 1079408 28 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636303 636335 32 0.0
.text 558252 558284 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655131 24 0.0
.text 553320 553344 24 0.0
pump-app LP_CC2652R7 (read only) 682791 682807 16 0.0
.rodata 89247 89255 8 0.0
.text 593060 593068 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667271 16 0.0
.rodata 84791 84799 8 0.0
.text 581984 581992 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584406 16 0.0
.app_xip_area 461192 461208 16 0.0
lock cyw930739m2evb_01 (read/write) 590310 590334 24 0.0
.app_xip_area 462328 462352 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096044 40 0.0
.text 961068 961108 40 0.0
BRD4161A+rpc (read/write) 1150268 1150308 40 0.0
.text 998436 998476 40 0.0
BRD4161A+rs911x (read/write) 985284 985340 56 0.0
.text 821024 821080 56 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135992 32 0.0
.text 989052 989084 32 0.0
window-app BRD4161A (read/write) 1087736 1087776 40 0.0
.text 951328 951368 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025862 1025876 14 0.0
(read/write) 1487226 1487266 40 0.0
.flash.rodata 216856 216896 40 0.0
.flash.text 1025862 1025876 14 0.0
m5stack (read/write) 489232 489248 16 0.0
.flash.rodata 247252 247268 16 0.0
k32w light k32w0+release (read/write) 643340 643356 16 0.0
.text 568856 568872 16 0.0
lock k32w0+release (read/write) 700676 700708 32 0.0
.text 625712 625744 32 0.0
linux chip-tool-ipv6only arm64 .rodata 464508 464540 32 0.0
thermostat-no-ble arm64 .rodata 139620 139652 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452392 2452472 80 0.0
.text 1415036 1415116 80 0.0
p6 all-clusters-app default (read/write) 1690756 1690796 40 0.0
.text 1530552 1530592 40 0.0
all-clusters-minimal-app default (read/write) 1634948 1635004 56 0.0
.text 1475464 1475520 56 0.0
light-app default (read/write) 1553668 1553724 56 0.0
.text 1402504 1402560 56 0.0
lock-app default (read/write) 1590956 1591012 56 0.0
.text 1435296 1435352 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805892 56 0.0
text 569644 569660 16 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827708 64 0.0
text 587618 587638 20 0.0
Decreases (9 builds for cc13x2_26x2, esp32, linux)
platform target config section 9665a20 7e4859c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182148 182124 -24 -0.0
pump-app LP_CC2652R7 (read/write) 159584 159568 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175256 175240 -16 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
esp32 all-clusters-app m5stack (read only) 1079155 1079151 -4 -0.0
.flash.text 1073771 1073767 -4 -0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859308 -16 -0.0
.text 7767524 7767476 -48 -0.0
thermostat-no-ble arm64 (read only) 2349676 2349660 -16 -0.0
.text 1972544 1972496 -48 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 9665a20 7e4859c change % change
bl602 lighting-app bl602 (read/write) 1379634 1379666 32 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047876 1047908 32 0.0
bl602+rpc (read/write) 1424890 1424922 32 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079380 1079408 28 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636303 636335 32 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558252 558284 32 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655107 655131 24 0.0
(read/write) 182148 182124 -24 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101307 101307 0 0.0
.text 553320 553344 24 0.0
pump-app LP_CC2652R7 (read only) 682791 682807 16 0.0
(read/write) 159584 159568 -16 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89247 89255 8 0.0
.text 593060 593068 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667255 667271 16 0.0
(read/write) 175256 175240 -16 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84791 84799 8 0.0
.text 581984 581992 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584406 16 0.0
.app_xip_area 461192 461208 16 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590334 24 0.0
.app_xip_area 462328 462352 24 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096004 1096044 40 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961068 961108 40 0.0
BRD4161A+rpc (read/write) 1150268 1150308 40 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998436 998476 40 0.0
BRD4161A+rs911x (read/write) 985284 985340 56 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821024 821080 56 0.0
lock-app BRD4161A+wf200 (read/write) 1135960 1135992 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989052 989084 32 0.0
window-app BRD4161A (read/write) 1087736 1087776 40 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951328 951368 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025862 1025876 14 0.0
(read/write) 1487226 1487266 40 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216856 216896 40 0.0
.flash.text 1025862 1025876 14 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079155 1079151 -4 -0.0
(read/write) 489232 489248 16 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247252 247268 16 0.0
.flash.text 1073771 1073767 -4 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643340 643356 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568856 568872 16 0.0
lock k32w0+release (read/write) 700676 700708 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625712 625744 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9859324 9859308 -16 -0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464508 464540 32 0.0
.text 7767524 7767476 -48 -0.0
thermostat-no-ble arm64 (read only) 2349676 2349660 -16 -0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139620 139652 32 0.0
.text 1972544 1972496 -48 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452392 2452472 80 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415036 1415116 80 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690756 1690796 40 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530552 1530592 40 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634948 1635004 56 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475464 1475520 56 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553668 1553724 56 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402504 1402560 56 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1590956 1591012 56 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435296 1435352 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805836 805892 56 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569644 569660 16 0.0
lighting-app tlsr9518adk80d (read/write) 827644 827708 64 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587618 587638 20 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from 7e4859c to c815a20 Compare August 8, 2022 07:20
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from b52e56d to c815a20

Increases (27 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section b52e56d c815a205 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.text 1047900 1047928 28 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700764 700780 16 0.0
.text 625800 625816 16 0.0
linux chip-tool-ipv6only arm64 .rodata 464556 464604 48 0.0
lighting-app debug+rpc .rodata 218736 218768 32 0.0
lock-app debug .rodata 235696 235728 32 0.0
ota-provider-app debug .rodata 207896 207928 32 0.0
thermostat-no-ble arm64 .rodata 139668 139716 48 0.0
tv-app debug .rodata 257608 257640 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2452520 16 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read/write) 1690828 1690868 40 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read/write) 1635020 1635076 56 0.0
.text 1475536 1475592 56 0.0
light-app default (read/write) 1553740 1553796 56 0.0
.text 1402576 1402632 56 0.0
lock-app default (read/write) 1591028 1591084 56 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
text 569664 569682 18 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
text 587636 587658 22 0.0
Decreases (19 builds for cc13x2_26x2, linux)
platform target config section b52e56d c815a205 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159496 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175168 -24 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10444817 10444705 -112 -0.0
.text 8415252 8415140 -112 -0.0
chip-tool-ipv6only arm64 .text 7767572 7767524 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 .text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
.text 4794130 4794002 -128 -0.0
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section b52e56d c815a205 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047928 28 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
(read/write) 159520 159496 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
(read/write) 175192 175168 -24 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700764 700780 16 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625800 625816 16 0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10444817 10444705 -112 -0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 533205 533205 0 0.0
.text 8415252 8415140 -112 -0.0
chip-tool-ipv6only arm64 (read only) 9859420 9859420 0 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464556 464604 48 0.0
.text 7767572 7767524 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218768 32 0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235728 32 0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207928 32 0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 (read only) 2349772 2349772 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139716 48 0.0
.text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257640 32 0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794002 -128 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452520 16 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690868 40 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635076 56 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475592 56 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553796 56 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402632 56 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591084 56 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569664 569682 18 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587658 22 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from c815a20 to 2493526 Compare August 8, 2022 08:09
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from b52e56d to 2493526

Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section b52e56d 2493526 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.text 1047900 1047928 28 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682871 16 0.0
.rodata 89295 89311 16 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.text 951400 951440 40 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700764 700780 16 0.0
.text 625800 625816 16 0.0
linux chip-tool-ipv6only arm64 .rodata 464556 464604 48 0.0
lighting-app debug+rpc .rodata 218736 218768 32 0.0
lock-app debug .rodata 235696 235728 32 0.0
ota-provider-app debug .rodata 207896 207928 32 0.0
thermostat-no-ble arm64 .rodata 139668 139716 48 0.0
tv-app debug .rodata 257608 257640 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2452520 16 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read/write) 1690828 1690868 40 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read/write) 1635020 1635076 56 0.0
.text 1475536 1475592 56 0.0
light-app default (read/write) 1553740 1553796 56 0.0
.text 1402576 1402632 56 0.0
lock-app default (read/write) 1591028 1591084 56 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
text 569664 569680 16 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
text 587636 587654 18 0.0
Decreases (19 builds for cc13x2_26x2, linux)
platform target config section b52e56d 2493526 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159504 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175168 -24 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10444817 10444705 -112 -0.0
.text 8415252 8415140 -112 -0.0
chip-tool-ipv6only arm64 .text 7767572 7767524 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 .text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
.text 4794130 4794002 -128 -0.0
Full report (39 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section b52e56d 2493526 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047928 28 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682871 16 0.0
(read/write) 159520 159504 -16 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89311 16 0.0
.text 593076 593076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
(read/write) 175192 175168 -24 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951440 40 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700764 700780 16 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625800 625816 16 0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10444817 10444705 -112 -0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 533205 533205 0 0.0
.text 8415252 8415140 -112 -0.0
chip-tool-ipv6only arm64 (read only) 9859420 9859420 0 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464556 464604 48 0.0
.text 7767572 7767524 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218768 32 0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235728 32 0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207928 32 0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 (read only) 2349772 2349772 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139716 48 0.0
.text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257640 32 0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794002 -128 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452520 16 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690868 40 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635076 56 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475592 56 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553796 56 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402632 56 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591084 56 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569664 569680 16 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587654 18 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from 2493526 to 8fdfc06 Compare August 8, 2022 09:01
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from b52e56d to 8fdfc06

Increases (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section b52e56d 8fdfc06 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.text 1047900 1047928 28 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.text 951400 951440 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025886 12 0.0
(read/write) 1487282 1487322 40 0.0
.flash.rodata 216912 216952 40 0.0
.flash.text 1025874 1025886 12 0.0
m5stack (read/write) 489288 489304 16 0.0
.flash.rodata 247308 247324 16 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700764 700780 16 0.0
.text 625800 625816 16 0.0
linux chip-tool-ipv6only arm64 .rodata 464556 464604 48 0.0
lighting-app debug+rpc .rodata 218736 218768 32 0.0
lock-app debug .rodata 235696 235728 32 0.0
ota-provider-app debug .rodata 207896 207928 32 0.0
thermostat-no-ble arm64 .rodata 139668 139716 48 0.0
tv-app debug .rodata 257608 257640 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2452520 16 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read/write) 1690828 1690868 40 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read/write) 1635020 1635076 56 0.0
.text 1475536 1475592 56 0.0
light-app default (read/write) 1553740 1553796 56 0.0
.text 1402576 1402632 56 0.0
lock-app default (read/write) 1591028 1591084 56 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
text 569664 569682 18 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
text 587636 587656 20 0.0
Decreases (20 builds for cc13x2_26x2, esp32, linux)
platform target config section b52e56d 8fdfc06 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159496 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175168 -24 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
esp32 all-clusters-app m5stack (read only) 1079171 1079163 -8 -0.0
.flash.text 1073787 1073779 -8 -0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10444817 10444705 -112 -0.0
.text 8415252 8415140 -112 -0.0
chip-tool-ipv6only arm64 .text 7767572 7767524 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 .text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
.text 4794130 4794002 -128 -0.0
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section b52e56d 8fdfc06 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047928 28 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
(read/write) 159520 159496 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
(read/write) 175192 175168 -24 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951440 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025886 12 0.0
(read/write) 1487282 1487322 40 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 216952 40 0.0
.flash.text 1025874 1025886 12 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079163 -8 -0.0
(read/write) 489288 489304 16 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247324 16 0.0
.flash.text 1073787 1073779 -8 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700764 700780 16 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625800 625816 16 0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10444817 10444705 -112 -0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 533205 533205 0 0.0
.text 8415252 8415140 -112 -0.0
chip-tool-ipv6only arm64 (read only) 9859420 9859420 0 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 464556 464604 48 0.0
.text 7767572 7767524 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218768 32 0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235728 32 0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207928 32 0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 (read only) 2349772 2349772 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139716 48 0.0
.text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257640 32 0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794002 -128 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452520 16 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690868 40 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635076 56 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475592 56 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553796 56 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402632 56 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591084 56 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569664 569682 18 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587656 20 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from 8fdfc06 to bd924a8 Compare August 8, 2022 15:57
@yunhanw-google yunhanw-google disabled auto-merge August 8, 2022 16:07
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from 71c74b6 to bd924a8

Increases (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 71c74b6 bd924a8 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.text 1047900 1047932 32 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655195 24 0.0
.text 553336 553360 24 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.text 951400 951440 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025886 12 0.0
(read/write) 1487282 1487322 40 0.0
.flash.rodata 216912 216952 40 0.0
.flash.text 1025874 1025886 12 0.0
m5stack (read/write) 489288 489304 16 0.0
.flash.rodata 247308 247324 16 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700748 700780 32 0.0
.text 625784 625816 32 0.0
linux chip-tool debug .rodata 534965 534997 32 0.0
chip-tool-ipv6only arm64 .rodata 466284 466332 48 0.0
lighting-app debug+rpc .rodata 218736 218768 32 0.0
lock-app debug .rodata 235696 235728 32 0.0
ota-provider-app debug .rodata 207896 207928 32 0.0
thermostat-no-ble arm64 .rodata 139668 139716 48 0.0
tv-app debug .rodata 257608 257640 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2452520 16 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read/write) 1690828 1690868 40 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read/write) 1635020 1635076 56 0.0
.text 1475536 1475592 56 0.0
light-app default (read/write) 1553740 1553796 56 0.0
.text 1402576 1402632 56 0.0
lock-app default (read/write) 1591028 1591084 56 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
text 569662 569684 22 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
text 587636 587658 22 0.0
Decreases (20 builds for cc13x2_26x2, esp32, linux)
platform target config section 71c74b6 bd924a8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182060 -24 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159496 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175168 -24 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
esp32 all-clusters-app m5stack (read only) 1079171 1079163 -8 -0.0
.flash.text 1073787 1073779 -8 -0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10472977 10472881 -96 -0.0
.text 8439348 8439220 -128 -0.0
chip-tool-ipv6only arm64 .text 7788772 7788724 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 .text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
.text 4794130 4794002 -128 -0.0
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 71c74b6 bd924a8 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1047932 32 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636335 24 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558284 24 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655195 24 0.0
(read/write) 182084 182060 -24 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553360 24 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
(read/write) 159520 159496 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
(read/write) 175192 175168 -24 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951440 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025886 12 0.0
(read/write) 1487282 1487322 40 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 216952 40 0.0
.flash.text 1025874 1025886 12 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079163 -8 -0.0
(read/write) 489288 489304 16 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247324 16 0.0
.flash.text 1073787 1073779 -8 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700748 700780 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625784 625816 32 0.0
linux all-clusters-app debug (read only) 3022857 3022729 -128 -0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2571154 2571026 -128 -0.0
all-clusters-minimal-app debug (read only) 2864721 2864593 -128 -0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415554 2415426 -128 -0.0
bridge-app debug+rpc (read only) 2363993 2363865 -128 -0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999426 1999298 -128 -0.0
chip-tool debug (read only) 10472977 10472881 -96 -0.0
(read/write) 647424 647424 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 612776 612776 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 534965 534997 32 0.0
.text 8439348 8439220 -128 -0.0
chip-tool-ipv6only arm64 (read only) 9884684 9884684 0 0.0
(read/write) 695121 695121 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640336 640336 0 0.0
.dynamic 560 560 0 0.0
.got 13648 13648 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466284 466332 48 0.0
.text 7788772 7788724 -48 -0.0
lighting-app debug+rpc (read only) 2587625 2587529 -96 -0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218768 32 0.0
.text 2198322 2198194 -128 -0.0
lock-app debug (read only) 2571825 2571729 -96 -0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235728 32 0.0
.text 2169618 2169490 -128 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207928 32 0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473449 2473321 -128 -0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089010 2088882 -128 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 (read only) 2349772 2349772 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139716 48 0.0
.text 1972592 1972544 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257640 32 0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5402625 5402497 -128 -0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794130 4794002 -128 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452520 16 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415164 16 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690868 40 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635076 56 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475592 56 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553796 56 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402632 56 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591084 56 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 569684 22 0.0
lighting-app tlsr9518adk80d (read/write) 827712 827776 64 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 587658 22 0.0

@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from 71c74b6 to 1b57c8d

Increases above 0.2%:

platform target config section 71c74b6 1b57c8d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 88471 88911 440 0.5
all-clusters-minimal-app LP_CC2652R7 .rodata 77727 78167 440 0.6
lock-ftd LP_CC2652R7 .rodata 76411 76851 440 0.6
lock-mtd LP_CC2652R7 .rodata 101355 101803 448 0.4
pump-app LP_CC2652R7 .rodata 89295 89751 456 0.5
pump-controller-app LP_CC2652R7 .rodata 84839 85295 456 0.5
shell LP_CC2652R7 .rodata 85418 85858 440 0.5
linux bridge-app debug+rpc .rodata 202088 202536 448 0.2
lighting-app debug+rpc .rodata 218736 219184 448 0.2
lock-app debug .rodata 235696 236176 480 0.2
ota-provider-app debug .rodata 207896 208344 448 0.2
ota-requestor-app debug .rodata 212448 212896 448 0.2
thermostat-no-ble arm64 .rodata 139668 140148 480 0.3
Increases (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 71c74b6 1b57c8d change % change
bl602 lighting-app bl602 (read/write) 1379714 1380530 816 0.1
.text 1047900 1048260 360 0.0
bl602+rpc (read/write) 1424970 1425786 816 0.1
.text 1079400 1079764 364 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 671575 800 0.1
.rodata 88471 88911 440 0.5
.text 581988 582348 360 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 637111 800 0.1
.rodata 77727 78167 440 0.6
.text 558260 558620 360 0.1
lock-ftd LP_CC2652R7 (read only) 672619 673427 808 0.1
.rodata 76411 76851 440 0.6
.text 595728 596096 368 0.1
lock-mtd LP_CC2652R7 (read only) 655171 655979 808 0.1
.rodata 101355 101803 448 0.4
.text 553336 553696 360 0.1
pump-app LP_CC2652R7 (read only) 682855 683655 800 0.1
.rodata 89295 89751 456 0.5
.text 593076 593420 344 0.1
pump-controller-app LP_CC2652R7 (read only) 667319 668119 800 0.1
.rodata 84839 85295 456 0.5
.text 582000 582344 344 0.1
shell LP_CC2652R7 (read only) 663450 664258 808 0.1
.rodata 85418 85858 440 0.5
.text 577716 578084 368 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 590178 800 0.1
.app_xip_area 466996 467796 800 0.2
k32w light k32w0+release (read/write) 643372 643772 400 0.1
.text 568888 569288 400 0.1
lock k32w0+release (read/write) 700748 701556 808 0.1
.text 625784 626592 808 0.1
linux all-clusters-app debug (read only) 3022857 3023689 832 0.0
.rodata 272843 273291 448 0.2
.text 2571154 2571538 384 0.0
all-clusters-minimal-app debug (read only) 2864721 2865569 848 0.0
.rodata 272939 273387 448 0.2
.text 2415554 2415954 400 0.0
bridge-app debug+rpc (read only) 2363993 2364825 832 0.0
.rodata 202088 202536 448 0.2
.text 1999426 1999810 384 0.0
chip-tool debug .rodata 534965 535413 448 0.1
chip-tool-ipv6only arm64 .rodata 466284 466732 448 0.1
lighting-app debug+rpc (read only) 2587625 2588457 832 0.0
.rodata 218736 219184 448 0.2
.text 2198322 2198706 384 0.0
lock-app debug (read only) 2571825 2572689 864 0.0
.rodata 235696 236176 480 0.2
.text 2169618 2170002 384 0.0
ota-provider-app debug (read only) 2349409 2350241 832 0.0
.rodata 207896 208344 448 0.2
.text 1978162 1978546 384 0.0
ota-requestor-app debug (read only) 2473449 2474281 832 0.0
.rodata 212448 212896 448 0.2
.text 2089010 2089394 384 0.0
shell debug (read only) 2593457 2594289 832 0.0
.rodata 233330 233778 448 0.2
.text 2201922 2202306 384 0.0
thermostat-no-ble arm64 (read only) 2349772 2350588 816 0.0
.rodata 139668 140148 480 0.3
.text 1972592 1972928 336 0.0
tv-app debug (read only) 3167265 3168097 832 0.0
.rodata 257608 258056 448 0.2
.text 2719890 2720274 384 0.0
tv-casting-app debug (read only) 5402625 5403457 832 0.0
.rodata 340529 340977 448 0.1
.text 4794130 4794514 384 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2453280 776 0.0
.text 1415148 1415924 776 0.1
p6 all-clusters-app default (read/write) 1690828 1691612 784 0.0
.text 1530624 1531408 784 0.1
all-clusters-minimal-app default (read/write) 1635020 1635804 784 0.0
.text 1475536 1476320 784 0.1
light-app default (read/write) 1553740 1554540 800 0.1
.text 1402576 1403376 800 0.1
lock-app default (read/write) 1591028 1591828 800 0.1
.text 1435368 1436168 800 0.1
telink light-switch-app tlsr9518adk80d (read/write) 805912 806812 900 0.1
text 569662 570062 400 0.1
lighting-app tlsr9518adk80d (read/write) 827712 828612 900 0.1
text 587636 588036 400 0.1
Decreases (8 builds for cc13x2_26x2, linux)
platform target config section 71c74b6 1b57c8d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 179808 -800 -0.4
lock-ftd LP_CC2652R7 (read/write) 168948 168140 -808 -0.5
lock-mtd LP_CC2652R7 (read/write) 182084 181276 -808 -0.4
pump-app LP_CC2652R7 (read/write) 159520 158720 -800 -0.5
pump-controller-app LP_CC2652R7 (read/write) 175192 174392 -800 -0.5
shell LP_CC2652R7 (read/write) 183452 182644 -808 -0.4
linux chip-tool debug (read only) 10472977 10469249 -3728 -0.0
(read/write) 647424 646464 -960 -0.1
.data.rel.ro 612776 611800 -976 -0.2
.text 8439348 8437476 -1872 -0.0
chip-tool-ipv6only arm64 (read only) 9884684 9880988 -3696 -0.0
(read/write) 695121 694145 -976 -0.1
.data.rel.ro 640336 639360 -976 -0.2
.got 13648 13640 -8 -0.1
.text 7788772 7786964 -1808 -0.0
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 71c74b6 1b57c8d change % change
bl602 lighting-app bl602 (read/write) 1379714 1380530 816 0.1
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047900 1048260 360 0.0
bl602+rpc (read/write) 1424970 1425786 816 0.1
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079764 364 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 671575 800 0.1
(read/write) 180608 179808 -800 -0.4
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88911 440 0.5
.text 581988 582348 360 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 637111 800 0.1
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 78167 440 0.6
.text 558260 558620 360 0.1
lock-ftd LP_CC2652R7 (read only) 672619 673427 808 0.1
(read/write) 168948 168140 -808 -0.5
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76851 440 0.6
.text 595728 596096 368 0.1
lock-mtd LP_CC2652R7 (read only) 655171 655979 808 0.1
(read/write) 182084 181276 -808 -0.4
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101803 448 0.4
.text 553336 553696 360 0.1
pump-app LP_CC2652R7 (read only) 682855 683655 800 0.1
(read/write) 159520 158720 -800 -0.5
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89751 456 0.5
.text 593076 593420 344 0.1
pump-controller-app LP_CC2652R7 (read only) 667319 668119 800 0.1
(read/write) 175192 174392 -800 -0.5
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 85295 456 0.5
.text 582000 582344 344 0.1
shell LP_CC2652R7 (read only) 663450 664258 808 0.1
(read/write) 183452 182644 -808 -0.4
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85858 440 0.5
.text 577716 578084 368 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 590178 800 0.1
.app_xip_area 466996 467796 800 0.2
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w0+release (read/write) 643372 643772 400 0.1
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 569288 400 0.1
lock k32w0+release (read/write) 700748 701556 808 0.1
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625784 626592 808 0.1
linux all-clusters-app debug (read only) 3022857 3023689 832 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 273291 448 0.2
.text 2571154 2571538 384 0.0
all-clusters-minimal-app debug (read only) 2864721 2865569 848 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 273387 448 0.2
.text 2415554 2415954 400 0.0
bridge-app debug+rpc (read only) 2363993 2364825 832 0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202536 448 0.2
.text 1999426 1999810 384 0.0
chip-tool debug (read only) 10472977 10469249 -3728 -0.0
(read/write) 647424 646464 -960 -0.1
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 612776 611800 -976 -0.2
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 534965 535413 448 0.1
.text 8439348 8437476 -1872 -0.0
chip-tool-ipv6only arm64 (read only) 9884684 9880988 -3696 -0.0
(read/write) 695121 694145 -976 -0.1
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640336 639360 -976 -0.2
.dynamic 560 560 0 0.0
.got 13648 13640 -8 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466284 466732 448 0.1
.text 7788772 7786964 -1808 -0.0
lighting-app debug+rpc (read only) 2587625 2588457 832 0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 219184 448 0.2
.text 2198322 2198706 384 0.0
lock-app debug (read only) 2571825 2572689 864 0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 236176 480 0.2
.text 2169618 2170002 384 0.0
ota-provider-app debug (read only) 2349409 2350241 832 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 208344 448 0.2
.text 1978162 1978546 384 0.0
ota-requestor-app debug (read only) 2473449 2474281 832 0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212896 448 0.2
.text 2089010 2089394 384 0.0
shell debug (read only) 2593457 2594289 832 0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233778 448 0.2
.text 2201922 2202306 384 0.0
thermostat-no-ble arm64 (read only) 2349772 2350588 816 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 140148 480 0.3
.text 1972592 1972928 336 0.0
tv-app debug (read only) 3167265 3168097 832 0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 258056 448 0.2
.text 2719890 2720274 384 0.0
tv-casting-app debug (read only) 5402625 5403457 832 0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340977 448 0.1
.text 4794130 4794514 384 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2453280 776 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415924 776 0.1
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1691612 784 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1531408 784 0.1
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635804 784 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1476320 784 0.1
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1554540 800 0.1
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1403376 800 0.1
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591828 800 0.1
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1436168 800 0.1
telink light-switch-app tlsr9518adk80d (read/write) 805912 806812 900 0.1
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 570062 400 0.1
lighting-app tlsr9518adk80d (read/write) 827712 828612 900 0.1
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587636 588036 400 0.1

@yunhanw-google
Fix
ab11812 
1. Once message is passed to OnReadInitialRequest in read handler, if
   anything bad in incoming message, handler would send status report
   with invalid action, if there is not enough resource for paths in IM
   engines, we would send status report with exhansted path.
2. Fix fake build in linux,  it seems this build don't have IM schema check.
Usually without CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK, if schema error
happens, we would get a little bit more detailed error, here, we add
additional error check in TestReadHandlerInvalidAttributePath.
@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from 1b57c8d to ab11812 Compare August 8, 2022 18:24
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from c3cc4a2 to ab11812

Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c3cc4a2 ab11812 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.text 1047896 1047928 32 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636327 16 0.0
.text 558260 558276 16 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.text 951400 951440 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025886 12 0.0
(read/write) 1487282 1487322 40 0.0
.flash.rodata 216912 216952 40 0.0
.flash.text 1025874 1025886 12 0.0
m5stack (read/write) 489288 489304 16 0.0
.flash.rodata 247308 247324 16 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700748 700780 32 0.0
.text 625784 625816 32 0.0
linux chip-tool-ipv6only arm64 .rodata 466252 466300 48 0.0
thermostat-no-ble arm64 .rodata 139668 139716 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2452520 16 0.0
.text 1415148 1415164 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177775 12 0.0
rodata 142756 142768 12 0.0
text 812932 812940 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157831 12 0.0
rodata 134452 134464 12 0.0
text 802084 802092 8 0.0
p6 all-clusters-app default (read/write) 1690828 1690868 40 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read/write) 1635020 1635076 56 0.0
.text 1475536 1475592 56 0.0
light-app default (read/write) 1553740 1553796 56 0.0
.text 1402576 1402632 56 0.0
lock-app default (read/write) 1591028 1591084 56 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
text 569662 569682 20 0.0
lighting-app tlsr9518adk80d (read/write) 827720 827776 56 0.0
text 587638 587658 20 0.0
Decreases (9 builds for cc13x2_26x2, esp32, linux)
platform target config section c3cc4a2 ab11812 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180584 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168916 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182052 -32 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159496 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175168 -24 -0.0
shell LP_CC2652R7 (read/write) 183452 183420 -32 -0.0
esp32 all-clusters-app m5stack (read only) 1079171 1079163 -8 -0.0
.flash.text 1073787 1073779 -8 -0.0
linux chip-tool-ipv6only arm64 .text 7786644 7786596 -48 -0.0
thermostat-no-ble arm64 .text 1972592 1972544 -48 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c3cc4a2 ab11812 change % change
bl602 lighting-app bl602 (read/write) 1379714 1379746 32 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047896 1047928 32 0.0
bl602+rpc (read/write) 1424970 1425002 32 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079400 1079432 32 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670799 24 0.0
(read/write) 180608 180584 -24 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582012 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636327 16 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558276 16 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672651 32 0.0
(read/write) 168948 168916 -32 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595760 32 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655203 32 0.0
(read/write) 182084 182052 -32 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553368 32 0.0
pump-app LP_CC2652R7 (read only) 682855 682879 24 0.0
(read/write) 159520 159496 -24 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89311 16 0.0
.text 593076 593084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667343 24 0.0
(read/write) 175192 175168 -24 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84855 16 0.0
.text 582000 582008 8 0.0
shell LP_CC2652R7 (read only) 663450 663482 32 0.0
(read/write) 183452 183420 -32 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577748 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584414 24 0.0
.app_xip_area 461192 461216 24 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590342 32 0.0
.app_xip_area 462328 462360 32 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589402 24 0.0
.app_xip_area 466996 467020 24 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096068 1096108 40 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961132 961172 40 0.0
BRD4161A+rpc (read/write) 1150332 1150372 40 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998500 998540 40 0.0
BRD4161A+rs911x (read/write) 985356 985412 56 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821096 821152 56 0.0
lock-app BRD4161A+wf200 (read/write) 1136024 1136056 32 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989116 989148 32 0.0
window-app BRD4161A (read/write) 1087808 1087848 40 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951400 951440 40 0.0
esp32 all-clusters-app c3devkit (read only) 1025874 1025886 12 0.0
(read/write) 1487282 1487322 40 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216912 216952 40 0.0
.flash.text 1025874 1025886 12 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079171 1079163 -8 -0.0
(read/write) 489288 489304 16 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247308 247324 16 0.0
.flash.text 1073787 1073779 -8 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643372 643388 16 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568888 568904 16 0.0
lock k32w0+release (read/write) 700748 700780 32 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625784 625816 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9880188 9880188 0 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13640 13640 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466252 466300 48 0.0
.text 7786644 7786596 -48 -0.0
thermostat-no-ble arm64 (read only) 2349772 2349772 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139716 48 0.0
.text 1972592 1972544 -48 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452520 16 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415164 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177775 12 0.0
bss 143222 143222 0 0.0
rodata 142756 142768 12 0.0
text 812932 812940 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157831 12 0.0
bss 142460 142460 0 0.0
rodata 134452 134464 12 0.0
text 802084 802092 8 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690828 1690868 40 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530624 1530664 40 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635020 1635076 56 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475536 1475592 56 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553740 1553796 56 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402576 1402632 56 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591028 1591084 56 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435368 1435424 56 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805968 56 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569662 569682 20 0.0
lighting-app tlsr9518adk80d (read/write) 827720 827776 56 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587638 587658 20 0.0

bzbarsky-apple
bzbarsky-apple requested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested while I review the major update.

bzbarsky-apple
bzbarsky-apple approved these changes Aug 8, 2022
View reviewed changes
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
src/app/ReadHandler.cpp Outdated Show resolved Hide resolved
src/app/tests/TestReadInteraction.cpp Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/fix_read_handler_status_report branch from 3b71c55 to 4962d87 Compare August 8, 2022 21:28
@yunhanw-google yunhanw-google enabled auto-merge (squash) August 8, 2022 21:28
@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

PR #21374: Size comparison from 4b366e2 to 4962d87

Increases (35 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b366e2 4962d87 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670831 56 0.0
.text 581988 582044 56 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636367 56 0.0
.text 558260 558316 56 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672683 64 0.0
.text 595728 595792 64 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655227 56 0.0
.text 553336 553392 56 0.0
pump-app LP_CC2652R7 (read only) 682855 682911 56 0.0
.rodata 89295 89311 16 0.0
.text 593076 593116 40 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667375 56 0.0
.rodata 84839 84855 16 0.0
.text 582000 582040 40 0.0
shell LP_CC2652R7 (read only) 663450 663514 64 0.0
.text 577716 577780 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584446 56 0.0
.app_xip_area 461192 461248 56 0.0
lock cyw930739m2evb_01 (read/write) 590310 590374 64 0.0
.app_xip_area 462328 462392 64 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589434 56 0.0
.app_xip_area 466996 467052 56 0.0
efr32 lighting-app BRD4161A (read/write) 1096180 1096252 72 0.0
.text 961244 961316 72 0.0
BRD4161A+rpc (read/write) 1150444 1150516 72 0.0
.text 998612 998684 72 0.0
BRD4161A+rs911x (read/write) 985700 985788 88 0.0
.text 821440 821528 88 0.0
lock-app BRD4161A+wf200 (read/write) 1136272 1136336 64 0.0
.text 989364 989428 64 0.0
window-app BRD4161A (read/write) 1087912 1087984 72 0.0
.text 951504 951576 72 0.0
esp32 all-clusters-app c3devkit (read only) 1025886 1025924 38 0.0
(read/write) 1487370 1487410 40 0.0
.flash.rodata 217000 217040 40 0.0
.flash.text 1025886 1025924 38 0.0
m5stack (read only) 1079191 1079203 12 0.0
(read/write) 489368 489384 16 0.0
.flash.rodata 247388 247404 16 0.0
.flash.text 1073807 1073819 12 0.0
k32w light k32w0+release (read/write) 643484 643532 48 0.0
.text 569000 569048 48 0.0
lock k32w0+release (read/write) 700876 700940 64 0.0
.text 625912 625976 64 0.0
linux chip-tool debug .rodata 535445 535477 32 0.0
chip-tool-ipv6only arm64 .rodata 466764 466796 32 0.0
lighting-app debug+rpc .rodata 218736 218768 32 0.0
lock-app debug .rodata 235696 235728 32 0.0
ota-provider-app debug .rodata 207896 207928 32 0.0
thermostat-no-ble arm64 .rodata 139668 139716 48 0.0
tv-app debug .rodata 257608 257640 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452504 2452520 16 0.0
.text 1415148 1415164 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177807 44 0.0
rodata 142756 142768 12 0.0
text 812932 812968 36 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157863 44 0.0
rodata 134452 134464 12 0.0
text 802084 802128 44 0.0
p6 all-clusters-app default (read/write) 1690932 1691004 72 0.0
.text 1530728 1530800 72 0.0
all-clusters-minimal-app default (read/write) 1635132 1635220 88 0.0
.text 1475648 1475736 88 0.0
light-app default (read/write) 1553844 1553932 88 0.0
.text 1402680 1402768 88 0.0
lock-app default (read/write) 1591124 1591212 88 0.0
.text 1435464 1435552 88 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805992 80 0.0
text 569664 569708 44 0.0
lighting-app tlsr9518adk80d (read/write) 827720 827800 80 0.0
text 587640 587682 42 0.0
Decreases (19 builds for cc13x2_26x2, linux)
platform target config section 4b366e2 4962d87 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180608 180552 -56 -0.0
lock-ftd LP_CC2652R7 (read/write) 168948 168884 -64 -0.0
lock-mtd LP_CC2652R7 (read/write) 182084 182028 -56 -0.0
pump-app LP_CC2652R7 (read/write) 159520 159464 -56 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175192 175136 -56 -0.0
shell LP_CC2652R7 (read/write) 183452 183388 -64 -0.0
linux all-clusters-app debug (read only) 3024513 3024401 -112 -0.0
.text 2572738 2572626 -112 -0.0
all-clusters-minimal-app debug (read only) 2864737 2864625 -112 -0.0
.text 2415570 2415458 -112 -0.0
bridge-app debug+rpc (read only) 2364297 2364185 -112 -0.0
.text 1999730 1999618 -112 -0.0
chip-tool debug (read only) 10474833 10474753 -80 -0.0
.text 8443028 8442916 -112 -0.0
chip-tool-ipv6only arm64 .text 7791092 7791060 -32 -0.0
lighting-app debug+rpc (read only) 2587641 2587545 -96 -0.0
.text 2198338 2198210 -128 -0.0
lock-app debug (read only) 2571841 2571761 -80 -0.0
.text 2169634 2169522 -112 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473465 2473353 -112 -0.0
.text 2089026 2088914 -112 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 .text 1972624 1972576 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5403185 5403073 -112 -0.0
.text 4794690 4794578 -112 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b366e2 4962d87 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670775 670831 56 0.0
(read/write) 180608 180552 -56 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 581988 582044 56 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636311 636367 56 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558260 558316 56 0.0
lock-ftd LP_CC2652R7 (read only) 672619 672683 64 0.0
(read/write) 168948 168884 -64 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595728 595792 64 0.0
lock-mtd LP_CC2652R7 (read only) 655171 655227 56 0.0
(read/write) 182084 182028 -56 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101355 101355 0 0.0
.text 553336 553392 56 0.0
pump-app LP_CC2652R7 (read only) 682855 682911 56 0.0
(read/write) 159520 159464 -56 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89295 89311 16 0.0
.text 593076 593116 40 0.0
pump-controller-app LP_CC2652R7 (read only) 667319 667375 56 0.0
(read/write) 175192 175136 -56 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84839 84855 16 0.0
.text 582000 582040 40 0.0
shell LP_CC2652R7 (read only) 663450 663514 64 0.0
(read/write) 183452 183388 -64 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577716 577780 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584390 584446 56 0.0
.app_xip_area 461192 461248 56 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590310 590374 64 0.0
.app_xip_area 462328 462392 64 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589378 589434 56 0.0
.app_xip_area 466996 467052 56 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096180 1096252 72 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961244 961316 72 0.0
BRD4161A+rpc (read/write) 1150444 1150516 72 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998612 998684 72 0.0
BRD4161A+rs911x (read/write) 985700 985788 88 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821440 821528 88 0.0
lock-app BRD4161A+wf200 (read/write) 1136272 1136336 64 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989364 989428 64 0.0
window-app BRD4161A (read/write) 1087912 1087984 72 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951504 951576 72 0.0
esp32 all-clusters-app c3devkit (read only) 1025886 1025924 38 0.0
(read/write) 1487370 1487410 40 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217000 217040 40 0.0
.flash.text 1025886 1025924 38 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079191 1079203 12 0.0
(read/write) 489368 489384 16 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247388 247404 16 0.0
.flash.text 1073807 1073819 12 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643484 643532 48 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569000 569048 48 0.0
lock k32w0+release (read/write) 700876 700940 64 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 625912 625976 64 0.0
linux all-clusters-app debug (read only) 3024513 3024401 -112 -0.0
(read/write) 155752 155752 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85416 85416 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272843 272843 0 0.0
.text 2572738 2572626 -112 -0.0
all-clusters-minimal-app debug (read only) 2864737 2864625 -112 -0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272939 272939 0 0.0
.text 2415570 2415458 -112 -0.0
bridge-app debug+rpc (read only) 2364297 2364185 -112 -0.0
(read/write) 127416 127416 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 202088 202088 0 0.0
.text 1999730 1999618 -112 -0.0
chip-tool debug (read only) 10474833 10474753 -80 -0.0
(read/write) 646464 646464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611800 611800 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 535445 535477 32 0.0
.text 8443028 8442916 -112 -0.0
chip-tool-ipv6only arm64 (read only) 9885180 9885180 0 0.0
(read/write) 694145 694145 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639360 639360 0 0.0
.dynamic 560 560 0 0.0
.got 13648 13648 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466764 466796 32 0.0
.text 7791092 7791060 -32 -0.0
lighting-app debug+rpc (read only) 2587641 2587545 -96 -0.0
(read/write) 130008 130008 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218736 218768 32 0.0
.text 2198338 2198210 -128 -0.0
lock-app debug (read only) 2571841 2571761 -80 -0.0
(read/write) 125376 125376 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235696 235728 32 0.0
.text 2169634 2169522 -112 -0.0
ota-provider-app debug (read only) 2349409 2349313 -96 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207928 32 0.0
.text 1978162 1978034 -128 -0.0
ota-requestor-app debug (read only) 2473465 2473353 -112 -0.0
(read/write) 126248 126248 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2089026 2088914 -112 -0.0
shell debug (read only) 2593457 2593329 -128 -0.0
(read/write) 141904 141904 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233330 233330 0 0.0
.text 2201922 2201794 -128 -0.0
thermostat-no-ble arm64 (read only) 2349804 2349804 0 0.0
(read/write) 141649 141649 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139668 139716 48 0.0
.text 1972624 1972576 -48 -0.0
tv-app debug (read only) 3167265 3167169 -96 -0.0
(read/write) 257864 257864 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 257608 257640 32 0.0
.text 2719890 2719762 -128 -0.0
tv-casting-app debug (read only) 5403185 5403073 -112 -0.0
(read/write) 158856 158856 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98608 98608 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340529 340529 0 0.0
.text 4794690 4794578 -112 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452504 2452520 16 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415148 1415164 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177763 1177807 44 0.0
bss 143222 143222 0 0.0
rodata 142756 142768 12 0.0
text 812932 812968 36 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157819 1157863 44 0.0
bss 142460 142460 0 0.0
rodata 134452 134464 12 0.0
text 802084 802128 44 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690932 1691004 72 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530728 1530800 72 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1635132 1635220 88 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475648 1475736 88 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553844 1553932 88 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402680 1402768 88 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1591124 1591212 88 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1435464 1435552 88 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805912 805992 80 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569664 569708 44 0.0
lighting-app tlsr9518adk80d (read/write) 827720 827800 80 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587640 587682 42 0.0

@yunhanw-google yunhanw-google merged commit 29a2a29 into project-chip:master Aug 8, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Aug 10, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @bzbarsky-apple @isiu-apple
Fix status report handling in read handler (project-chip#21374)
4a8e698 
* Fix status report handling in read handler

* address comments

* Update src/app/tests/TestReadInteraction.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/tests/TestReadInteraction.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/tests/TestReadInteraction.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/tests/TestReadInteraction.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Fix

1. Once message is passed to OnReadInitialRequest in read handler, if
   anything bad in incoming message, handler would send status report
   with invalid action, if there is not enough resource for paths in IM
   engines, we would send status report with exhansted path.
2. Fix fake build in linux,  it seems this build don't have IM schema check.
Usually without CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK, if schema error
happens, we would get a little bit more detailed error, here, we add
additional error check in TestReadHandlerInvalidAttributePath.

* address comments

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @bzbarsky-apple @yufengwangca @woody-apple