Improve ProcessStatusResponse #21331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
-- Improve ProcessStatusResponse signature so that we can tell if the error is caused by malformed status response or the error is from stored value inside status response.
yunhanw-google
force-pushed
the
feature/improve_ProcessStatusResponse
branch
from
7980942 to
e51b359
Compare
bzbarsky-apple
requested changes
Jul 28, 2022
bzbarsky-apple
approved these changes
Jul 28, 2022
yufengwangca
approved these changes
Jul 28, 2022
bzbarsky-apple
force-pushed
the
feature/improve_ProcessStatusResponse
branch
from
1b90288 to
9213ea7
Compare
|
PR #21331: Size comparison from 8fe4727 to 9213ea7 Increases (31 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
* Improve ProcessStatusResponse -- Improve ProcessStatusResponse signature so that we can tell if the error is caused by malformed status response or the error is from stored value inside status response. * address comments * Fix unexpected non-StatusResponse handling. Co-authored-by: Boris Zbarsky <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 28, 2022
* Improve ProcessStatusResponse -- Improve ProcessStatusResponse signature so that we can tell if the error is caused by malformed status response or the error is from stored value inside status response. * address comments * Fix unexpected non-StatusResponse handling. Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: yunhanw-google <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Improve ProcessStatusResponse -- Improve ProcessStatusResponse signature so that we can tell if the error is caused by malformed status response or the error is from stored value inside status response. * address comments * Fix unexpected non-StatusResponse handling. Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Improve ProcessStatusResponse signature so that we can tell if the
error is caused by malformed status response or the error is from stored
value inside status response.
This PR is cut from #19356.
Change overview
See above
Testing
no logic change, the existing test covers.